From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: vamshi gajjela <vamshigajjela@google.com>
Cc: "Stephen Boyd" <sboyd@kernel.org>,
"Abel Vesa" <abelvesa@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Peter Griffin" <peter.griffin@linaro.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Jim Wylder" <jwylder@google.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] spmi: Add SmartDV SPMI controller driver
Date: Fri, 6 Nov 2026 17:58:40 +0100 [thread overview]
Message-ID: <au4HBJBd7AD6WCeY@monoceros> (raw)
In-Reply-To: <20261103042608.387626-4-vamshigajjela@google.com>
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
Hello,
On Tue, Nov 03, 2026 at 09:56:07AM +0530, vamshi gajjela wrote:
> +#include <linux/mod_devicetable.h>
> [...]
> +#include <linux/platform_device.h>
Please don't use <linux/mod_devicetable.h>. <linux/platform_device.h> is
good enough to provide of_device_id already. If you insist on full iwyu,
please use <linux/device-id/of.h> instead.
> [...]
> +static const struct of_device_id smartdv_spmi_of_match[] = {
> + { .compatible = "smartdv,spmi" },
> + {}
{ } please
> +};
> +MODULE_DEVICE_TABLE(of, smartdv_spmi_of_match);
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-11-06 16:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 4:26 [PATCH 0/3] spmi: Add SmartDV SPMI controller driver and bindings vamshi gajjela
2026-11-03 4:26 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add smartdv vamshi gajjela
2026-11-04 14:08 ` Krzysztof Kozlowski
2026-11-03 4:26 ` [PATCH 2/3] dt-bindings: spmi: Add SmartDV SPMI controller vamshi gajjela
2026-11-03 18:16 ` Conor Dooley
2026-11-04 14:14 ` Krzysztof Kozlowski
2026-11-03 4:26 ` [PATCH 3/3] spmi: Add SmartDV SPMI controller driver vamshi gajjela
2026-11-06 16:58 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=au4HBJBd7AD6WCeY@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=abelvesa@kernel.org \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jwylder@google.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=vamshigajjela@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®