From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=194.117.254.33 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794078754; b=1UR9N9yE+a/B7hJlV9dE7ZyVKp5A+JFSYrZ6Qdv1ioS5quuBJLPsjzRpDGQLICPpS3eN ABPLhVf9OJ8Q6E0WzZjhXjLbZCd1q1k59VtWLIrbYlPe0ourl2AlqxY+j6AaC/XBnW+Lb TtWFowi8JEIPgy7CCnUNJZcP9fICoWpoezsa+a3t0+wmQyk0vgvUhFe1c5RVbCXdHqEEF dwTBYa3NCZxZLdRQ4Iqu2i67wvoMBVcGTW86Z9AkG/oXFoGpxraQl1EcEMleEQEturOkN K8yukgajRVuIsQpa1RBrvmRpwzM50/Xm7kQA5yG5Iu6VGF96cfWNQi/1vNrFstiCbEQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794078754; h=DMARC-Filter:DKIM-Signature:Received:Received:X-UD-Smtp-Session:Date: From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; bh=epjkfjykBqSJWWauLayZ+xNrdWN9n/QQ/qi/Q2CXCVY=; b=4c/m+50hbcExFHTQHnSbTsfpM4cJ7L4K85pOvDpMLvnBb7OPV7RaxJhtT+cP4jrOXAKc 8ojmDXd4mSR2Og7dZ8YzgigII4scUsGuUVOFEULunqGBJs7vHT9T4bGVTEeXHSoD5rt/F 5BVK9i5J809sli2RCKyLRXkS9A6Arog80xhWC+KcYOgUZLmL0wkgIrOT/bjd8IrxRQE7p bwJLYuFHxeV62Ff4+1xfhbqEMdelss53xhIOUP9oqOwewoxXic/V0e5DnNsSFWJFVOOCO oU8moD3TExklpLYMPW8oBZMjr2EhD842ZxyG9rvJ1i9OeKTDXqZTzi3M7mzefhXauhQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass header.d=sang-engineering.com header.i=@sang-engineering.com header.a=rsa-sha256 header.s=k1 header.b=Xk9vQt2J; arc=none smtp.remote-ip=194.117.254.33 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEEFA606A32D for ; Sat, 7 Nov 2026 19:12:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org AEEFA606A32D Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=sang-engineering.com header.i=@sang-engineering.com header.a=rsa-sha256 header.s=k1 header.b=Xk9vQt2J DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=epjk fjykBqSJWWauLayZ+xNrdWN9n/QQ/qi/Q2CXCVY=; b=Xk9vQt2JqutShzgO0Cgl Xy2omBKpJYFfSXxGPpOE9+4E8fKfjqTPsrA6F8pwk48ci5XYlz7E4Qw8oTFxagI4 Ht6DshN3U6RCymBfgQ/q1zbsPVVh4zMMjaRjcm0hiQAO5UQDkNMykov0kyqER5LB h4gaOyVIPDiUJccRigcHZoYaZKnJtpL5I+++aDaH+ZMmAOtkIRWa+1LaxyW2DNiZ c86wHcRDasfqVMaV3rStmDUH4LiLosSQ7Gwq7CSVL8Or18mAkzgshP0oR+uhoVGY vggBf2XpcTM24w6ToTXbZ5qpRdrMGyhAP8xEbrYR8WPvBOULDUH+xhHKD2jlJlQf yg== Received: (qmail 2591686 invoked from network); 7 Nov 2026 20:12:28 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 7 Nov 2026 20:12:28 +0100 X-UD-Smtp-Session: l3s3148p1@3dFtgrRf8IoFFu4l Date: Sat, 7 Nov 2026 21:12:26 +0200 From: Wolfram Sang To: Guangshuo Li Cc: Mika Westerberg , Andy Shevchenko , Nirujogi Pratap , Bin Du , Andi Shyti , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i2c: designware: amdisp: balance genpd on probe failure Message-ID: References: <20260708090552.739789-1-lgs201920130244@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4WAgGPXbT/Y0ijjU" Content-Disposition: inline In-Reply-To: <20260708090552.739789-1-lgs201920130244@gmail.com> --4WAgGPXbT/Y0ijjU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 08, 2026 at 05:05:52PM +0800, Guangshuo Li wrote: > The change referenced by the Fixes tag avoids a runtime PM resume during > probe by powering the ISP domain directly with dev_pm_genpd_resume() > before calling i2c_dw_probe(). Runtime PM is enabled only after > i2c_dw_probe() has succeeded. >=20 > However, the i2c_dw_probe() failure path still uses the old runtime PM > cleanup path. At that point pm_runtime_enable() has not been called yet, > so pm_runtime_disable() is not paired with any enable. The failure path > also skips the dev_pm_genpd_suspend() needed to balance the direct > dev_pm_genpd_resume() call. >=20 > Suspend the genpd on the i2c_dw_probe() failure path instead of disabling > runtime PM. This keeps the direct genpd resume/suspend pairing symmetric > on both success and failure paths. >=20 > Fixes: e2f1ada8e089 ("i2c: designware: amdisp: Fix resume-probe race cond= ition issue") > Signed-off-by: Guangshuo Li > Acked-by: Pratap Nirujogi > Acked-by: Mukesh Kumar Savaliya > Acked-by: Bin Du > Tested-by: Bin Du Acked-by: Wolfram Sang I'll put it in my for-andi branch, but actually this is a fix for this cycle. --4WAgGPXbT/Y0ijjU Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmrveBoACgkQFA3kzBSg KbYdPxAAjFL6UhN3auOvq4H2n1B3Etfrq/KaLd8yaQtv5cVo+osovbVdcsmXvakF hLLxaF/VIXlDwJ0xmSODXnX7cBLWUbaJejJpbElXInKlyfcEvnqgHRqnXN4JoGEA gcrG8Z7aDZv474L9h928upjGZ5ji6Ja3JdGwBjGg6EXhYtPWrmf/e6LUp7rrXmRr J2fkSJKQ/KlN3UGY55QF/28QDzEUVCnaBeO3JK8Xb+g6NmNcE18XtZbWBte7hDKL Dt2YeEsC7I0fTxAwgG9fEd+fH4GmRrVaYAlVWwvHHPDHOyh2sjuSOvZ9+wpVXDOf oSlPgfs5M5b9NNvo4z/gqcSCY6ndPDUtLbyGkgqvlPzo4kzWwLz1kCDo5z0NyfBU oArmK055Nzjix9rx01SK0/mj2DvroSAiUh9YZQWUziMENGYbljfk3OcOwOGzLYYE SUjNhmepqr4Q8Zjs7j73haaLMEIg+ANg2gq5dyWRbwwlNpjDHFVOOqskiLcBn2vH 6kURxeHwmEv61LrN3YP+pH3GAAeSSkOgCixoURVGaGvTcNdtgG5acRvh85ac7rPX 3E6IcQQ36tFbk1d8TEwwHrvpH3ajYKeyIoH3V59+XGX8tbvWRor+4AdebB+MN/O0 3n6fzI9/pe0a8safgHsBn3sGz3ueNOJyIKf9Cn86eZ141mT6wdA= =KFNT -----END PGP SIGNATURE----- --4WAgGPXbT/Y0ijjU--