From: Hyunchul Lee <hyc.lee@gmail.com>
To: Baolin Liu <liubaolin12138@163.com>
Cc: linkinjeon@kernel.org, ntfs@lists.linux.dev,
linux-kernel@vger.kernel.org, wangxuewen@kylinos.cn,
wudandan@kylinos.cn
Subject: Re: [PATCH v4 06/31] ntfs: report required system file and volume metadata errors
Date: Tue, 27 Oct 2026 14:50:02 +0900 [thread overview]
Message-ID: <auA7imuJoZKDGzpa@hyunchul-PC02> (raw)
In-Reply-To: <20261020084421.2196486-7-liubaolin12138@163.com>
> @@ -1685,23 +1718,29 @@ static int load_and_check_badclus(struct ntfs_volume *vol)
> size_t i;
> int err;
>
> - base_ino = ntfs_iget(sb, FILE_BadClus);
> + base_ino = ntfs_system_iget(vol, FILE_BadClus);
> if (IS_ERR(base_ino))
> return PTR_ERR(base_ino);
> if (!S_ISREG(base_ino->i_mode)) {
> - err = -EIO;
> + err = -EFSCORRUPTED;
> + ntfs_report_metadata_error(vol, -EFSCORRUPTED);
ntfs_report_*_metadata_error() calls seem to be repeated across serveral
functions. Would it be possible to move and call them right before
returing from the fucntion? Also, could you apply the same change to the
other patches as well?
> goto iput_base;
> }
--
Thanks,
Hyunchul
next prev parent reply other threads:[~2026-10-27 5:50 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 8:43 [PATCH v4 00/31] ntfs: report filesystem errors through fsnotify Baolin Liu
2026-10-20 8:43 ` [PATCH v4 01/31] ntfs: propagate mapping-pairs update errors from inode writeback Baolin Liu
2026-10-20 8:43 ` [PATCH v4 02/31] ntfs: preserve cluster-free counts in attribute cleanup Baolin Liu
2026-10-20 8:43 ` [PATCH v4 03/31] ntfs: add filesystem metadata error reporting helpers Baolin Liu
2026-10-20 8:43 ` [PATCH v4 04/31] ntfs: preserve attribute search context initialization errors Baolin Liu
2026-10-27 5:46 ` Hyunchul Lee
2026-10-27 6:16 ` liubaolin
2026-10-20 8:43 ` [PATCH v4 05/31] ntfs: report boot geometry and MFT bootstrap errors Baolin Liu
2026-10-27 5:48 ` Hyunchul Lee
2026-10-27 6:18 ` liubaolin
2026-10-20 8:43 ` [PATCH v4 06/31] ntfs: report required system file and volume metadata errors Baolin Liu
2026-10-27 5:50 ` Hyunchul Lee [this message]
2026-10-27 6:19 ` liubaolin
2026-10-20 8:43 ` [PATCH v4 07/31] ntfs: report logfile metadata and emptying errors Baolin Liu
2026-10-20 8:43 ` [PATCH v4 08/31] ntfs: report runlist and cluster allocation metadata errors Baolin Liu
2026-10-20 8:43 ` [PATCH v4 09/31] ntfs: report iomap corruption and preserve buffered read errors Baolin Liu
2026-10-20 8:44 ` [PATCH v4 10/31] ntfs: report LZNT1 and WOF compressed stream errors Baolin Liu
2026-10-20 8:44 ` [PATCH v4 11/31] ntfs: handle source record removal failure during attribute moves Baolin Liu
2026-10-20 8:44 ` [PATCH v4 12/31] ntfs: report attribute lookup and validation errors Baolin Liu
2026-10-20 8:44 ` [PATCH v4 13/31] ntfs: report attribute record update and cleanup failures Baolin Liu
2026-10-20 8:44 ` [PATCH v4 14/31] ntfs: report attribute list update and recovery failures Baolin Liu
2026-10-20 8:44 ` [PATCH v4 15/31] ntfs: report attribute conversion and mapping update failures Baolin Liu
2026-10-20 8:44 ` [PATCH v4 16/31] ntfs: report attribute resize and relocation recovery failures Baolin Liu
2026-10-20 8:44 ` [PATCH v4 17/31] ntfs: report incomplete attribute range updates Baolin Liu
2026-10-20 8:44 ` [PATCH v4 18/31] ntfs: report inode metadata and eviction cleanup errors Baolin Liu
2026-10-20 8:44 ` [PATCH v4 19/31] ntfs: report index validation and block I/O errors Baolin Liu
2026-10-20 8:44 ` [PATCH v4 20/31] ntfs: preserve index traversal errors and directory retries Baolin Liu
2026-10-20 8:44 ` [PATCH v4 21/31] ntfs: report directory lookup and metadata corruption Baolin Liu
2026-10-20 8:44 ` [PATCH v4 22/31] ntfs: report index update and recovery failures Baolin Liu
2026-10-20 8:44 ` [PATCH v4 23/31] ntfs: report namespace and file recovery errors Baolin Liu
2026-10-20 8:44 ` [PATCH v4 24/31] ntfs: serialize and report export parent reconstruction errors Baolin Liu
2026-10-20 8:44 ` [PATCH v4 25/31] ntfs: report MFT record validation and lifecycle errors Baolin Liu
2026-10-20 8:44 ` [PATCH v4 26/31] ntfs: report MFT bitmap and data growth recovery failures Baolin Liu
2026-10-20 8:44 ` [PATCH v4 27/31] ntfs: report MFT writeback errors to fsnotify Baolin Liu
2026-10-20 8:44 ` [PATCH v4 28/31] ntfs: report EA metadata and restoration errors Baolin Liu
2026-10-27 5:51 ` Hyunchul Lee
2026-10-27 6:20 ` liubaolin
2026-10-20 8:44 ` [PATCH v4 29/31] ntfs: report named stream metadata and recovery errors Baolin Liu
2026-10-20 8:44 ` [PATCH v4 30/31] ntfs: report reparse and object ID metadata errors Baolin Liu
2026-10-20 8:44 ` [PATCH v4 31/31] ntfs: report each shutdown transition once Baolin Liu
2026-10-20 9:01 ` [PATCH v4 00/31] ntfs: report filesystem errors through fsnotify liubaolin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auA7imuJoZKDGzpa@hyunchul-PC02 \
--to=hyc.lee@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liubaolin12138@163.com \
--cc=ntfs@lists.linux.dev \
--cc=wangxuewen@kylinos.cn \
--cc=wudandan@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®