From: Jarkko Sakkinen <jarkko@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: David Howells <dhowells@redhat.com>,
keyrings@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Graf <tgraf@suug.ch>,
Herbert Xu <herbert@gondor.apana.org.au>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:RHASHTABLE" <linux-crypto@vger.kernel.org>,
"open list:SECURITY SUBSYSTEM"
<linux-security-module@vger.kernel.org>
Subject: Re: [PATCH v3 5/6] KEYS: Replace assoc_array with rhashtable
Date: Tue, 27 Oct 2026 04:56:14 +0200 [thread overview]
Message-ID: <auASzrhH1Q0linVB@kernel.org> (raw)
In-Reply-To: <20261027012952.GC2395@quark>
On Mon, Oct 26, 2026 at 06:29:52PM -0700, Eric Biggers wrote:
> How about replacing 'struct keyring_link *edit[2]' with a named struct?
> It's kind of hard to remember what [0] and [1] are.
I'll look go through rest of the comments later but since it is two vs
one with using named struct (David propose named struct) let's go with
that.
I.e., along the lines of:
struct keyring_edit {
struct keyring_link *new;
struct keyring_link *old;
};
>
> - Eric
Br, Jarkko
next prev parent reply other threads:[~2026-10-27 2:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 0:10 [PATCH v3 0/6] " Jarkko Sakkinen
2026-10-25 0:10 ` [PATCH v3 1/6] KEYS: Expand key->{datalen,quotalen} to unsigned int Jarkko Sakkinen
2026-10-25 0:10 ` [PATCH v3 2/6] KEYS: Reject descriptions larger than KEY_MAX_DESC_SIZE Jarkko Sakkinen
2026-10-25 0:10 ` [PATCH v3 3/6] KEYS: Verify the key identity in __key_unlink_begin Jarkko Sakkinen
2026-10-25 0:10 ` [PATCH v3 4/6] KEYS: Introduce keyring_is_empty() Jarkko Sakkinen
2026-10-26 23:55 ` Eric Biggers
2026-10-27 0:01 ` Jarkko Sakkinen
2026-10-25 0:10 ` [PATCH v3 5/6] KEYS: Replace assoc_array with rhashtable Jarkko Sakkinen
2026-10-27 1:29 ` Eric Biggers
2026-10-27 2:56 ` Jarkko Sakkinen [this message]
2026-10-27 3:00 ` Jarkko Sakkinen
2026-10-25 0:10 ` [PATCH v3 6/6] lib: Remove assoc_array Jarkko Sakkinen
2026-10-26 23:57 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auASzrhH1Q0linVB@kernel.org \
--to=jarkko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=tgraf@suug.ch \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®