From: Ben Boeckel <me@benboeckel.net>
To: Tang Bin <tangbin@cmss.chinamobile.com>
Cc: dhowells@redhat.com, lukas@wunner.de, ignat@linux.win,
herbert@gondor.apana.org.au, davem@davemloft.net,
keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] certs: Print correct error on pkcs7_parse_message() failure
Date: Mon, 26 Oct 2026 22:57:55 -0400 [thread overview]
Message-ID: <auATM8gAJhFngmQ_@rotor.dev.benboeckel.internal> (raw)
In-Reply-To: <20261025025830.2239-1-tangbin@cmss.chinamobile.com>
On Sun, Oct 25, 2026 at 10:58:29 +0800, Tang Bin wrote:
> The panic on IS_ERR(pkcs7) printed 'ret', which still holds the result of
> the prior successful x509_load_certificate_list() (0) rather than the pkcs7
> parse error. Use PTR_ERR(pkcs7) and %ld so the real failure code is
> reported.
>
> Fixes: 8cd9f234f706 ("certs: Move RSA self-test data to separate file")
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Already submitted:
https://www.spinics.net/lists/keyrings/msg19526.html
--Ben
prev parent reply other threads:[~2026-10-27 2:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 2:58 Tang Bin
2026-10-27 2:57 ` Ben Boeckel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auATM8gAJhFngmQ_@rotor.dev.benboeckel.internal \
--to=me@benboeckel.net \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=ignat@linux.win \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=tangbin@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®