From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: "Linus Walleij" <linusw@kernel.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Andy Shevchenko" <andy@kernel.org>,
"Lixu Zhang" <lixu.zhang@intel.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Hans de Goede" <hansg@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v4 13/23] gpio: Use named initializers for auxiliary_device_id arrays
Date: Tue, 27 Oct 2026 13:01:22 +0200 [thread overview]
Message-ID: <auCEgktEEKpnKWUx@kekkonen.localdomain> (raw)
In-Reply-To: <ec269df979b1e0a7df04a20eb19505c332679428.1793097104.git.u.kleine-koenig@baylibre.com>
Hi Uwe,
On Tue, Oct 27, 2026 at 11:48:50AM +0100, Uwe Kleine-König (The Capable Hub) wrote:
> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
>
> The mentioned robustness is relevant for a planned change to struct
> auxiliary_device_id that replaces .driver_data by an anonymous union
> (though none of these drivers uses .driver_data, so this patch isn't
> strictly necessary for the plan, but still ok for consistency).
>
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> # gpio-usbio, gpio-ljca
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2026-10-27 11:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 10:48 [PATCH v4 00/23] gpio: Improvements around device-id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 01/23] gpio: Remove __maybe_unused annotations from acpi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 02/23] gpio: fxl6408: Remove __maybe_unused annotations from of_device_id array Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 03/23] gpio: Drop unused assignment of acpi_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 04/23] gpio: max7301: Drop unused assignment of spi_device_id " Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 05/23] gpio: mmio: Drop unused assignment of platform_device_id " Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 06/23] gpio: ljca: Drop unused assignment of auxiliary_device_id " Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 07/23] gpio: xgene: Add missing ACPI module annotation Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 08/23] gpio: sodaville: Add missing PCI module annotations Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 09/23] gpio: Add missing OF " Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 10/23] gpio: pxa: Add missing platform " Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 11/23] gpio: pl061: Use empty initializer for amba_id terminator Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 12/23] gpio: Use named initializers for acpi_device_id array Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 13/23] gpio: Use named initializers for auxiliary_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 11:01 ` Sakari Ailus [this message]
2026-10-27 10:48 ` [PATCH v4 14/23] gpio: pcf857x: Use named initializers for of_device_id array Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 15/23] gpio: bd73800: Use named initializers for platform_device_id array Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 16/23] gpio: Use named initializers for spi_device_id array Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 17/23] gpio: virtio: Use a named initializer for virtio_device_id array Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 18/23] gpio: Unify style of acpi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 19/23] gpio: Unify style of of_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 20/23] gpio: max77620: Unify style of platform_device_id array Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 21/23] gpio: Unify style of spi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 10:48 ` [PATCH v4 22/23] gpio: Unify style of pci_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 10:49 ` [PATCH v4 23/23] gpio: Unify style of various *_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-28 13:57 ` [PATCH v4 00/23] gpio: Improvements around device-id arrays Alan Borzeszkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auCEgktEEKpnKWUx@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=andy@kernel.org \
--cc=brgl@kernel.org \
--cc=hansg@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=nuno.sa@analog.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®