From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.214.174 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793130213; b=p1JRID1EBhD7BTBmif4O4xxFdj1u2vtD724OtFbf0dAieeEShiSFhH7neAo6Oh51W1oU ngai/Vz16MSOPwfmYzIWkIM9GkyZqmW3UCyk5H8xjVQ3N7ltejvuEJIfIzs8J2nXpNup4 gLMnUOuGa7FE6biz0O4ypWM/P30IuJ0phX/O/skbzIe3FUhgcQJsLrUMpQGOKdZm3Y6yX tTf9MyfTEhloGLKufRnOLN8+vBzeEn4jpZllT57dthVuxiNtA4uuKBm7W98BLd3WwqjQ8 sq20f7nTii5DGbxLqX4N+amDEpmT5qoyDPXEeie8msgIzVx17mFMaVbj0CotYvOh2ng== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793130213; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=Kt3m2QX4pRtZBRcLH3IFIQTcdgR87dlcnUp5/WDyAss=; b=CNdHrO+HkR4nVisnukJCy2kR6tK0XkrtvQ2lOfvxPP1+ZoN7RbKrbW89Gz92R1jnynm2 slc/1CfMBBtoU8Vw2HwR7mzSLJFrn0loX5M0MmBKyY4iWHurTqQB9MMJ3uMxcCJSwJmFV LvtctgPwS5A3tI1wiCfa2S0w1/3pdyCiuWWyy7YnNnkPlts/kGjfViNA0OA3Bb7Bp7DUm CcKX4vFCgBDnQhXtOcqyaWvQtxSGSeEfnKgVrrd73iGuWZlHuwcL2euuJFx/HzCnQoOOW 0SAIagGjbvCVACHzvr8qYezGcRSab3USPYSaDRhc6moEIlpehptMGr8s9+bzVVbev2A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=fKvu3sFl; arc=none smtp.remote-ip=209.85.214.174 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2B99606A31A for ; Tue, 27 Oct 2026 19:43:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B2B99606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=fKvu3sFl Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2db33db4de9so14945ad.0 for ; Tue, 27 Oct 2026 12:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793130212; x=1793735012; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Kt3m2QX4pRtZBRcLH3IFIQTcdgR87dlcnUp5/WDyAss=; b=fKvu3sFl+ouMpBGe8QCxA/Po0tluUmY2cadQ5kspAESt99gU0otrCAvnCSeV7d6AMG nOJN76SW+5T4b89TdCObf7StqhqC5yuKT0Xa/e/MapWdVtpzLtKN2Qlut3EgtOYh/7BP MPFGdTIbjbI3NMLynzjswqcJUo6qUs4Fbp/l6sbS7XErYabWce0lM97r2Muq1h+B+NOY yACxHY1q+u2K8gXE1fj0nLilv5P5r0KMvBJx1xD0NR2cp9VharpDnFu2LcIgoIKT6gV2 PJlApj1CY8zjAhY9JN3oV8+YwlHOQb/i9h/w7so1nt9/GQ6yRkZ8QtO/Y3IZocJ0d2Lu EPaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793130212; x=1793735012; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Kt3m2QX4pRtZBRcLH3IFIQTcdgR87dlcnUp5/WDyAss=; b=juWs/XhDgot3KzWTMDq66QnM/xZBKt9a4K+JlQuNqtVmpnhXTi6KyttJLQR5x7zx2K iMcDGxiRbr6gR+GzSle+ID4epN41L6FhgPwOT/3BN2TsN2O7B2LgDfSIdz06laSM/Vhi 8rVf5RbHJ1t7p3T6zo7sc27WGLrkTx3vIggQUwS1AsD2x3LBpVoQ0DoTefNQSRKujd2p Hq7m+afdvrboieQneWnUEpERdxKB9P9ApS+4+HV2T6OU2uRYS/+BfHK48gB/Hxs+4fiv m1OflNExVqyGCnZg2+ye1MQxm2wIsbdvQ5NfmkjdnhWBDtPbqFogA/d0lnr/RMbXJbxn 4npQ== X-Forwarded-Encrypted: i=1; AKwUvBzDMJdecXqb1MXMOnY37dcizH1jhX7AAHKoPjbfR3pTw3e1bSCYDkUYR43KekGvdWo+ZvGEtEI2GpiBeJ0=@vger.kernel.org X-Gm-Message-State: AFq9FYKmAjpIcy44usABvdKFXRbc+PvGDglLk4XKnpgGyO8lrSInCrx0 aOBDmdY5cWNN3O58itCdIpqi5InzUvag//4Icvi2a3SmyqGRUXsZrxiLrLb7xQ9MuA== X-Gm-Gg: AYBFou1i9b2vVy5oZYJC8/CTYMPh26pMuvjM+QCE+ii6EJ+XMPihYHoObnVNc3QiQPF ZmSpZObtR7JyhwPXE43idgAjxH5obIfa30goVsYZesIgwcBSszVxCNrjR36Prhsfw660t6xadBz jBzoiA/yi/3IMP+4AESxvHpa60N/dnB8JX6ap+VcDG3BLTsokeocsZtiU2M9W3e4xBAvMi2NtSN AcvyeFo6IiOKjTBR34nxkQ/DTMFYY33TGztQxoSXo9+aOhNekfTEgUfU956OHCZvHPuuHISe64j bYFTz1s9RSjEDX0aRZ7tLauaT9bDUc+2I7B/BBDSRH1PKvjMMB+oqSrcERvNTDjfnJTlpOWG8ew +PwLE6RXv72RoCv8A1pOUEWEUk9ZQ8Zr8FkVyMJuDAcrNT+7HcKyUsbzN8zkl9PjHnBTMn3+0t6 sY0CV40TTWBuUqGaDLTBYlXfkWxnBcyJ6UbNsN4+JJeWWv/B7S2NMPMA5zM2z6bgr+MWh0+hS/W j2VEXj8kRcESISdfjhpAc3GrN/jOGLHHWB/VdeORtGfHtTnNURdI6tks8cNxMDhcRX08mCiM8vS vtULE/WVWDyzEcfbxbiiEDKNZatUnN55Ob5itn0joN+iPfWQ X-Received: by 2002:a17:902:d550:b0:2ea:4a1:e8a4 with SMTP id d9443c01a7336-2eb01986bddmr124955ad.13.1793130211108; Tue, 27 Oct 2026 12:43:31 -0700 (PDT) Received: from google.com (163.1.145.34.bc.googleusercontent.com. [34.145.1.163]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ae578f19b3sm251941a91.17.2026.10.27.12.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2026 12:43:30 -0700 (PDT) Date: Tue, 27 Oct 2026 19:43:26 +0000 From: Samiullah Khawaja To: "David Hildenbrand (Arm)" Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Qi Zheng , Shakeel Butt , Lorenzo Stoakes , Kairui Song , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Baoquan He , Baolin Wang , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Kees Cook , Peter Zijlstra , Jann Horn , Pedro Falcato , Hugh Dickins , Pasha Tatashin , Pratyush Yadav , "Matthew Wilcox (Oracle)" , Jan Kara , Zi Yan , Lance Yang , Rik van Riel , Harry Yoo , Alistair Popple , Nico Pache , Ryan Roberts , Dev Jain , Usama Arif , Kiryl Shutsemau , Matthew Brost , John Hubbard , Peter Xu , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Oscar Salvador , Minchan Kim , Muchun Song , Xu Xin , Chengming Zhou , Chris Li , Kemeng Shi , Nhat Pham , Youngjun Park , Gregory Price , Joshua Hahn , Rakie Kim , Ying Huang , Jason Gunthorpe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, Chris Mason , stable@vger.kernel.org Subject: Re: [PATCH 20/46] mm/gup: fix clearing folios in memfd_pin_folios() Message-ID: References: <20261027-fixes_core-v1-0-6f74bec9a5bb@kernel.org> <20261027-fixes_core-v1-20-6f74bec9a5bb@kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20261027-fixes_core-v1-20-6f74bec9a5bb@kernel.org> On Tue, Oct 27, 2026 at 12:17:40AM +0100, David Hildenbrand (Arm) wrote: >From: Chris Mason > >memfd_pin_folios() pins folios obtained directly from the page cache >without checking whether they are uptodate. However, shmem fallocate() >can leave newly allocated folios uncleared and not uptodate. Callers >such as udmabuf can then expose uninitialized memory to userspace. > >Clear non-uptodate folios and mark them uptodate under the folio lock >before returning them to the caller. > >Fix generated by an LLM and sent by Chris Mason in private. > >Fixes: 89c1905d9c14 ("mm/gup: introduce memfd_pin_folios() for pinning memfd folios") >Cc: stable@vger.kernel.org >Signed-off-by: Chris Mason >[ david: simplify description and comment ] >Signed-off-by: David Hildenbrand (Arm) >--- > mm/gup.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > Reviewed-by: Samiullah Khawaja Tested-by: Samiullah Khawaja Thanks, Sami