From: Keith Busch <kbusch@kernel.org>
To: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com>
Cc: linux-nvme@lists.infradead.org, axboe@kernel.dk, hch@lst.de,
sagi@grimberg.me, hare@kernel.org, sgogte@purestorage.com,
wagi@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme-tcp: fix request PDU size when header digest is enabled
Date: Tue, 27 Oct 2026 10:04:43 -0600 [thread overview]
Message-ID: <auDLmzKWOZNBNpOR@kbusch-mbp> (raw)
In-Reply-To: <20261026184621.29276-1-christian.aurichzm@gmail.com>
On Mon, Oct 26, 2026 at 03:46:21PM -0300, Christian Aurich Zanettini Martins wrote:
> @@ -566,7 +566,7 @@ static int nvme_tcp_init_request(struct blk_mq_tag_set *set,
> struct nvme_tcp_cmd_pdu *pdu;
> int queue_idx = (set == &ctrl->tag_set) ? hctx_idx + 1 : 0;
> struct nvme_tcp_queue *queue = &ctrl->queues[queue_idx];
> - u8 hdgst = nvme_tcp_hdgst_len(queue);
> + u8 hdgst = ctrl->ctrl.opts->hdr_digest ? NVME_TCP_DIGEST_LENGTH : 0;
I think everything this function needs should be initialized prior to
this function being called.
> mutex_lock(&queue->pf_cache_lock);
See where mutex_init is called for this queue's pf_cache_lock. Can you
move the queue's hdr_digest setting to that location instead?
prev parent reply other threads:[~2026-10-27 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 18:46 Christian Aurich Zanettini Martins
2026-10-27 16:04 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auDLmzKWOZNBNpOR@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=christian.aurichzm@gmail.com \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=sgogte@purestorage.com \
--cc=wagi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®