From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH v7 02/12] gpio: mxc: use for_each_set_bit() to iterate wakeup pads
Date: Tue, 27 Oct 2026 18:35:32 +0200 [thread overview]
Message-ID: <auDS1FpY-kQhP1C6@ashevche-desk.local> (raw)
In-Reply-To: <20261027-gpio-mxc-cleanup-v7-4-v7-2-7b602d70c149@nxp.com>
On Tue, Oct 27, 2026 at 08:09:29PM +0800, Peng Fan (OSS) wrote:
>
> Use for_each_set_bit() to iterate over the enabled wakeup pads instead
> of checking every bit individually.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-27 16:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 12:09 [PATCH v7 00/12] gpio: mxc: probe cleanup Peng Fan (OSS)
2026-10-27 12:09 ` [PATCH v7 01/12] gpio: mxc: use irq_set_irq_wake() to simplify code Peng Fan (OSS)
2026-10-27 14:09 ` Frank Li
2026-10-27 12:09 ` [PATCH v7 02/12] gpio: mxc: use for_each_set_bit() to iterate wakeup pads Peng Fan (OSS)
2026-10-27 16:35 ` Andy Shevchenko [this message]
2026-10-27 12:09 ` [PATCH v7 03/12] gpio: mxc: use 'unsigned int' instead of bare 'unsigned' Peng Fan (OSS)
2026-10-27 14:10 ` Frank Li
2026-10-27 16:36 ` Andy Shevchenko
2026-10-27 12:09 ` [PATCH v7 04/12] gpio: mxc: replace of_device_is_compatible() with hwdata flags Peng Fan (OSS)
2026-10-27 12:09 ` [PATCH v7 05/12] gpio: mxc: convert pad wakeup compatible checks to " Peng Fan (OSS)
2026-10-27 12:09 ` [PATCH v7 06/12] gpio: mxc: use local dev variable Peng Fan (OSS)
2026-10-27 12:09 ` [PATCH v7 07/12] gpio: mxc: use __free guard for runtime PM cleanup Peng Fan (OSS)
2026-10-27 14:12 ` Frank Li
2026-10-27 12:09 ` [PATCH v7 08/12] gpio: mxc: use devres functions to simplify probe code Peng Fan (OSS)
2026-10-27 12:09 ` [PATCH v7 09/12] gpio: mxc: add dev_err_probe() for error paths to help diagnostics Peng Fan (OSS)
2026-10-27 14:13 ` Frank Li
2026-10-27 12:09 ` [PATCH v7 10/12] gpio: mxc: introduce MXC_ICR macros and use field_prep/field_get Peng Fan (OSS)
2026-10-27 12:09 ` [PATCH v7 11/12] gpio: mxc: use BIT() macro for single-bit operations Peng Fan (OSS)
2026-10-27 12:09 ` [PATCH v7 12/12] MAINTAINERS: Add an entry for gpio-mxc Peng Fan (OSS)
2026-10-27 14:14 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auDS1FpY-kQhP1C6@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Frank.Li@nxp.com \
--cc=brgl@kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®