From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Rareș-Mihai Vladu" <vladurares@gmail.com>
Cc: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/5] media: atomisp: queue: move circbuf types and helpers to queue_comm.h
Date: Tue, 27 Oct 2026 19:34:37 +0200 [thread overview]
Message-ID: <auDgrXiArqLC99Vb@ashevche-desk.local> (raw)
In-Reply-To: <20261027120341.2305533-5-vladurares@gmail.com>
On Tue, Oct 27, 2026 at 12:03:39PM +0000, Rareș-Mihai Vladu wrote:
> The remote queue code only needs the circbuf descriptor and element
> layouts plus five small descriptor helpers from the circbuf library.
> Move them into ia_css_queue_comm.h and include that header instead of
> the circbuf ones.
>
> The descriptor and element layouts are shared with the SP firmware and
> are moved unchanged, including their static_asserts.
>
> While at it, drop the OP___assert() NULL checks from the moved helpers,
> as every caller passes the address of a local variable, and convert the
> moved code to the kernel u8/u32 types and the usual function
> declaration style.
Yep, good one
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Next step (after this series lands) is to move from this implementation of
the circular buffer to kFIFO or circbuf from kernel APIs.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-27 17:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 12:03 [PATCH v3 0/5] media: atomisp: remove the circbuf library Rareș-Mihai Vladu
2026-10-27 12:03 ` [PATCH v3 1/5] media: atomisp: sh_css_mipi: include assert_support.h directly Rareș-Mihai Vladu
2026-10-27 12:03 ` [PATCH v3 2/5] media: atomisp: queue: move remote queue handling into helpers Rareș-Mihai Vladu
2026-10-27 17:26 ` Andy Shevchenko
2026-10-27 12:03 ` [PATCH v3 3/5] media: atomisp: queue: remove unused local queue support Rareș-Mihai Vladu
2026-10-27 17:27 ` Andy Shevchenko
2026-10-27 12:03 ` [PATCH v3 4/5] media: atomisp: queue: move circbuf types and helpers to queue_comm.h Rareș-Mihai Vladu
2026-10-27 17:34 ` Andy Shevchenko [this message]
2026-10-27 12:03 ` [PATCH v3 5/5] media: atomisp: remove unused circbuf library Rareș-Mihai Vladu
2026-10-27 17:39 ` [PATCH v3 0/5] media: atomisp: remove the " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auDgrXiArqLC99Vb@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=vladurares@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®