From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dmitry Mikushin <dmitry@kernelgen.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Input: synaptics - enable SMBus for ThinkPad P14s Gen 2i (LEN2072)
Date: Tue, 27 Oct 2026 13:48:58 -0700 [thread overview]
Message-ID: <auEOI-Ay0xGBMd3k@google.com> (raw)
In-Reply-To: <20261026142648.2567233-1-dmitry@kernelgen.org>
On Mon, Oct 26, 2026 at 03:26:45PM +0100, Dmitry Mikushin wrote:
> The ThinkPad P14s Gen 2i touchpad (Synaptics TM3471-030, LEN2072) is
> not on the SMBus passlist and runs in PS/2 mode. Forcing RMI4 alone
> does not help: the F12 attention handler reads the whole 79-byte data
> packet over SMBus on every frame, which caps the report rate at about
> 43 Hz and loses fast swipes.
>
> Patch 1 fixes the size passed to rmi_f12_process_objects(), which
> counted from the start of the data packet instead of from Data1.
> Patch 2 makes F12 read only the registers up to and including Data1,
> raising the report rate to about 65 Hz on this machine. Patch 3 then
> adds LEN2072 to smbus_pnp_ids and should not be applied without
> patch 2.
>
> Tested on a ThinkPad P14s Gen 2i (20VX) on 7.2.9, including s2idle
> suspend/resume and the TrackPoint on the RMI4 pass-through port. On
> this device Data1 is the first data register, so patch 1 does not
> change its behavior.
>
> Changes in v2:
> - New patch 1. Sashiko pointed out that with patch 2 alone, on devices
> where Data1 is not at offset 0, rmi_f12_process_objects() could parse
> bytes past the end of what was read. The underlying off-by-
> data1_offset bound predates this series, so it is fixed separately
> with a Fixes: tag.
> - No changes to patches 2 and 3.
Applied the lot, thank you.
--
Dmitry
prev parent reply other threads:[~2026-10-27 20:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 14:26 Dmitry Mikushin
2026-10-26 14:26 ` [PATCH v2 1/3] Input: synaptics-rmi4 - f12: pass Data1-relative size to process_objects Dmitry Mikushin
2026-10-26 14:26 ` [PATCH v2 2/3] Input: synaptics-rmi4 - f12: read only the object data on attention Dmitry Mikushin
2026-10-26 14:26 ` [PATCH v2 3/3] Input: synaptics - add LEN2072 to smbus_pnp_ids for ThinkPad P14s Gen 2i Dmitry Mikushin
2026-10-27 20:48 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auEOI-Ay0xGBMd3k@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=dmitry@kernelgen.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®