mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: David Ahern <dsahern@kernel.org>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	 Nicolas Dichtel <nicolas.dichtel@6wind.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ipv6: Add NETCONFA_FORCE_FORWARDING to netconf messages
Date: Wed, 28 Oct 2026 11:55:35 +0100	[thread overview]
Message-ID: <auHUbzlVvz7dPJIb@luna.proxmox.com> (raw)
In-Reply-To: <20261025131102.GA184152@shredder>

On 25.10.2026 15:11, Ido Schimmel wrote:
> On Fri, Oct 23, 2026 at 12:59:18PM +0200, Gabriel Goller wrote:
> > Since force_forwarding was added, changing the sysctl sends an
> > RTM_NEWNETCONF notification of type NETCONFA_FORCE_FORWARDING, but
> > inet6_netconf_fill_devconf() never emits the attribute. Listeners only
> > receive NETCONFA_IFINDEX without the new value, and RTM_GETNETCONF
> > replies and dumps omit it as well.
> > 
> > Fixes: f24987ef6959 ("ipv6: add `force_forwarding` sysctl to enable per-interface forwarding")
> > Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> 
> This seems to fall under the "Not a regression, not critical" category
> [1], so can wait for net-next.

Agree, will post when net-next opens again.

> Also, NETCONFA_FORCE_FORWARDING is not emitted when it's disabled as
> part of:
> 
> sysctl -wq net.ipv6.conf.all.forwarding=0
> 
> Is this intentional?

Nope it isn't. Will fix in the next version.

Thanks for the review!
Gabriel

> [1] https://lore.kernel.org/netdev/CAHk-=wiSnTE9vBZ=5_v+3EEkdazCCbBM5YABRzRHUAeRdyd4Xw@mail.gmail.com/


      parent reply	other threads:[~2026-10-28 10:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23 10:59 Gabriel Goller
2026-10-23 11:06 ` netdev-bot+sinfo
2026-10-23 11:15   ` Gabriel Goller
2026-10-25 13:12     ` Ido Schimmel
2026-10-28 10:52       ` Gabriel Goller
2026-10-23 12:12 ` Fernando Fernandez Mancera
2026-10-25 13:11 ` Ido Schimmel
2026-10-26  3:31   ` Hangbin Liu
2026-10-27 21:38     ` Jakub Kicinski
2026-10-28  0:55       ` Hangbin Liu
2026-10-28 10:55   ` Gabriel Goller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auHUbzlVvz7dPJIb@luna.proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®