From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.217.50 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793206438; b=Jzd8Icwb57aD/LVpGsREw5gry+doO7h4HbNMqbXwhVBWTxzylSB8UooftZ/M1OObRVlV K+eXiYkf6c51DQ+gOT9LLRv3Khd2gUbtW1sLtC1KghvUkRBy1eabW67y+PP8kHBuoH2mQ 6GHzA16UXGrI84xT64Tf+fGZjA2oeR/3zt6P2OFuzdMwqc5zSn2xG8kSBCbL+SUeDohvg 9hDRw71OtK1ZLFskVsc96/r07og29la2dayPQ5voKyqcwqmDs5xXGFLtg+CEe4VQt+s8K dufgH4mQOx/lzh7zbitp9/7I6PdR6BbrR9ZEzYiVr6Sbrh9M7YP6yaq6BdrpNNEmFWQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793206438; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=jQ5eyf1zl1dztY8G8GNDjIbe5i6XtlGMZ8AEehh0sP8=; b=fOh7SW0NWvuFUo7NF+vH4SvfhfglDRPAcfnRoQ/O4tWc2RETkc0YG2wlPLrQHt6LiOsg b/21PKZJBl2IAGwAmGNwNsMbj+3hdCvJvtPA6lOTS8Ha7QzCapAxYN4/HOElGEru/9E7c CG/mj5JIDf2SfOvFl8vhbhkx+cyNp4LO5vJgHqFmR7lWOyMeB9J3VpKq6oSQTlGQ1vfQj yBkalq634lTuZ0A2fPUoL/WCgkIn9PCA6iLOFx6+cCEyN8jeSRPv4cHZSf9FxU4sqdf6m 96u53jD3U40mm0WIuUVgCnqFXlCVJtbhhY+tuhugEZCvLjNWwQmCSlFLTuId91pT3AA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass header.d=soleen.com header.i=@soleen.com header.a=rsa-sha256 header.s=google header.b=XDq4mZkF; arc=none smtp.remote-ip=209.85.217.50 Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com [209.85.217.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 645BE606A31F for ; Wed, 28 Oct 2026 16:53:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 645BE606A31F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=soleen.com header.i=@soleen.com header.a=rsa-sha256 header.s=google header.b=XDq4mZkF Received: by mail-vs1-f50.google.com with SMTP id ada2fe7eead31-7777fa8f1ccso341105137.3 for ; Wed, 28 Oct 2026 09:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1793206436; x=1793811236; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=jQ5eyf1zl1dztY8G8GNDjIbe5i6XtlGMZ8AEehh0sP8=; b=XDq4mZkFFwWiuClm+CVqUYc4wMUeEj61wwTEJ2ZEwdKAAZOVs4mAkia9/oOPQEGvZ7 0CPllEZOpo+2Vx7NH/qeJyuqrXNeGxLOX9kPYs9EQ9wuoJxqmE3014fXKocl5hQCZSSq jYT4HKvnmSRh02d1ht2QsIKl81mDMWNV+vmtqq/q3kRlDKFLvoFwvUwOFm0i3nE1GCkQ 0TjmSaJ0QDxHwSaQMTz0/I03VsYupX2JpKIJaxwXOjS22DLQQPY2UaMVlL2DtL/m4NnR nHVimsjgnDDTHtl7ghN+41KfpsxRYFoCjEcPBdzS03ioSJ55NDDAbq0L5U9RWlFtVa5Q rq3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793206436; x=1793811236; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jQ5eyf1zl1dztY8G8GNDjIbe5i6XtlGMZ8AEehh0sP8=; b=max25XnORNOA5qGDIRm/X701kjL03WtUUrtKtK3+6tI0RtVOGKL/lMM/BNLZGyb340 BXN1LdDN6SVRsx+F8bhP0zDKkAe1vi0KADMmrHIRb5Qbs13/n/usb/M2X+KUujlbq8RB 4nf8czIZ6z3YjQzgijUvyjSPill7i9Cl/4AAkLLchEPnKeQLaYFdSAYG43U3p+G7FSck O8/xunvA08xW7W0qpEEYU61Ri88Dmv3OWiz3aN8e0qVsx3kCtVaL2fc930IFCx9kAndP wc4oHQUIymo7IAk8kQYyklBIzsjJW/oaeILTUe6Wwg1OyzPpIfgvFmy2h9AIm+eRNvPz 6yqw== X-Forwarded-Encrypted: i=1; AKwUvByUFfjM09vIAlyL/TE3jaWqENpu9lh+vKXHx86p8stSAThflgOTsLxnuXtilKfPxdDud3ujsGRPFE6ycdE=@vger.kernel.org X-Gm-Message-State: AFq9FYIrHFdMe1ndXy6UORMNInMBCR+cQ21LXEZOObKkdJw9irzZdXfg wyL42+viJT0orpsGKkMuYSMgiUwu/hJgU4Xz9PlraJZxSM0SEPRYFMM1/plcrvYeFVA= X-Gm-Gg: AYBFou35RUdRqnuOMNZFWx+gHl53yV7XjyT9tzOq0HfuTyHDNmil8WWkTNNhQUtgJv3 EBZ9Qha2Um3xaOjW4V6OReoofBjjo3E+Ds/QBsCBJi3bTAiXs8XnZeIMslvsrlBAmFTkE99pr4h OZ8CrSa+YuunO+6WBJkqxd8AwyJMRk2oGomI2guSnCAlxxeHg4vVyWW3gh5PIc1+/fcX8tssaiF 8P52lalRXy7+N5Rcd7Z/8yoU4OsVenXMw6PVpeOXBgx3Bt/ui9mHnqQ6E1PyQKR9J7qGlPqkb9n e9Yx9cHjurVPJkxlqX5NvHopKBDfTDSU2iXq3z1RL4hM37kD5OjgGV7P4XGYfgl7LJy06Ypb1UE 07TDa8hBd3kgEaE7MVPoGfKrMLGEk6fbVhAQrc4nyqL+7nQ+VJeaqCsZljHUQhaa9CQmmqk7gzZ 1109pG/BlAUA40OSJ8h3yOWuhxISygO0TUrRLL2wRqw9hVgjQSjqedBgCJNYnQgEd0YGH0aOs/d XnRi/lEMslUNCh+1gBLDNMbL93XKktQZMI+SUXcyJCeMP5x27iSzs6l+0XtBG0gXbz5h9aFN5ip umjoQU1+qB/7UegELDTXPJ1P0LvaZc7prIzSWn6iRKWXiz5LjllJIUJ31lJjVxhRyKTipxKoNP9 rAW9y+AsSK6GheeXpLE0b/VgWy8qEBA== X-Received: by 2002:a05:6102:3e8d:b0:7cb:bb33:8412 with SMTP id ada2fe7eead31-7d03a5063b4mr1453208137.10.1793206435862; Wed, 28 Oct 2026 09:53:55 -0700 (PDT) Received: from google.com (16.49.199.35.bc.googleusercontent.com. [35.199.49.16]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-991259db2d3sm6495987241.6.2026.10.28.09.53.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 09:53:54 -0700 (PDT) Date: Wed, 28 Oct 2026 12:53:47 -0400 From: Pasha Tatashin To: "David Hildenbrand (Arm)" Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Qi Zheng , Shakeel Butt , Lorenzo Stoakes , Kairui Song , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Baoquan He , Baolin Wang , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Kees Cook , Peter Zijlstra , Jann Horn , Pedro Falcato , Hugh Dickins , Pasha Tatashin , Pratyush Yadav , "Matthew Wilcox (Oracle)" , Jan Kara , Zi Yan , Lance Yang , Rik van Riel , Harry Yoo , Alistair Popple , Nico Pache , Ryan Roberts , Dev Jain , Usama Arif , Kiryl Shutsemau , Matthew Brost , John Hubbard , Peter Xu , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Oscar Salvador , Minchan Kim , Muchun Song , Xu Xin , Chengming Zhou , Chris Li , Kemeng Shi , Nhat Pham , Youngjun Park , Gregory Price , Joshua Hahn , Rakie Kim , Ying Huang , Jason Gunthorpe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, stable@vger.kernel.org, Chris Mason Subject: Re: [PATCH 03/46] mm/memfd: check for real shmem inodes before accessing shmem state Message-ID: References: <20261027-fixes_core-v1-0-6f74bec9a5bb@kernel.org> <20261027-fixes_core-v1-3-6f74bec9a5bb@kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261027-fixes_core-v1-3-6f74bec9a5bb@kernel.org> On 10-27 00:17, David Hildenbrand (Arm) wrote: > shmem_file() only checks a file's backing mapping. That mapping can belong > to another file, as with a Coda file backed by a tmpfs container after > mmap(). It does not establish that file_inode(file) is a shmem inode. > > Seal handling and memfd preservation use this check before accessing > shmem inode state, so they can access an inode of the wrong type. > > Add file_inode_is_shmem() to check the inode's file operations in both > paths. This identifies regular shmem inodes, including those used by > memfds and ordinary tmpfs files, independently of wrapper file operations. > > Fixes: c49fcfcda8b5 ("mm/shmem: update file sealing comments and file checking") > Fixes: b3749f174d68 ("mm: memfd_luo: allow preserving memfd") > Cc: stable@vger.kernel.org > Reported-by: Chris Mason > Signed-off-by: David Hildenbrand (Arm) > --- > include/linux/shmem_fs.h | 6 ++++++ > mm/memfd.c | 8 +++++--- > mm/memfd_luo.c | 2 +- > mm/shmem.c | 5 +++++ > 4 files changed, 17 insertions(+), 4 deletions(-) > > diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h > index a7c7a96a7cbf9..2ceca7993e4f5 100644 > --- a/include/linux/shmem_fs.h > +++ b/include/linux/shmem_fs.h > @@ -117,8 +117,14 @@ extern unsigned long shmem_get_unmapped_area(struct file *, unsigned long addr, > unsigned long len, unsigned long pgoff, unsigned long flags); > extern int shmem_lock(struct file *file, int lock, struct ucounts *ucounts); > #ifdef CONFIG_SHMEM > +bool file_inode_is_shmem(const struct inode *inode); > bool shmem_mapping(const struct address_space *mapping); > #else > +static inline bool file_inode_is_shmem(const struct inode *inode) > +{ > + return false; > +} > + > static inline bool shmem_mapping(const struct address_space *mapping) > { > return false; > diff --git a/mm/memfd.c b/mm/memfd.c > index 0f6fff004f5e4..7d2da23157003 100644 > --- a/mm/memfd.c > +++ b/mm/memfd.c > @@ -211,12 +211,14 @@ static int memfd_wait_for_pins(struct address_space *mapping) > > static unsigned int *memfd_file_seals_ptr(struct file *file) > { > - if (shmem_file(file)) > - return &SHMEM_I(file_inode(file))->seals; > + struct inode *inode = file_inode(file); > + > + if (file_inode_is_shmem(inode)) > + return &SHMEM_I(inode)->seals; > > #ifdef CONFIG_HUGETLBFS > if (is_file_hugepages(file)) > - return &HUGETLBFS_I(file_inode(file))->seals; > + return &HUGETLBFS_I(inode)->seals; > #endif > > return NULL; > diff --git a/mm/memfd_luo.c b/mm/memfd_luo.c > index 59de210bee5f9..c0811407ce397 100644 > --- a/mm/memfd_luo.c > +++ b/mm/memfd_luo.c > @@ -582,7 +582,7 @@ static bool memfd_luo_can_preserve(struct liveupdate_file_handler *handler, > { > struct inode *inode = file_inode(file); > > - return shmem_file(file) && !inode->i_nlink; > + return file_inode_is_shmem(inode) && !inode->i_nlink; > } Yeah, file_ is not needed, otherwise: Reviewed-by: Pasha Tatashin > > static unsigned long memfd_luo_get_id(struct file *file) > diff --git a/mm/shmem.c b/mm/shmem.c > index fadf23f9e21ed..0d41aac125df9 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -275,6 +275,11 @@ static const struct vm_operations_struct shmem_vm_ops; > static const struct vm_operations_struct shmem_anon_vm_ops; > static struct file_system_type shmem_fs_type; > > +bool file_inode_is_shmem(const struct inode *inode) > +{ > + return inode->i_fop == &shmem_file_operations; > +} > + > bool shmem_mapping(const struct address_space *mapping) > { > return mapping->a_ops == &shmem_aops; > > -- > 2.43.0 >