From: Andi Shyti <andi.shyti@kernel.org>
To: Tang Bin <tangbin@cmss.chinamobile.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: hix5hd2: check clk_prepare_enable in runtime resume
Date: Wed, 28 Oct 2026 17:54:50 +0100 [thread overview]
Message-ID: <auIospeKKEECNiaf@zenone.zhora.eu> (raw)
In-Reply-To: <20261026112608.2767-1-tangbin@cmss.chinamobile.com>
Hi Tang,
On Mon, Oct 26, 2026 at 07:26:08PM +0800, Tang Bin wrote:
> hix5hd2_i2c_runtime_resume() ignored the return value of
> clk_prepare_enable(priv->clk), then ran hix5hd2_i2c_init() (register
> access) and returned 0. On clock enable failure the hardware is accessed
> with the clock disabled (bus hang) and the matching runtime_suspend()
> clk_disable_unprepare() unbalances the clock count. Propagate the error.
>
> Fixes: 9242e72aaea0 ("i2c: use dev_get_drvdata() to get private data in suspend/resume hooks")
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
pushed to i2c/i2c.
Please next time send these patches in a single series.
BTW, for both I removed the Fixes tag as I don't think they are
necessary.
Andi
prev parent reply other threads:[~2026-10-28 16:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 11:26 Tang Bin
2026-10-28 16:54 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auIospeKKEECNiaf@zenone.zhora.eu \
--to=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangbin@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®