From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Jiale Yao <yaojiale02@163.com>
Cc: "Łukasz Bartosik" <ukaszb@chromium.org>,
"Andrei Kuchynski" <akuchynski@chromium.org>,
"Jameson Thies" <jthies@google.com>,
"Benson Leung" <bleung@chromium.org>,
"Enric Balletbo i Serra" <eballetbo@kernel.org>,
"Prashant Malani" <pmalani@chromium.org>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] platform/chrome: cros_usbpd_notify: check ACPI companion
Date: Thu, 29 Oct 2026 03:19:47 +0000 [thread overview]
Message-ID: <auK7U9gFbAYq19Mf@google.com> (raw)
In-Reply-To: <20261028051200.145621-3-yaojiale02@163.com>
On Wed, Oct 28, 2026 at 01:12:00PM +0800, Jiale Yao wrote:
> The ACPI probe installs a notification handler through the device ACPI
> companion without checking that the companion exists. A force-bound
> platform device can therefore cause a NULL pointer dereference.
>
> Return -ENODEV before allocating probe resources when the companion is
> missing.
>
> Fixes: 7e91e1ac60bb ("platform/chrome: cros_usbpd_notify: Amend ACPI driver to plat")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jiale Yao <yaojiale02@163.com>
I'll queue this after -rc1 comes out.
next prev parent reply other threads:[~2026-10-29 3:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 5:11 [PATCH 0/2] platform/chrome: check ACPI companions before use Jiale Yao
2026-10-28 5:11 ` [PATCH 1/2] platform/chrome: cros_ec_uart: check ACPI companion " Jiale Yao
2026-10-29 3:20 ` Tzung-Bi Shih
2026-10-28 5:12 ` [PATCH 2/2] platform/chrome: cros_usbpd_notify: check ACPI companion Jiale Yao
2026-10-29 3:19 ` Tzung-Bi Shih [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-10-28 5:10 Jiale Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auK7U9gFbAYq19Mf@google.com \
--to=tzungbi@kernel.org \
--cc=akuchynski@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=eballetbo@kernel.org \
--cc=jthies@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=stable@vger.kernel.org \
--cc=ukaszb@chromium.org \
--cc=yaojiale02@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®