From: Andi Shyti <andi.shyti@kernel.org>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: yaolu@kylinos.cn, jani.nikula@linux.intel.com,
rodrigo.vivi@intel.com, tursulin@ursulin.net, simona@ffwll.ch,
chris@chris-wilson.co.uk, lionel.g.landwerlin@intel.com,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915/gem: Reset err for each fence entry
Date: Thu, 29 Oct 2026 09:36:05 +0100 [thread overview]
Message-ID: <auMDxbKZ-XmRbaUH@zenone.zhora.eu> (raw)
In-Reply-To: <179325911095.16507.8295053984620715316@jlahtine-mobl>
Hi Joonas,
On Thu, Oct 29, 2026 at 09:31:50AM +0200, Joonas Lahtinen wrote:
> Quoting Andi Shyti (2026-10-28 13:39:14)
> > Hi Lu,
> >
> > On Tue, Oct 27, 2026 at 03:28:32PM +0800, yaolu@kylinos.cn wrote:
> > > From: Lu Yao <yaolu@kylinos.cn>
> > >
> > > If dma_fence_chain_find_seqno() failed once, 'err' will store val in
> > > the following loop. May causing returns '-EINVAL' even though that
> > > entry never called dma_fence_chain_find_seqno() at all.
> > >
> > > Fixes: 13149e8bafc4 ("drm/i915: add syncobj timeline support")
> > > Signed-off-by: Lu Yao <yaolu@kylinos.cn>
> >
> > pushed to drm-intel-gt-next.
>
> This was pushed without any R-b, DIM should have given you a warning
> when applying the patch.
I forgot to add it, or rather, I remembered it too late. Since
it's a simple and straightforward patch (most likely LLM
generated), I didn't want to make a fuss about it.
> I've reverted it for now, please use DIM and check the warnings before
> merging stuff.
I used dim and apparently dim is not enforcing it.
I'll push it again with my r-b.
Thanks,
Andi
next prev parent reply other threads:[~2026-10-29 8:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 7:28 yaolu
2026-10-28 11:39 ` Andi Shyti
2026-10-29 7:31 ` Joonas Lahtinen
2026-10-29 8:36 ` Andi Shyti [this message]
2026-10-29 8:52 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auMDxbKZ-XmRbaUH@zenone.zhora.eu \
--to=andi.shyti@kernel.org \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lionel.g.landwerlin@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
--cc=yaolu@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®