From: Chang Yu <marcus.yu.56@gmail.com>
To: "Jose A. Perez de Azpillaga" <azpijr@gmail.com>
Cc: "Chang Yu" <marcus.yu.56@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Joshua Crofts" <joshua.crofts1@gmail.com>,
"Shi Hao" <i.shihao.999@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Andy Shevchenko" <andriy.shevchenko@intel.com>
Subject: Re: [PATCH v7 2/2] iio: light: add AS7343 multi-spectral sensor driver
Date: Fri, 30 Oct 2026 00:38:39 +0800 [thread overview]
Message-ID: <auN2jwQVr-GSnZvF@zephyrus-g14.localdomain> (raw)
In-Reply-To: <533bca43-8de5-4295-b226-5ea3742871de@gmail.com>
On Thu, Oct 29, 2026 at 12:20:24PM +0100, Jose A. Perez de Azpillaga wrote:
> On 10/29/26 8:48 AM, Chang Yu wrote:
> > Add a driver for the AMS AS7343 14-channel multi-spectral sensor.
> >
> > The AS7343 is a 14-channel spectral sensor featuring 11 visible
> > channels, 1 near-infrared channel, 1 clear channel (VIS), and 1
> > flicker detection channel.
> >
> > The driver exposes 12 spectral channels (11 visible light and 1
> > near-infrared) via sysfs. Runtime PM is implemented to stop
> > measurements and enter SLEEP state when the device is suspended
> > or torn down.
> >
> > Future patches will add configurable gain and integration time,
> > interrupt support, buffered reads, VIS channel, and flicker
> > detection.
> >
> > Datasheet: https://look.ams-osram.com/m/5f2d27fff9a874d2/original/AS7343-14-Channel-Multi-Spectral-Sensor.pdf
> > Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> > Signed-off-by: Chang Yu <marcus.yu.56@gmail.com>
>
>
> [snip]
>
> > + /* Check for digital saturation. */
> > + if (status & AS7343_ASTATUS_ASAT_STATUS) {
> > + /*
> > + * Per the datasheet, ASTATUS is self-clearing: writing
> > + * the value back clears the entire register.
> > + */
> > + ret = regmap_write(map, AS7343_ASTATUS_REG, status);
>
>
> isn't that the STATUS (0x93) text? the datasheet says ASTATUS is read
> only and ASAT_STATUS clears on access, so the write shouldn't be needed.
> it also covers analog saturation, not only digital
>
Aw man, how did I not notice that?
> > + return ret ? ret : -EIO;
>
> -EIO reads like a bus error. as73211 returns -EOVERFLOW for this,
> wouldn't that fit better?
Sounds good to me. Jonathan, if v7 goes in, can you replace this if
block with:
/* Check for saturation. */
if (status & AS7343_ASTATUS_ASAT_STATUS)
return -EOVERFLOW;
I've tested the change on hardware and everything works fine. Or do you
prefer me sending over a v8 instead?
next prev parent reply other threads:[~2026-10-29 16:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 7:48 [PATCH v7 0/2] Add support for AS7343 multi-spectral sensor Chang Yu
2026-10-29 7:48 ` [PATCH v7 1/2] dt-bindings: iio: light: add as7343 Chang Yu
2026-10-29 10:52 ` Jose A. Perez de Azpillaga
2026-10-29 7:48 ` [PATCH v7 2/2] iio: light: add AS7343 multi-spectral sensor driver Chang Yu
2026-10-29 11:20 ` Jose A. Perez de Azpillaga
2026-10-29 16:38 ` Chang Yu [this message]
2026-10-29 20:59 ` Jose A. Perez de Azpillaga
2026-11-01 1:45 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auN2jwQVr-GSnZvF@zephyrus-g14.localdomain \
--to=marcus.yu.56@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=azpijr@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=i.shihao.999@gmail.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®