Re: [PATCH v4 0/5] media: atomisp: remove the circbuf library

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Tue, Oct 27, 2026 at 11:08:02PM +0000, Rareș-Mihai Vladu wrote:
> Thanks to Andy for suggesting, in review of my earlier typedef
> patch [1], that I look at converting the custom circbuf code to
> circ_buf or kfifo, and for reviewing the previous versions.
> 
> While looking into it, I found that the circbuf API is only used by
> the local queue path, and ia_css_queue_local_init() has no callers,
> so as far as I can tell that path is unused. The remote queues only
> need the descriptor and element layout shared with the SP firmware
> and a few small helpers.
> 
> So this series first moves the remote queue handling into helpers,
> then removes the unused local path together with the queue type that
> no longer seems to serve a purpose, moves the few remaining pieces
> into ia_css_queue_comm.h and drops base/circbuf/.
> 
> checkpatch warns about new typedefs in patch 4 and about MAINTAINERS
> in patch 5. The typedefs are only moved from ia_css_circbuf_comm.h,
> which patch 5 deletes, and MAINTAINERS has no entries for the removed
> files.
> 
> Compile-tested only.
> 
> This supersedes the typedef patch [1].

Thanks!

Sakari, can you apply this, so we have reduced code base (by 1%,
which is significant in this case) to think of?

FWIW, output of `cloc`

$ cloc -- drivers/staging/media/atomisp/
     605 text files.
     602 unique files.
       3 files ignored.

github.com/AlDanial/cloc v 2.04  T=0.21 s (2828.8 files/s, 456544.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C                              144           8850           6077          46523
C/C++ Header                   455           5355          10852          19150
make                             2              7             16            286
Text                             1              8              0             35
-------------------------------------------------------------------------------
SUM:                           602          14220          16945          65994
-------------------------------------------------------------------------------

-- 
With Best Regards,
Andy Shevchenko