From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Vidhu Sarwal <vidhu.linux@gmail.com>
Cc: "Joshua Crofts" <joshua.crofts1@gmail.com>,
"Vidhu Sarwal via B4 Relay"
<devnull+vidhu.linux.gmail.com@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org,
"Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: [PATCH 3/3] iio: proximity: Add Benewake TF-Luna LiDAR driver
Date: Thu, 29 Oct 2026 15:50:26 +0200 [thread overview]
Message-ID: <auNPIsQ4pDMb8qPc@ashevche-desk.local> (raw)
In-Reply-To: <CAFqz8L+fCc19aaUhs6k0a47y=oxhiM9PSgjMgjY0JYH8HN5wKA@mail.gmail.com>
On Thu, Oct 29, 2026 at 07:49:15AM +0530, Vidhu Sarwal wrote:
> On Tue, Oct 20, 2026 at 10:42:51AM +0300, Andy Shevchenko wrote:
...
> > > > +static const struct regmap_config tf_luna_regmap_config = {
> > > > + .reg_bits = 8,
> > > > + .val_bits = 8,
> > > > + .max_register = TF_LUNA_REG_SIGNATURE + 3,
> >
> > No cache?
>
> The only configuration register the driver writes to is MODE, once
> during probe. The other write is only a one shot trigger, and the
> registers read afterwards contain measurement data that keeps
> changing. also need to read MODE back from hardware since the sensor
> can silently ignore writes that come too quickly. I was planning to
> add caching later along with runtime PM to restore MODE , but I can
> add it in v2 if you think its better added now.
Just add a comment summarizing what you just said.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-29 13:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 18:33 [PATCH 0/3] " Vidhu Sarwal via B4 Relay
2026-10-19 18:33 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Benewake Vidhu Sarwal via B4 Relay
2026-10-20 8:35 ` Krzysztof Kozlowski
2026-10-19 18:33 ` [PATCH 2/3] dt-bindings: iio: proximity: Add Benewake TF-Luna Vidhu Sarwal via B4 Relay
2026-10-20 8:38 ` Krzysztof Kozlowski
2026-10-29 2:22 ` Vidhu Sarwal
2026-10-19 18:33 ` [PATCH 3/3] iio: proximity: Add Benewake TF-Luna LiDAR driver Vidhu Sarwal via B4 Relay
2026-10-20 7:23 ` Joshua Crofts
2026-10-20 7:42 ` Andy Shevchenko
2026-10-29 2:19 ` Vidhu Sarwal
2026-10-29 13:50 ` Andy Shevchenko [this message]
2026-10-20 8:10 ` Andy Shevchenko
2026-10-26 2:53 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auNPIsQ4pDMb8qPc@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=devnull+vidhu.linux.gmail.com@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vidhu.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®