mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: dri-devel@lists.freedesktop.org, michael@amarulasolutions.com,
	 linux-amarula@amarulasolutions.com,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	 David Airlie <airlied@gmail.com>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	 Jonas Karlman <jonas@kwiboo.se>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	 Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	 Maxime Ripard <mripard@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	 Robert Foss <rfoss@kernel.org>, Simona Vetter <simona@ffwll.ch>,
	 Thomas Zimmermann <tzimmermann@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: fsl-ldb: return -EPROBE_DEFER if the panel bridge is not found
Date: Thu, 29 Oct 2026 17:01:42 +0200	[thread overview]
Message-ID: <auNeWE0QyjtZtOH7@vm> (raw)
In-Reply-To: <20261029144132.572020-1-dario.binacchi@amarulasolutions.com>

Hi Dario,

On Thu, Oct 29, 2026 at 03:41:28PM +0100, Dario Binacchi wrote:
> of_drm_find_and_get_bridge() returns NULL if the panel has not been
> registered yet. Returning -ENODEV in this case makes the probe fail
> instead of being retried, so the LDB is never bound and the display
> pipeline never comes up:
> 
>   platform 32e90000.display-controller: deferred probe pending: imx-lcdif: Failed to get bridge for endpoint0
> 
> Return -EPROBE_DEFER, so that the probe is retried once the panel is
> available.
> 
> Fixes: 802372cf316a ("drm/bridge: fsl-ldb: don't create a panel_bridge")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 
> ---
> 
>  drivers/gpu/drm/bridge/fsl-ldb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c
> index 7ec84c81cd78..420b3e08130e 100644
> --- a/drivers/gpu/drm/bridge/fsl-ldb.c
> +++ b/drivers/gpu/drm/bridge/fsl-ldb.c
> @@ -342,7 +342,7 @@ static int fsl_ldb_probe(struct platform_device *pdev)
>  	fsl_ldb->bridge.next_bridge = of_drm_find_and_get_bridge(panel_node);
>  	of_node_put(panel_node);
>  	if (!fsl_ldb->bridge.next_bridge)
> -		return -ENODEV;
> +		return -EPROBE_DEFER;

Hmm, I have a patch [1] in the DCIF series that adds support for non-panel
bridges to fsl-ldb.c which, indirectly, should fix this as well. But, since I
don't see that patchset merged anytime soon:

Reviewed-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>

[1] https://lore.kernel.org/dri-devel/20261006-dcif-upstreaming-v10-2-bcfb28de0aae@oss.nxp.com/

-- 
Thanks,
Laurentiu

  reply	other threads:[~2026-10-29 15:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 14:41 Dario Binacchi
2026-10-29 15:01 ` Laurentiu Palcu [this message]
2026-10-29 19:30 ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auNeWE0QyjtZtOH7@vm \
    --to=laurentiu.palcu@oss.nxp.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=michael@amarulasolutions.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®