From: Oleg Nesterov <oleg@redhat.com>
To: Joe Perches <joe@perches.com>, Sasha Levin <sashal@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] get_maintainer: lazy load JSON::PP only when --json is used
Date: Fri, 30 Oct 2026 16:43:48 +0100 [thread overview]
Message-ID: <auS7NOsyw7pJ7rbF@redhat.com> (raw)
After commit 09d8b39563e8 ("get_maintainer: add --json output mode"),
I can no longer use get_maintainer.pl; it fails at compile time if
JSON::PP is not installed even when --json is not requested.
This module is only needed with the --json option. Use "require" to
load this module dynamically inside the "if ($json)" block instead.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
scripts/get_maintainer.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 16b80a700d4a..8239c8ca0fce 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -21,7 +21,6 @@ use Cwd;
use File::Find;
use File::Spec::Functions;
use open qw(:std :encoding(UTF-8));
-use JSON::PP;
my $cur_path = fastgetcwd() . '/';
my $lk_path = "./";
@@ -685,6 +684,7 @@ if ($json) {
$result{web} = \@web if ($web);
$result{bug} = \@bug if ($bug);
+ require JSON::PP;
my $json_encoder = JSON::PP->new->canonical->utf8;
print($json_encoder->encode(\%result) . "\n");
} else {
--
2.55.0
next reply other threads:[~2026-10-30 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 15:43 Oleg Nesterov [this message]
2026-10-30 16:07 ` Joe Perches
2026-10-30 16:17 ` Oleg Nesterov
2026-10-30 16:32 ` Joe Perches
2026-10-30 16:29 ` [PATCH v2] " Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auS7NOsyw7pJ7rbF@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®