mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Drew Fustini <fustini@kernel.org>
To: Yao Zi <me@ziyao.cc>
Cc: Han Gao <gaohan@iscas.ac.cn>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Jisheng Zhang <jszhang@kernel.org>, Guo Ren <guoren@kernel.org>,
	Fu Wei <wefu@redhat.com>, Han Gao <rabenda.cn@gmail.com>,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] riscv: dts: thead: add Milk-V Meles
Date: Fri, 30 Oct 2026 10:03:04 -0700	[thread overview]
Message-ID: <auTNyLqjBVgt2enA@thelio> (raw)
In-Reply-To: <asbBtj3fL0PUNGJ-@pie>

On Wed, Oct 07, 2026 at 10:03:34PM +0000, Yao Zi wrote:
> On Thu, Oct 01, 2026 at 03:44:11PM +0800, Han Gao wrote:
> > Add the Milk-V Meles board with UART0, eMMC, SD, Ethernet and the PWM2
> > fan. Describe the board pin assignments and the PHY on the GMAC0 MDIO
> > bus. Give GPIO banks aliases and name the exposed 40-pin header lines.
> > 
> > The eMMC I/O supply is fixed at 1.8 V. Enable DDR52 at that voltage and
> > retain the 52 MHz board limit. Describe 8 GiB as the default memory
> > size; firmware updates it to match the detected RAM capacity.
> > 
> > Reviewed-by: Drew Fustini <fustini@kernel.org>
> > Signed-off-by: Han Gao <gaohan@iscas.ac.cn>
> > ---
> >  arch/riscv/boot/dts/thead/Makefile               |   1 +
> >  arch/riscv/boot/dts/thead/th1520-milkv-meles.dts | 227 +++++++++++++++++++++++
> >  2 files changed, 228 insertions(+)
> > 
> > diff --git a/arch/riscv/boot/dts/thead/Makefile b/arch/riscv/boot/dts/thead/Makefile
> > index b55a17127c2bc06cbfb06d5f7c92dc7296e98437..25f7fe068368c97df2490bedc3eae70276a2e442 100644
> > --- a/arch/riscv/boot/dts/thead/Makefile
> > +++ b/arch/riscv/boot/dts/thead/Makefile
> > @@ -1,2 +1,3 @@
> >  # SPDX-License-Identifier: GPL-2.0
> >  dtb-$(CONFIG_ARCH_THEAD) += th1520-lichee-pi-4a.dtb th1520-beaglev-ahead.dtb
> > +dtb-$(CONFIG_ARCH_THEAD) += th1520-milkv-meles.dtb
> > diff --git a/arch/riscv/boot/dts/thead/th1520-milkv-meles.dts b/arch/riscv/boot/dts/thead/th1520-milkv-meles.dts
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..3714047190789bfccd8ff6810342d7ff865e74e4
> > --- /dev/null
> > +++ b/arch/riscv/boot/dts/thead/th1520-milkv-meles.dts
> > @@ -0,0 +1,227 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +/*
> > + * Copyright (C) 2021-2022 Alibaba Group Holding Limited.
> > + * Copyright (C) 2026 Han Gao <gaohan@iscas.ac.cn>
> > + */
> 
> ...
> 
> > +&emmc {
> > +	bus-width = <8>;
> > +	max-frequency = <52000000>;
> > +	cap-mmc-highspeed;
> > +	mmc-ddr-1_8v;
> > +	non-removable;
> > +	no-sdio;
> > +	no-sd;
> > +
> > +	status = "okay";
> > +};
> 
> Could you please explain the 52MHz limitation? This doesn't match what
> I saw at RevyOS' downstream kernel, which seems the only distribution
> supported by Milk-V officially.
> 
> Regards,
> Yao Zi
> 
> [1]: https://github.com/revyos/th1520-linux-kernel/blob/a092d55649279e1c9bcda2769b8f6b4370fa2c94/arch/riscv/boot/dts/thead/th1520-milkv-meles.dts#L1012-L1023

Sorry about not following up on this sooner.

Han Gao - could you explain what the motivation was for 52MHz?

Thanks,
Drew

  reply	other threads:[~2026-10-30 17:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01  7:44 [PATCH v2 0/4] riscv: dts: thead: Add Milk-V Meles support Han Gao
2026-10-01  7:44 ` [PATCH v2 1/4] dt-bindings: riscv: thead: add Milk-V Meles Han Gao
2026-10-01 19:05   ` Conor Dooley
2026-10-01 19:34   ` Drew Fustini
2026-10-01  7:44 ` [PATCH v2 2/4] riscv: dts: " Han Gao
2026-10-07 22:03   ` Yao Zi
2026-10-30 17:03     ` Drew Fustini [this message]
2026-10-01  7:44 ` [PATCH v2 3/4] riscv: dts: thead: enable AP6256 Wi-Fi on " Han Gao
2026-10-01  7:44 ` [PATCH v2 4/4] riscv: dts: thead: enable HDMI " Han Gao
2026-10-08  7:05 ` [PATCH v2 0/4] riscv: dts: thead: Add Milk-V Meles support Guo Ren
2026-10-12 23:32 ` Drew Fustini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auTNyLqjBVgt2enA@thelio \
    --to=fustini@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gaohan@iscas.ac.cn \
    --cc=guoren@kernel.org \
    --cc=jszhang@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=me@ziyao.cc \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=rabenda.cn@gmail.com \
    --cc=robh@kernel.org \
    --cc=wefu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®