From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Marius.Cristea@microchip.com
Cc: tristmd@gmail.com, jic23@kernel.org, tristan@talencesecurity.com,
nuno.sa@analog.com, dlechner@baylibre.com,
linux-iio@vger.kernel.org, andy@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] iio: adc: pac1934: validate ACPI _DSM return type and bounds
Date: Sat, 31 Oct 2026 16:43:30 +0200 [thread overview]
Message-ID: <auX-km8yi02_me95@ashevche-desk.local> (raw)
In-Reply-To: <6eb7177ec4730be9307a3f4d29a53a952a7f7bbd.camel@microchip.com>
On Fri, Oct 30, 2026 at 04:32:51PM +0000, Marius.Cristea@microchip.com wrote:
> On Fri, 2026-10-30 at 12:35 +0000, Tristan Madani wrote:
> Reviewed-by: Marius Cristea <marius.cristea@microchip.com>
Thanks for the review, but we don't allow min_t() without very good
justifications. This code doesn't need that macro to be used. The author
of the code should first get a bit familiar with types and integer
promotions in C programming language to understand what's going on here.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-31 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 12:35 Tristan Madani
2026-10-30 16:32 ` Marius.Cristea
2026-10-31 14:43 ` Andy Shevchenko [this message]
2026-10-31 14:41 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auX-km8yi02_me95@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Marius.Cristea@microchip.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=tristan@talencesecurity.com \
--cc=tristmd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®