From: Karl Mehltretter <kmehltretter@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrey Konovalov <andreyknvl@gmail.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Marco Elver <elver@google.com>,
Bradley Morgan <brads@mainlining.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
Thomas Gleixner <tglx@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Clark Williams <clrkwllms@kernel.org>,
linux-rt-devel@lists.linux.dev, kasan-dev@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/6] sched/core: Pause KCOV in __schedule()
Date: Sat, 31 Oct 2026 14:09:42 +0100 [thread overview]
Message-ID: <auXoWFzEuirP2IuC@gmail.com> (raw)
In-Reply-To: <20261030142354.bbc5e7f26fbfb6a8eee21290@linux-foundation.org>
On Fri, Oct 30, 2026 at 02:23:54PM +0100, Andrew Morton wrote:
> __attribute__((no_instrument_function))
> __attribute__((__always_inline__))
> class_kcov_pause_t class_kcov_pause_constructor(void)
> {
> class_kcov_pause_t _t = { .lock = (void*)1 },
> *_T __attribute__((__unused__)) = &_t;
> _T->paused = __kcov_pause();
> return _t;
> }
>
> Adding all this goop to core scheduler functions on non-KCOV kernels
> won't be terribly popular!
>
> A bit of macro magic can trivially make all this go away for non-KCOV
> kernels. The overhead is probably acceptable with CONFIG_KCOV=y
> kernels - seems it's only enabled for debug/research/fuzzing kernels.
>
> Ditto the hrtimer change. Aim to make these patches produce no change
> in generated code with CONFIG_KCOV=n.
>
Good point. Leaving the guard outside #ifdef CONFIG_KCOV was an
oversight in v2. I will fix this and the hrtimer wrapper in v5.
Thanks,
Karl
next prev parent reply other threads:[~2026-10-31 13:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 18:57 [PATCH v4 0/6] kcov: Keep timer and scheduler noise out of task coverage Karl Mehltretter
2026-10-05 18:57 ` [PATCH v4 1/6] kcov: Use unsigned int for kcov_start() mode parameter Karl Mehltretter
2026-10-05 18:57 ` [PATCH v4 2/6] kcov: Add a kcov_pause guard Karl Mehltretter
2026-10-05 18:58 ` [PATCH v4 3/6] hrtimer: Pause KCOV during deferred rearm Karl Mehltretter
2026-10-05 18:58 ` [PATCH v4 4/6] sched/core: Pause KCOV in __schedule() Karl Mehltretter
2026-10-30 21:23 ` Andrew Morton
2026-10-31 13:09 ` Karl Mehltretter [this message]
2026-10-05 18:58 ` [PATCH v4 5/6] sched/core: Pause KCOV in try_to_wake_up() Karl Mehltretter
2026-10-05 18:58 ` [PATCH v4 6/6] sched/core: Pause KCOV in wake_up_new_task() Karl Mehltretter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auXoWFzEuirP2IuC@gmail.com \
--to=kmehltretter@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=anna-maria@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=brads@mainlining.org \
--cc=bsegall@google.com \
--cc=clrkwllms@kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=frederic@kernel.org \
--cc=glider@google.com \
--cc=juri.lelli@redhat.com \
--cc=kasan-dev@googlegroups.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®