From: Gao Xiang <xiang@kernel.org>
To: daejun7.park@samsung.com
Cc: Gao Xiang <xiang@kernel.org>, Chao Yu <chao@kernel.org>,
Yue Hu <zbestahu@gmail.com>, Jingbo Xu <jefflexu@163.com>,
Sandeep Dhavale <dhavale@google.com>,
Hongbo Li <hongbohbli@tencent.com>,
Chunhai Guo <guochunhai@vivo.com>,
linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] erofs: apply the stacked fs check to extra file-backed devices
Date: Mon, 2 Nov 2026 13:01:59 +0100 [thread overview]
Message-ID: <auh7t-KdfKXhUAUY@XiangdeMacBook-Pro.local> (raw)
In-Reply-To: <20261030-erofs-stacked-extra-devices-v1-1-39f7df7ac01b@samsung.com>
On Fri, Oct 30, 2026 at 12:52:44PM +0900, Daejun Park via B4 Relay wrote:
> From: Daejun Park <daejun7.park@samsung.com>
>
> erofs_fc_fill_super() rejects a file-backed mount whose image is on a
> file-backed EROFS or on a filesystem with s_stack_depth set. This
> bounds the nesting of reads. Extra devices given by device= are not
> checked. File-backed mounts can still nest through them without limit.
>
> Apply the same check to extra devices.
>
> Fixes: fb176750266a ("erofs: add file-backed mount support")
> Signed-off-by: Daejun Park <daejun7.park@samsung.com>
Reviewed-by: Gao Xiang <xiang@kernel.org>
> ---
> Tested on erofs dev in a QEMU guest with KASAN and lockdep:
>
> - Blobs on a file-backed EROFS or overlayfs now get -EINVAL.
>
> - Blobs on XFS or a loop-mounted EROFS still mount and read back.
>
> - Lockdep warns about devs->rwsem vs i_rwsem for a device= path inside
> an EROFS mount, with or without this patch.
What does that mean? Can you explain more about this lockdep issue?
Thanks,
Gao Xiang
prev parent reply other threads:[~2026-11-02 12:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 3:52 Daejun Park via B4 Relay
2026-11-02 12:01 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auh7t-KdfKXhUAUY@XiangdeMacBook-Pro.local \
--to=xiang@kernel.org \
--cc=chao@kernel.org \
--cc=daejun7.park@samsung.com \
--cc=dhavale@google.com \
--cc=guochunhai@vivo.com \
--cc=hongbohbli@tencent.com \
--cc=jefflexu@163.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®