mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel West <daniel.west.dev@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org,
	elder@kernel.org, greybus-dev@lists.linaro.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: Add newlines to sysfs output
Date: Mon, 2 Nov 2026 11:45:12 -0500	[thread overview]
Message-ID: <aui-GOB6USw2ziOt@daniel-HP-Stream-Laptop-14> (raw)
In-Reply-To: <2026102808-stunning-headgear-4355@gregkh>

On Wed, Oct 28, 2026 at 05:19:45AM +0100, Greg KH wrote:
> On Tue, Oct 27, 2026 at 06:31:40PM -0400, Daniel West wrote:
> > >From 6376e59cb4d0fa2d57ff7f4fb2ce6cdb8bb1d03a Mon Sep 17 00:00:00 2001
> > From: Daniel West <daniel.west.dev@gmail.com>
> > Date: Tue, 27 Oct 2026 15:53:19 -0400
> > Subject: [PATCH] staging: greybus: Add newlines to sysfs output
> 
> This shouldn't be here in the body of the email, right?
> 
> > 
> > Add terminating newlines to the sysfs_emit attributes in the Greybus audio manager per warnings from checkpatch.
> 
> Didn't checkpatch warn you about too long of lines here?
> 
> > 
> > WARNING: return sysfs_emit(...) formats should include a terminating newline
> 
> Please read the archives for why this warning is ok to ignore here.
> 
> thanks,
> 
> greg k-h

Thank you very much for the contructive feedback. I have reviewed
the archives and it makes sense. I will drop the patch.

Thanks again,
Daniel W

      reply	other threads:[~2026-11-02 16:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27 22:31 Daniel West
2026-10-28  4:19 ` Greg KH
2026-11-02 16:45   ` Daniel West [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aui-GOB6USw2ziOt@daniel-HP-Stream-Laptop-14 \
    --to=daniel.west.dev@gmail.com \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mgreer@animalcreek.com \
    --cc=vaibhav.sr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®