From: Dan Carpenter <error27@gmail.com>
To: Adhyansh Verma <adhyanshverma2010@gmail.com>
Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com>,
Mark Greer <mgreer@animalcreek.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: audio: add newline to sysfs_emit() in show functions
Date: Mon, 2 Nov 2026 17:40:16 +0300 [thread overview]
Message-ID: <auig0PAuoPinb0Kl@stanley.mountain> (raw)
In-Reply-To: <20261102140438.103135-1-adhyanshverma2010@gmail.com>
On Mon, Nov 02, 2026 at 07:34:38PM +0530, Adhyansh Verma wrote:
> Per Documentation/filesystems/sysfs.rst and kernel conventions, sysfs
> show functions should terminate formatted attribute outputs with a
> newline character.
>
> Commit 14c91651df34 ("staging: greybus: audio: Use sysfs_emit in show
> functions") converted sprintf() to sysfs_emit(), but left out the
> trailing newlines. As a result, reading these attributes in userspace
> outputs values without a line break and checkpatch warns that
> sysfs_emit() formats should include a terminating newline.
>
> Add the terminating newline to each sysfs_emit() format string in
> audio_manager_module.c show callbacks.
>
> Fixes: 14c91651df34 ("staging: greybus: audio: Use sysfs_emit in show functions")
> Signed-off-by: Adhyansh Verma <adhyanshverma2010@gmail.com>
> ---
Check the archives (lore.kernel.org) for why we aren't merging this.
regards,
dan carpenter
prev parent reply other threads:[~2026-11-02 14:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 14:04 Adhyansh Verma
2026-11-02 14:40 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auig0PAuoPinb0Kl@stanley.mountain \
--to=error27@gmail.com \
--cc=adhyanshverma2010@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®