mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: daejun7.park@samsung.com
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Jens Axboe <axboe@kernel.dk>,
	Mike Christie <michael.christie@oracle.com>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] nvme: unregister when pr_register() is given a zero new key
Date: Mon, 2 Nov 2026 10:27:59 -0700	[thread overview]
Message-ID: <aujIH1Kw8Ex6kYlX@kbusch-mbp> (raw)
In-Reply-To: <20261029-nvme-pr-unreg-v1-1-b4657ad4e98e@samsung.com>

On Thu, Oct 29, 2026 at 09:51:24AM +0900, Daejun Park via B4 Relay wrote:
> From: Daejun Park <daejun7.park@samsung.com>
> 
> The block layer PR API defines a zero new_key in pr_register() as
> unregistering old_key. nvme_pr_register() sends Replace Reservation
> Key with a zero NRKEY instead. The host stays registered with key 0,
> and its next registration with another key fails with Reservation
> Conflict.
> 
> The pNFS SCSI layout client unregisters this way at umount. A later
> mount cannot register and sends all I/O through the metadata server.
> 
> Send Unregister Reservation Key when new_key is zero.

Thanks, applied to nvme-7.4.

      parent reply	other threads:[~2026-11-02 17:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29  0:51 Daejun Park via B4 Relay
2026-10-29 12:13 ` Christoph Hellwig
2026-11-02 17:27 ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aujIH1Kw8Ex6kYlX@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=daejun7.park@samsung.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=michael.christie@oracle.com \
    --cc=sagi@grimberg.me \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®