From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
Cc: Lee Jones <lee@kernel.org>, Chen-Yu Tsai <wens@kernel.org>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Zha Qipeng <qipeng.zha@intel.com>,
Qunqin Zhao <zhaoqunqin@loongson.cn>,
Thomas Richard <thomas.richard@bootlin.com>,
mfd@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH] mfd: Use named initializers for acpi_device_id
Date: Tue, 3 Nov 2026 12:28:20 +0200 [thread overview]
Message-ID: <aum3RLDLDa1gllge@ashevche-desk.local> (raw)
In-Reply-To: <20261102-acpi-mfd-v1-1-d61029971be8@thegoodpenguin.co.uk>
On Mon, Nov 02, 2026 at 12:25:14PM +0000, Pawel Zalewski wrote:
> Use a designated initializer for the acpi_device_id fields which makes the
> code more readable and consistent with how lists are initialized in the
> rest of the kernel code base. Also drop explicitly setting fields to 0
> where it is redundant.
>
> Unify the list terminator to have a single space between the brackets and
> no trailing comma.
Can you split Intel LPSS to a separate patch? It will help reviewing both parts.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-11-03 10:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 12:25 Pawel Zalewski
2026-11-02 14:26 ` Charles Keepax
2026-11-03 10:28 ` Andy Shevchenko [this message]
2026-11-03 11:01 ` Pawel Zalewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aum3RLDLDa1gllge@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=david.rhodes@cirrus.com \
--cc=lee@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=mika.westerberg@linux.intel.com \
--cc=patches@opensource.cirrus.com \
--cc=pzalewski@thegoodpenguin.co.uk \
--cc=qipeng.zha@intel.com \
--cc=rf@opensource.cirrus.com \
--cc=thomas.richard@bootlin.com \
--cc=wens@kernel.org \
--cc=zhaoqunqin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®