From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.45 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793688111; b=m9LFPyN3Ts8IcZ74DlymQpXHbBWV7JHDYrYqHX+DHuGIXmTftnxgmQtTyjc0mHeDAf+u yf1zikHIKhX2T24p80fmkUgAecdyCIgBUgW7ahAyVjeabSc8Xf1w3+2TQ+HAH86VEwCIR 11Vxu0It5iINBMXikbuYcZGFxju59KTafCQgw3YerMoPn2Bhvgh+xlrGs1msm1LSLfybE H3RGokomplyrYb6gjm11mgA4jvjp8eOU3Vcss7n3mtrQnlooWUdxqagHSFJHLbjmEDWbn 4lgx1VMmAhxmW4ErD74ejhpyz/jBexvutUWIrPJpfcClSBt6NHwp8x2HjcHceJvKqvA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793688111; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=XZbFiyKP41aFFQ9gy0xVXRe5kyE6xQOvIotkPQSuTqo=; b=uKUo4pOVVsSku+6zW3MgOz9fhgDiWV8DilGXc69r5R8APLriUQXJyYL1Sfa4D0Aj8WZN fgjEVBOHQtbsS7V08bebl4TK1z3goWUXEkZG1MgJ2URe7Nv74UyZHEu6KZ/H6IyBEMrvO 28GRCZaq3FrbkybQNRL3HVk59U8j8GGT7JCC4W7ZXBPDDz1w6iUz4ZkXvGPQiw9xv3uZo N+jNXyfxPHxDD7YhjjK8bhsXGRJjRK/Epb+bMNnnjuYl99deZ4l3VtKdewX/w7ip9DprW bjtLEnCTs4K9VzyNJ9vpFpA3Qif+KFaVUOw6nyeJYkr72LwYGE4+18tknWCApjIpbvw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=oluP6zyi; arc=none smtp.remote-ip=209.85.128.45 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71F6C606A330 for ; Tue, 3 Nov 2026 06:41:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 71F6C606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=oluP6zyi Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4ac95761c85so24195215e9.2 for ; Mon, 02 Nov 2026 22:41:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1793688109; x=1794292909; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=XZbFiyKP41aFFQ9gy0xVXRe5kyE6xQOvIotkPQSuTqo=; b=oluP6zyiXVY9kgI2Vf/ouNfKZtMzfELewZ1/UdCsAmA4IaIYYA9oFhy33tOcWN5jCh Mm1Ky/FhuxFAqUTNq5FU51Or/apgIuRHipx6NIzTFHTWsS6qmen0tffq21jUhZ183rux aFYASSvrM8X5eHcXGYTIJmskC95WgDrc90fOtVgTug/hfJLkmYp/q0A/Z5cdlpo5MtZP fq/CHGGYumh0QHxJx45J0TaZ01isaULs7dCdTn9fBjAxEvoWV/LwV6UYwdYqR0RLdRfc +kVKTESs1ocbnIVwJFH+oZMS1gd3U0PkyY92RFt8dyOzQFvlJ3bA2DPdPLVp/HCzT7km jB2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793688109; x=1794292909; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XZbFiyKP41aFFQ9gy0xVXRe5kyE6xQOvIotkPQSuTqo=; b=Q2cetGrPlk2hqopYyB1XgwkbamAUWhggHMzsh+j7M4yG8cXSeyodo0TOXPUF/rEXr6 utlsAebZEe1p+L3u4MTWVXcfXgGk7VORRJRNfCYPUMJ+VjQt3Ji6uhNf6u1IiioyEr9u kG/183lyFi8iJ29zGLo6h/hbS7wo5JwSGo5yQxtcvUdW4VNFnjQ2UJHu/VcIXTj+nrkB jYjnwe5P7wKAUqeE5AqAQfVOcYuSb3M8wMSFZelguQ9WTLA+LRPRkNRgePtAA6VkgyJk V8u4vIKnaduyeT4zE1c6Zh3++EGUbt0i2XSQjD4YYk2NJOMkEFlRkGOgojeQLa+jawXP hQSQ== X-Forwarded-Encrypted: i=1; AKwUvBz6J/aoQFf2VWqtZxvmEoJR+puk3Ve2JDxqGs2fzmLVND/lTw2ZFiEoYVcBvTWNYCSMQCchkS3GfYtf3pY=@vger.kernel.org X-Gm-Message-State: APuU4Z9QbaF8JJEnCxupO/Y4EagIkdZWJCi9XY37N1DJqw43mD0fDwKn 84nRJ/rttvJwaPWJCiQYB+Ius8pwZCchnCSpiSk/ELb5V4sPhZPxpLR9StX8WHWl2MU= X-Gm-Gg: AYBFou1+0qpbLMPi83qKTN2Y+dwZYhzWyYlMY/dG//Hfzw+MT/jAUn5rh54GY0eM3zG xFu3C6AeDHI1xo1O21FwweKn9G7t8dWhcRbYcN6ewoZLBwGKBBgdL5PEWcVECOgkE9UVwYSxxcB JSAK3OJonqCknddy1fuVelM/4lpZwLWK//q7MEAf1nzWeV2lHoVgT+vJztO5Kqa4iasqHp0/qD3 FakagRqpwuA1a5My0dnphG6U/0Bu5TqEaxO6+3h8p07pVFOTTLfvEQIIE3iZrEMcZ84Ew079fot tPJPPldWUodpaMJGuPa7Nm7icq9PXktzyXlmDSSt4jxFF/Kk3RAHZRPUA43JicrbpZOlaDVZrYQ dxy8oM5p6N+SVt9iDF6YnJHqk9yqaL4bayGGGdRRoLoMcy4S+1HNJ/+5NZQsnBAdGGDnlxhKPsE 6K1WkUGlVQdToLo+/uTa/oHuI8r3nUs8ufaQ/xbF0cL9Yc1CPdzPK+apyDy76TPh6TcMVIMVc46 qSO2jm6Ga6dhh/7JUVLjl6MZRj8oebEjZB25wovjvfwsVK9po2e0EltzljjA8Oe0tQNswhSB/+Y YajG3elvgKB5nJwXzZbcrQirPZ8LtrGaJQ== X-Received: by 2002:a05:600c:6211:b0:4a1:80d8:aed5 with SMTP id 5b1f17b1804b1-4ac17191046mr289485365e9.6.1793688108839; Mon, 02 Nov 2026 22:41:48 -0800 (PST) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4b2aae24b32sm33736825e9.12.2026.11.02.22.41.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 22:41:48 -0800 (PST) Date: Tue, 3 Nov 2026 07:41:46 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Arthur Kiyanovski Cc: David Arinzon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Simon Horman , Jonathan Corbet , Shuah Khan , Randy Dunlap , Guangshuo Li , Ioana Ciornei , Sang-Heon Jeon , Dawei Feng , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: ena: Fold header containing PCI id definitions into driver Message-ID: References: <20261102110907.356621-2-u.kleine-koenig@baylibre.com> <179365616498.28818.15452478866037209509.b4-review@b4> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fmbssy6xzbjtangh" Content-Disposition: inline In-Reply-To: <179365616498.28818.15452478866037209509.b4-review@b4> --fmbssy6xzbjtangh Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH net-next] net: ena: Fold header containing PCI id definitions into driver MIME-Version: 1.0 Hello Arthur, On Mon, Nov 02, 2026 at 09:49:24PM +0000, Arthur Kiyanovski wrote: > On Mon, 02 Nov 2026 12:09:05 +0100, Uwe Kleine-K=F6nig wrote: > > The file ena_pci_id_tbl.h is only included once. Fold it into its only > > consumer, simplifying a bit en passant. > >=20 > > Note that I took out the trailing comma from the expanded value of > > ENA_PCI_ID_TABLE_ENTRY() and thus these commas have to be added when the > > macro is used improving readability. > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig > > I'd prefer to keep ena_pci_id_tbl.h as a separate file - ena_netdev.c is > already by far the largest file in the driver, and I'd rather not grow it > further when there's an alternative. File size isn't a relevant metric for me, but I can live with it that it's one for you. > You're right about the missing definition though, and I think we can fix > that by adding #include to ena_pci_id_tbl.h instead. Would > that satisfy your check script? It would, the minimal header to achieve that is . I'd stick to that for v2. > The rest of the cleanup can be applied to the header instead: >=20 > - drop the #ifndef guards around the PCI_DEV_ID_ENA_* defines, nothing > defines those names anymore > - drop the PCI_VENDOR_ID_AMAZON fallback too, has had > it since 4.18 > - keep the trailing comma change, that's how the other drivers do it > (mlx4, e1000, cxgb4, qlcnic, ...) >=20 > Would you mind respinning along those lines? Will respin later today or tomorrow. Best regards Uwe --fmbssy6xzbjtangh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmrpgicACgkQj4D7WH0S /k4h4wf7BnWnpyFdy5t4kYuzGwH0D4hl5r6jwwVpNlRESO2NGcbD42sXBuT1L79v GSMzWDB7jllHfMen947CoYaPAb5N5svMpDw9TjY1MO8hiTnzwzBCvIjaSvI6+nfS SOTcbPkPoBLrdHlwk45oaFZ1CqCYYmud16tIkvA2G/Rrp+S9wQ6I1h0wZkWZ5ncC 37KbLYNcuhRRYQli/XCeIrQ6nKTF7f59q01bJdrMQWXrcHrNmMzYLxkxKFg3FREu jBYBvuX44fxKZHDGcH09Uy134k3yQ+I+JoXGh2v8ylG42xzQ27jGjq/UEXz0iISz uuuhFvyoIGTp5OBOsDhGMkb5UntSGQ== =I/JX -----END PGP SIGNATURE----- --fmbssy6xzbjtangh--