From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Arnav Kapoor" <kapoorarnav43@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Gwendal Grignou" <gwendal@chromium.org>,
"Joshua Crofts" <joshua.crofts1@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] iio: proximity: sx9310: keep the IRQ balanced across suspend and resume
Date: Tue, 3 Nov 2026 12:05:15 +0200 [thread overview]
Message-ID: <aumx29VuBAuKdGIJ@ashevche-desk.local> (raw)
In-Reply-To: <20261101015416.4b477c91@jic23-hlaptop>
On Sun, Nov 01, 2026 at 01:54:16AM +0000, Jonathan Cameron wrote:
> On Thu, 29 Oct 2026 03:34:37 +0530
> Arnav Kapoor <kapoorarnav43@gmail.com> wrote:
>
> > sx9310_suspend() disables the interrupt first and returns with it still
> > disabled if a register access fails. Resume isn't called after a failed
> > suspend, so the interrupt is never enabled again. sx9310_resume() also
> > returns without enabling it on error. Without an interrupt line,
> > client->irq is 0 and both callbacks act on IRQ 0, which the driver
> > doesn't own.
>
> irq 0 doesn't exist any more on any architectures I think..
> It did once, long ago. Today it means no interrupt.
...on the new architectures (?), on the old ones we have to live with it.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-11-03 10:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 22:04 [PATCH v3 0/3] iio: proximity: sx93xx: " Arnav Kapoor
2026-10-28 22:04 ` [PATCH v3 1/3] iio: proximity: sx9310: " Arnav Kapoor
2026-11-01 1:54 ` Jonathan Cameron
2026-11-03 10:05 ` Andy Shevchenko [this message]
2026-10-28 22:04 ` [PATCH v3 2/3] iio: proximity: sx9324: " Arnav Kapoor
2026-10-28 22:04 ` [PATCH v3 3/3] iio: proximity: sx9360: " Arnav Kapoor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aumx29VuBAuKdGIJ@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=kapoorarnav43@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®