From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.214.200 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793719026; b=qYymsqpw63ZwgavTicbml5/V2k8/qqfa6I3vRFevzDiKTnKlgDnnKwf09jN+VkeSp5A+ zDng5urHo2+j/ISnwX8+aMRscCemOCxhj6FXrwUpIBLqVzGgPR9d+3ctbhNdYSljk/c2B YhBsSCxN4SetPzLCkqruPSokl4H0D+YnFBChievdE/t4oXx+DvsWuhd/uAg5nkiJE+htr tOwEBzTyR/pUv1gaAhSNjFEASwSg1kJCdPIBCebEmOX1Ijf266vCEfrwe421Eb3gwd76w JysVhIeiRWbHhl+u40s/6bPMGEQO5jRbA9Fn2VR6dt2AdP1fY7kWs8/njHUg+wG7QXw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793719026; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:Message-ID:Subject:From:To:Cc:Content-Type: Content-Transfer-Encoding; bh=gZPyGNb7zpjaaj961jv5er4Nb77WoHldzauRxys7WyE=; b=XHu+W89eLDE+wGu26ZtsnxvK/ml62MVL2W23/7N9zDUiA7IQmgQ/MKF2M3q1nwYUServ Y9B8Q5nN7OEopKUydKCbRbtpvLCDYnsZYU6BGXctBQI7PZhisljvkWh0p67b6Kgdw5g3K 6XMruQXmdHnrqZjMmUQ2GbQccRQjsdi2o/QLUUwG3BY/nrkR6lGvwFZgwmET0asZai7My bPsBLEBTghfQj9v9jCIf6LgneRd96KxWH7GH3oKq3gRlvalepS3iuoJ/6Q5vp6eoE9Y3t l35Iasla0gZoxfkciK2v14emy49CH8Ae4VjFWRnQjQHqxR9sIKS8XO54vrvqh8u+Abg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=mW6b0k6t; arc=none smtp.remote-ip=209.85.214.200 Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA8A4606D2C6 for ; Tue, 3 Nov 2026 15:17:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DA8A4606D2C6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=mW6b0k6t Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2e9d52f684fso42299665ad.2 for ; Tue, 03 Nov 2026 07:17:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793719025; x=1794323825; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=gZPyGNb7zpjaaj961jv5er4Nb77WoHldzauRxys7WyE=; b=mW6b0k6tkcAmvwTsiyUyrFOG0yYgxbMyq/CyLo0GBeVGkS+weCWHMTorKB4Qjre1c7 PO0M2SjA5Sg21rXACBzADNYx3Q1wHocgyf2w1QU/jmNFDjP1hc9iHbstkkvCwf1DcJXX MGvGihb0mOoIGRo7aHflVO0L9IbYmO/JjAwc1i+h79nYEYcGZq70VG9ydwyjXGJjuHCb k3cTWif9RVMoLMyXIhBHMgEUoh0vm7o8L03BIUKfk9B7JKFdX/afmGGG4q2oFhEXOlbZ wipwtdfJNgS9uX7yUDZkedGmdCzauAaxEIAu8NXAb55FFTKLBaNv+5O74Tr5CB7ydWsW oq0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793719025; x=1794323825; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gZPyGNb7zpjaaj961jv5er4Nb77WoHldzauRxys7WyE=; b=L3CDcamPI99NUhNMBZKJMHtZKQ7UtY4ZzVYgmq/R7Kwiqfh+FeLWD4U/6DZ40W76o/ LapG6fR/rYXgB2iV+ErD+ZnUnAarvQF6jPo7KEmtzly/4zKWKis741CkP4DhoF3qH8mE 9wwB5rFmVU189HpPTN/a43kM+LQ/OxExoAbdCG3i1a+x344xe0vS8Dms15AKUmqyTkjh bbV3LEipQkvjqvHcszXAC15d4ifXQR2vGlwH902YpI9En26e/LGqu2g64Q9gwuiCemHF r0oieyli1kB0eDUupgyBBKKNo4hKBBycauJ3TqXH+DuGrDGrOv4nDg7EZ7DEJQlhqr/m dqXw== X-Forwarded-Encrypted: i=1; AKwUvBw1Vy+q4QveWn+LrxGszhuXqIUPYnWBeL+6l9UY6pYcy1nP8AplWTNjrsz3b9pQi3zFNJHWaxAy8izEGtc=@vger.kernel.org X-Gm-Message-State: APuU4Z8vrHZQgRjZvhWsORo4wfHPwgF8UlIKz60zQMVhhy7L8cuiCj+r oLuZFjbhCN86+piMwWlpbxAo8XGEpMkoJm4dYM6RS2MXT11tOw3c1+yEToRwjjMJ2C49LTEtCy1 /eJR3fA== X-Received: from plsr11.prod.google.com ([2002:a17:902:be0b:b0:2ea:d63d:f2c5]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:22c3:b0:2e5:334f:f47e with SMTP id d9443c01a7336-2eb36489c9bmr122626395ad.21.1793719024883; Tue, 03 Nov 2026 07:17:04 -0800 (PST) Date: Tue, 3 Nov 2026 07:17:04 -0800 In-Reply-To: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <6adf2939.67317f00.38c4bc.00ae.GAE@google.com> <20261026224305.1254-1-hdanton@sina.com> <20261027163929.2bb28d5b@gandalf.local.home> Message-ID: Subject: Re: [syzbot] [kvm?] WARNING: locking bug in __refill_objects_node From: Sean Christopherson To: Paolo Bonzini Cc: Steven Rostedt , Harry Yoo , Hillf Danton , Boqun Feng , syzbot , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Tetsuo Handa , syzkaller-bugs@googlegroups.com, Vlastimil Babka , Andrew Morton , Hao Li , Christoph Lameter , David Rientjes , Roman Gushchin , linux-mm@kvack.org, Sebastian Andrzej Siewior , Clark Williams , linux-rt-devel@lists.linux.dev Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Tue, Nov 03, 2026, Paolo Bonzini wrote: > On Mon, Nov 2, 2026 at 6:43=E2=80=AFPM Sean Christopherson wrote: > > > If so, we need to make that a thread for RT kernels if you want to ca= ll > > > kzalloc_obj(). > > > > Eww. I can't imagine there's a sane usecase for memory overcommitting = a real-time > > guest. >=20 > While I agree with the feeling, the dummy allocation path should be > mostly dead, because page fault should never (?) enable interrupts > before waiting: >=20 > #PF interrupt gate > exc_page_fault() > kvm_handle_async_pf() > __kvm_handle_async_pf() > irqentry_enter() > kvm_async_pf_task_wait_schedule() > kvm_async_pf_queue_task() <- registers waiter > prepare_to_swait_exclusive() > local_irq_enable() >=20 > The dummy allocation path is only reachable if it's an L1 hypervisor > that is getting an async page fault while L2 is running, because it > enables irq before the call to kvm_async_pf_task_wait_schedule(). I > think we can drop the dummy allocation for good, which would be even > better. +1, I completely forgot what this code is doing (although that implies I ev= er knew in the first place...). > Whether you would still want to disable APF for RT kernels is up to you. Nah, on second thought there are use cases for async #PF other than memory overcommit. Whether or not they coincide with PREEMPT_RT is debatable, but= I don't think it makes sense to go looking for trouble.