Re: [PATCH v5 7/7] gpiolib: let the character device free its IRQs first on chip removal

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Tue, Nov 03, 2026 at 12:26:34PM +0100, Herve Codina wrote:
> On Tue, 3 Nov 2026 12:52:10 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, Nov 03, 2026 at 12:32:40PM +0200, Adrian Ambrozewicz wrote:

...

> > > Link: https://lore.kernel.org/all/20240227113426.253232-1-herve.codina@bootlin.com/
> > 
> > No. Either make it Closes tag (if appropriate) or add a reference like
> > 
> > Link: $URL [1]
> > 
> > and mention [1] in the text, otherwise it makes Linus T. grumpy. I think
> > I already told that.
> > 
> 
> IHMO, "Link:" instead of "Closes:" according to this reply in the series
> pointed out [2].
> 
> [2]: https://lore.kernel.org/all/20240923150522.66b418d1@bootlin.com/
> 
> The history was:
>  - [1] (the link in this patch) proposed a fix
>  - It has been rejected and a improved one has been done [2]
>  - [2] has been accepted and led to the commit ec8b6f55b981 ("gpio: free irqs
>    that are still requested when the chip is being removed"). This commit
>    is already mentioned as 'Fixes:" in this patch.
> 
> So, IMHO, in this patch:
>   ...
>   takes (config_mutex, or a new mutex for v1 line events). Herve Codina
>   first proposed calling the notifier earlier [1].
>   ...
>   Link: https://lore.kernel.org/all/20240227113426.253232-1-herve.codina@bootlin.com/ [1]
>   Fixes: ec8b6f55b981 ("gpio: free irqs that are still requested when the chip is being removed")

Thanks, WFM!

-- 
With Best Regards,
Andy Shevchenko