From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=192.198.163.12 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793706831; b=nymArl/3s0KVYJ6MCNMxvbeJQu/3XNFheq8IpEh+JBPOe3VtZJo0H9ACsigX4c1oIXFv LT3HvC9A4Fwnef6A12AUVPFCmYZgWrCBiMQNay8pIlhDrB0x0dClAxub5RzUZJDHyUp58 UiG0c+HUXoML5wndfhieRXPZuNr57DC/4zHBuxAFDADAJIjLhXcPwY+MmeVAnGUX1nh11 jP+p+ISLKx150NwFF/Zn6WPhUAX/AHHFckHP6gK5+aAPdBfYg4V94UoAnLJJrDWctrOnC vPjiVijx1LR7ToyYZHcIcfaxfB6IGUm2bwwNhAkJEeUpym4EkF5kIBxbCtocAiHQrRQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793706831; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:Organization; bh=RllDWIKtBnZGWzJv6L6Y2irHmhyGV0d/oUU3v4XZDuQ=; b=hb3mLW7tqbwNrZm3+o22A0QuDiM08TozpPPsTobi/refbhX9rgBtXrqtp/NUxyMazOrF GBumdIyxipEqxM/TzUs+q2PtdaLrteYrUxalfdamqiBiRIGC/MNLqWqiYL12pz8KeE+hc Tff+Wv8RhJPu56BQ/0Vdo8aw095NSr3bxqo1yCUZWZR9AYe5kRD8fYCThVT5mz9VlDHNo uARbKkZ2OeFoGOk2RFcQVsLZMjewT8D7bKzh76qtMgEfGpFjR9XVhC2nBYYh3a17WTpk7 UZktYJojxCdJS9G/nfDaJmYY8cvmK5K2bTlnevTb8GbscHgyV0EMUJjNSY522xXza1w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WgtTr2XU; arc=none smtp.remote-ip=192.198.163.12 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB6DD606A332; Tue, 3 Nov 2026 11:53:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DB6DD606A332 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WgtTr2XU DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793706830; x=1825242830; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=E/bb+RaCzD9TUBzETNHN6mhOmTvpe0fusV4NGUlFins=; b=WgtTr2XUfrkdgwKdkspizAkUNpeCiHg/8hDyPlGmAr2eNseeTeJOc25F Noy5yFeTV+7pX8kVuF859zxlbLQ4Q1mHnAiXaro59b3zG2PmxpaTW68j3 uCTqXi5kx/pz8cwB7WwwDuL3+zs8cU6a3iD+vVf/cEAfRIwu/VpG7PECb NTp5hpFCNGxFq+TuqkohKZVPVv6ahflG39dfdcRaSaF6KFrwyk6vCUV7Q CM9yZRqgWsw2NxqhmIBg+L+aRxIWBp2Jarxol8O8gp17nCUgN6zgd8Liw UcAhbAtMksfdtfJXVRG78+pzSmpjrrx1gR+pVHCyei0HskEIv5AxoKMif w==; X-CSE-ConnectionGUID: 7fiVG2L0Qeun/G1KlolUoQ== X-CSE-MsgGUID: ETlLr33sQsaI0ZRst4ThIQ== X-IronPort-AV: E=McAfee;i="6800,10657,11954"; a="2316694" X-IronPort-AV: E=Sophos;i="6.27,193,1787036400"; d="scan'208";a="2316694" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2026 03:53:50 -0800 X-CSE-ConnectionGUID: /KnJXmWqSWWiqTNtxQs9vQ== X-CSE-MsgGUID: E6NN+KmHSOeB/tZ6Q5EIWQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,193,1787036400"; d="scan'208";a="6735312" Received: from ettammin-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.108]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2026 03:53:47 -0800 Date: Tue, 3 Nov 2026 13:53:44 +0200 From: Andy Shevchenko To: Kang Chen Cc: Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , Andy Shevchenko , Greg Kroah-Hartman , Raushan Kumar , Chelsy Ratnawat , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] media: atomisp: reject short _DSM packages Message-ID: References: <20261103114121.74901-1-k.chen@smail.nju.edu.cn> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261103114121.74901-1-k.chen@smail.nju.edu.cn> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Nov 03, 2026 at 07:41:21PM +0800, Kang Chen wrote: > gmin_get_config_dsm_var() walks the package returned by the atomisp > _DSM function, but it does not reject packages with fewer than two > elements. count is unsigned, so an empty package makes count - 1 > evaluate to UINT_MAX and the loop walks far past the end of the > elements array, reading unrelated memory. > > Require at least two elements before scanning the key/value pairs. Stop being a meat proxy to AI. Read the code. NAK. -- With Best Regards, Andy Shevchenko