mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Christopher Hoover <ch@murgatroid.com>,
	Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Sanjay Chitroda <sanjayembeddedse@gmail.com>
Subject: linux-next: manual merge of the iio tree with the iio-fixes tree
Date: Tue, 3 Nov 2026 14:19:10 +0000	[thread overview]
Message-ID: <auntXn1lF8QIemTp@sirena.org.uk> (raw)

[-- Attachment #1: Type: text/plain, Size: 2718 bytes --]

Hi all,

Today's linux-next merge of the iio tree got a conflict in:

  drivers/iio/temperature/hid-sensor-temperature.c

between commit:

  73c53b592a982 ("iio: temperature: hid-sensor-temperature: Use per-instance callbacks")

from the iio-fixes tree and commit:

  f5df16bbfbd60 ("iio: temperature: hid-sensor-temperature: convert probe and teardown to devm-managed resources")

from the iio tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

diff --cc drivers/iio/temperature/hid-sensor-temperature.c
index ae67daff6df5a,ac5a287d1de32..0000000000000
--- a/drivers/iio/temperature/hid-sensor-temperature.c
+++ b/drivers/iio/temperature/hid-sensor-temperature.c
@@@ -233,39 -238,14 +234,17 @@@ static int hid_temperature_probe(struc
  
  	platform_set_drvdata(pdev, indio_dev);
  
 -	temperature_callbacks.pdev = pdev;
 -	ret = devm_sensor_hub_register_callback(dev, hsdev,
 -						HID_USAGE_SENSOR_TEMPERATURE,
 -						&temperature_callbacks);
 +	temp_st->callbacks = (struct hid_sensor_hub_callbacks) {
 +		.send_event = temperature_proc_event,
 +		.capture_sample = temperature_capture_sample,
 +		.pdev = pdev,
 +	};
- 	ret = sensor_hub_register_callback(hsdev, HID_USAGE_SENSOR_TEMPERATURE,
++	ret = devm_sensor_hub_register_callback(dev, hsdev, HID_USAGE_SENSOR_TEMPERATURE,
 +					   &temp_st->callbacks);
  	if (ret)
- 		goto error_remove_trigger;
+ 		return ret;
  
- 	ret = iio_device_register(indio_dev);
- 	if (ret)
- 		goto error_remove_callback;
- 
- 	return ret;
- 
- error_remove_callback:
- 	sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_TEMPERATURE);
- error_remove_trigger:
- 	hid_sensor_remove_trigger(indio_dev, &temp_st->common_attributes);
- 	return ret;
- }
- 
- /* Function to deinitialize the processing for usage id */
- static void hid_temperature_remove(struct platform_device *pdev)
- {
- 	struct hid_sensor_hub_device *hsdev = dev_get_platdata(&pdev->dev);
- 	struct iio_dev *indio_dev = platform_get_drvdata(pdev);
- 	struct temperature_state *temp_st = iio_priv(indio_dev);
- 
- 	iio_device_unregister(indio_dev);
- 	sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_TEMPERATURE);
- 	hid_sensor_remove_trigger(indio_dev, &temp_st->common_attributes);
+ 	return devm_iio_device_register(dev, indio_dev);
  }
  
  static const struct platform_device_id hid_temperature_ids[] = {

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2026-11-03 14:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 14:19 Mark Brown [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-11-03 14:27 Mark Brown
2026-09-02 11:15 Mark Brown
2026-05-07 10:05 Thierry Reding
2026-05-07 10:29 ` Jonathan Cameron
2026-05-07 10:41   ` Thierry Reding
2026-01-20 15:45 Mark Brown
2025-05-06  5:57 Stephen Rothwell
2025-05-06  5:51 Stephen Rothwell
2024-05-31  4:06 Stephen Rothwell
2024-04-30  5:15 Stephen Rothwell
2024-05-02  8:36 ` Jean-Baptiste Maneyrol
2024-05-02  8:58   ` Jonathan Cameron
2021-10-01  3:38 Stephen Rothwell
2021-10-01  8:27 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auntXn1lF8QIemTp@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=ch@murgatroid.com \
    --cc=jic23@kernel.org \
    --cc=jonathan.cameron@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sanjayembeddedse@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®