mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Daniel Scally <djrscally@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Bartosz Golaszewski <brgl@kernel.org>,
	driver-core@lists.linux.dev, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] driver core: platform: fix sw node use-after-free on device release
Date: Tue, 3 Nov 2026 15:38:16 +0100	[thread overview]
Message-ID: <aunx2B_OgODKZdVw@hovoldconsulting.com> (raw)
In-Reply-To: <20261102111420.1330760-1-johan@kernel.org>

On Mon, Nov 02, 2026 at 12:14:18PM +0100, Johan Hovold wrote:
> Sashiko noted a new use-after-free issue when freeing platform device
> which has a software node as its primary fw node.
> 
> Turns out that can cause trouble also when drivers or subsystems remove
> software nodes themselves.

Hmm. The subtleties of the software node implementation got the better
of both the LLM and its operator it seems.

Clearing the secondary node when the device has only a software node
does indeed clear the fwnode pointer so there was never any UAF here.

I've dropped the first patch from the driver core testing branch.

Sorry for the noise.

Johan

      parent reply	other threads:[~2026-11-03 14:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 11:14 Johan Hovold
2026-11-02 11:14 ` [PATCH 1/2] " Johan Hovold
2026-11-02 13:48   ` Bartosz Golaszewski
2026-11-02 11:14 ` [PATCH 2/2] software node: fix primary software node removal Johan Hovold
2026-11-02 16:34   ` Johan Hovold
2026-11-02 22:11 ` (subset) [PATCH 0/2] driver core: platform: fix sw node use-after-free on device release Danilo Krummrich
2026-11-03 14:38 ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aunx2B_OgODKZdVw@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=brgl@kernel.org \
    --cc=dakr@kernel.org \
    --cc=djrscally@gmail.com \
    --cc=driver-core@lists.linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®