From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.210.172 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793720427; b=dWCm0E9Ra+OEOd9gYbAmK5x6HDyQW33/uGrwrZ1wBIcDR3sdrCHlFlo+hxmVtlneHgtI 5qYo+tuMIWcIieOzbyVTIlPaB9y6epQGrhNMf1mutNAPikrf7Otu8i3DEvtg4klz6wUEM dOOX51D9yUBxroHofPgkS0nxz04cvPB0aJStv0EJoRGBWaZxa9JBeAUTYh1iONrM9bZMc ruwGPWYjfMc8wmSqKosVc/OGgSlt7Owv1sirbXMR+P/XUNFs0RoYpzNmu7rdXpfgeLGfG DnQ/enjuUgs4wEo+l+k54ak9pUj4T07AZy7IBmnVRS/d1oMBweqxtO6dt+IaWRCHwqw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793720427; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:Content-Transfer-Encoding: In-Reply-To; bh=EWOQO4/BUeLCAM60Oj14E4iA/D66uZxulDoNLysenrQ=; b=eAqhnnZEtFbNJBTm6a8KvSY++AFV5BvVUgjuh48oqKV8V++Pf7M2AuaiM8kGcxRluU7r haOcNii3coiOUuclq7oCPXfWWdUaBlP91zfUivaKicgX4x7eEadGa/iwuDTwuREIpRmzf +Ad87oV6lXX3vgJdKJjDSSPAIXl+q3J57WaIkR9vIBo6rW0FtftpSH9tYZvCNZT2cymUY bGl6mvusvX9/YWX1nWBkGKgDhcEElQJ4dka6jmhs9TmJRQGGe7ucyLUJ2Gf5VLUW9Uz+K jCn+EMEJR+MVkm2+/UssdSJfvXYZPPkSAb8l5oEUL67YRF0WtWEBLaKBIjjzIMDivdw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=pUETLBTW; arc=none smtp.remote-ip=209.85.210.172 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7CEA606A326 for ; Tue, 3 Nov 2026 15:40:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B7CEA606A326 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=pUETLBTW Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-8a594d313a3so2480377b3a.1 for ; Tue, 03 Nov 2026 07:40:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1793720426; x=1794325226; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=EWOQO4/BUeLCAM60Oj14E4iA/D66uZxulDoNLysenrQ=; b=pUETLBTWIvwlMvuFs2mQF3pRTpqENYDE37o5CSJtB3lIWgkNChpiJHnUlnmH/tx5mn tqtH1L4R8L6PezaGk0iHeXlKQR9oa5Je/mXiOPMBPS4KJgPIMeHBULerzoLJmATPkxNr aibTH3arP5QNEKO26Bz3Dqc73dvqSYylIiZvViAX628hSOQWrrsN/gJ/tRDD4SfzmuOD DOk99cF+4NSSXjM8oZhTsM9wTqvM4+FIzumLEvmQPcXeVkOUNE4QrLwBbe4YLKMITDzf mlqnmpRNU2VF4HbccmPxnb0eBH1NZMfWyqVQVAC7Z0+xiFWt4ENkbU7IFMBQ7rp9HPFp ps2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793720426; x=1794325226; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=EWOQO4/BUeLCAM60Oj14E4iA/D66uZxulDoNLysenrQ=; b=gOP7Dg2IKeT7dczEE9TQW0ks3Mtw4sjsrYa+0KRQw0V1VH1CpJIJIFjeFg3suWt2Pi uute2ug1RXHrBbyqBRDyOZGqU0JdpjSqk1qn+OsgHbSSk3uUwZJLa7hBAV8nPfBsQ+IV WMYUpU2zMoWiVFlQgvQu7dr3sML4y24odVSuOUqY3AhDHWsB1pmxZvl0mSHXewkNrwMz 2sOxWYVA+YrM8Tkh0UuEe5j/8MDitjQWxYOP2Rry+V4kJ3vU2+icEeekfAfByRaTFJC8 fJxIGaRoXkynBIFLYDoHJmiWtgGLeyPYmyjzH8kxXYDd1iTCdU7KTsZllPD8M6matm58 1i2g== X-Forwarded-Encrypted: i=1; AKwUvBwlMO+pTyy3QUQhSyh2qEmvFV3YASJMQHh28L3sw5+r5TC9YQAoTvjg5/3xqJi4yfkHZH3pS09b47mioDY=@vger.kernel.org X-Gm-Message-State: APuU4Z8eL7Ov7oNInZFiCuf+L3/+sbJlkcJZ4M8opv5oxzz31o+kfrSI Rsp1GSFdeM8PKqtQ+fTvLshKtho7+rNyQ9jFy+DXESXf7MuwBRHWgnqmrHiDKjpXBzE= X-Gm-Gg: AYBFou3Z3t42+yfxfm+XLq9kztMjecKEPf06J2OZFSQKX35ImQsiUHXZWnNd485ks8m 7+anBmoNzVvsVUMdR+YHEk8kbeGqKSfHjsdzI+qKws1UYzM4hedLFGwQ5ehiEFGg+mp6Wrs7Wgl D+gAMKKhfL2Vro5Lzc7hVdvT3l4Fg7UE56oJgp6TKreR6p0a+s1M8V1WVqUPkNf+V94cufJCX+L gY/MbGjarELiiNdoxF2CWJ20FHDg2okAHgkfF/KQXoT+8p6LvuCN38F6DxvAL/XT2SDzTzO/u/E MXj/bdlp3pC1dLjOj5rDKauqwKPJExH0BlN1ao1wan3by3mUFfmHyxwT+Uit6nr4wRIW5wffpeF LPd0EzEtagjTSn6kFlmnpU5Vjb/irtbR94WBl5NeS6HG0S1Yf3Ywax0RiXFbHrNTlVicyVKxuuD HxStoAkEHt9dDQoGbPlIai5EjYnnroxitMiLomkmW+4P+rnOaZLsZhiYGLE2RrUupCj0qnYJ0ej pMdjLesHXGjv46AGDEakrhSgt/IJ36Xm1LYmw1sZRHZG0ARzK0HnEgsiUEQNW+yXeEtzHx46yHU 4+IlAYNTnBOnM6x1AiGhC+/hVQ0CNQ== X-Received: by 2002:a05:6a00:3992:b0:8a0:1acb:677a with SMTP id d2e1a72fcca58-8a9bffd381dmr11899872b3a.57.1793720425872; Tue, 03 Nov 2026 07:40:25 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:9b3e:1037:bf8:ee7d]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8aada3d3603sm3345314b3a.37.2026.11.03.07.40.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 07:40:25 -0800 (PST) Date: Tue, 3 Nov 2026 09:40:22 -0600 From: Mathieu Poirier To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Bjorn Andersson , Wolfram Sang , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH v2 1/2] remoteproc: elf_loader: Create new callback for copying segments to remote cpu Message-ID: References: <15d90126debc21c116c9e862a007afa4d81f704c.1793117996.git.u.kleine-koenig@baylibre.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <15d90126debc21c116c9e862a007afa4d81f704c.1793117996.git.u.kleine-koenig@baylibre.com> Hi Uwe, On Tue, Oct 27, 2026 at 05:25:20PM +0100, Uwe Kleine-König wrote: > Some devices have special needs about how an Elf segment is copied to > the remote cpu's memory space where the default implementation using > memcpy_toio/memcpy and memset_io/memset isn't suitable. An affected > mainline driver is imx-dsp-rproc which includes a near-copy of > rproc_elf_load_segments() just to handle the IRAM only allowing 32 bit > accesses. On (not-yet-mainline) ADI SC846 the respective memory isn't > directly accessible at all and DMA must be used to copy the data. > > The new callback can be used to implement just the driver specific > memcpy + memset to increase code reuse. > > The patch only appears big because of indentation changes. > > Reviewed-by: Peng Fan > Signed-off-by: Uwe Kleine-König > --- > drivers/remoteproc/remoteproc_elf_loader.c | 64 +++++++++++++--------- > include/linux/remoteproc.h | 4 ++ > 2 files changed, 41 insertions(+), 27 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_elf_loader.c b/drivers/remoteproc/remoteproc_elf_loader.c > index da3cddbe7d4c..3c749a39e5da 100644 > --- a/drivers/remoteproc/remoteproc_elf_loader.c > +++ b/drivers/remoteproc/remoteproc_elf_loader.c > @@ -227,35 +227,45 @@ int rproc_elf_load_segments(struct rproc *rproc, const struct firmware *fw) > break; > } > > - /* grab the kernel address for this device address */ > - ptr = rproc_da_to_va(rproc, da, memsz, &is_iomem); > - if (!ptr) { > - dev_err(dev, "bad phdr da 0x%llx mem 0x%llx\n", da, > - memsz); > - ret = -EINVAL; > - break; > - } > + if (rproc->ops->memcpy_tova) { > + ret = rproc->ops->memcpy_tova(rproc, da, elf_data + offset, filesz, memsz); > + if (ret) { > + dev_err(dev, "Failed to copy segment %d to device address 0x%llx: %pe\n", > + i, da, ERR_PTR(ret)); > + break; > + } I really like your patch, but I'm wondering why you decided to move rproc_da_to_va() in ops->memcpy_tova(). Right now it is called in both path, i.e with and without ops->memcpy_tova(). Wouldn't it be better to unconditionally leave rproc_da_to_va() in rproc_elf_load_segments()? Thanks, Mathieu > + } else { > + /* grab the kernel address for this device address */ > + ptr = rproc_da_to_va(rproc, da, memsz, &is_iomem); > + if (!ptr) { > + dev_err(dev, "bad phdr da 0x%llx mem 0x%llx\n", da, > + memsz); > + ret = -EINVAL; > + break; > + } > > - /* put the segment where the remote processor expects it */ > - if (filesz) { > - if (is_iomem) > - memcpy_toio((void __iomem *)ptr, elf_data + offset, filesz); > - else > - memcpy(ptr, elf_data + offset, filesz); > - } > + /* put the segment where the remote processor expects it */ > + if (filesz) { > + if (is_iomem) > + memcpy_toio((void __iomem *)ptr, elf_data + offset, filesz); > + else > + memcpy(ptr, elf_data + offset, filesz); > + } > > - /* > - * Zero out remaining memory for this segment. > - * > - * This isn't strictly required since dma_alloc_coherent already > - * did this for us. albeit harmless, we may consider removing > - * this. > - */ > - if (memsz > filesz) { > - if (is_iomem) > - memset_io((void __iomem *)(ptr + filesz), 0, memsz - filesz); > - else > - memset(ptr + filesz, 0, memsz - filesz); > + /* > + * Zero out remaining memory for this segment. > + * > + * This isn't strictly required since dma_alloc_coherent already > + * did this for us. albeit harmless, we may consider removing > + * this. > + */ > + if (memsz > filesz) { > + if (is_iomem) > + memset_io((void __iomem *)(ptr + filesz), > + 0, memsz - filesz); > + else > + memset(ptr + filesz, 0, memsz - filesz); > + } > } > } > > diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h > index 00019b1895e6..e750a127cbc4 100644 > --- a/include/linux/remoteproc.h > +++ b/include/linux/remoteproc.h > @@ -75,6 +75,7 @@ enum rsc_handling_status { > * @detach: detach from a device, leaving it powered up > * @kick: kick a virtqueue (virtqueue id given as a parameter) > * @da_to_va: optional platform hook to perform address translations > + * @memcpy_tova:optional platform hook to copy data into remote memory range > * @parse_fw: parse firmware to extract information (e.g. resource table) > * @handle_rsc: optional platform hook to handle vendor resources. Should return > * RSC_HANDLED if resource was handled, RSC_IGNORED if not handled > @@ -99,6 +100,9 @@ struct rproc_ops { > int (*detach)(struct rproc *rproc); > void (*kick)(struct rproc *rproc, int vqid); > void * (*da_to_va)(struct rproc *rproc, u64 da, size_t len, bool *is_iomem); > + int (*memcpy_tova)(struct rproc *rproc, u64 da, const void *src, > + size_t filesz, size_t memsz); > + > int (*parse_fw)(struct rproc *rproc, const struct firmware *fw); > int (*handle_rsc)(struct rproc *rproc, u32 rsc_type, void *rsc, > int offset, int avail); > -- > 2.47.3 >