From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.48 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793728204; b=HmlYsgXucAXsA2/GyCgw3nheYAd/QgwoIyUQCN8famz4x0WL9ew+fVVpC4Z3K2kr292z CcckLMdYLo+4wlAj5hUmB2LsT1/Y4/zgB/ipqXoWeezvP58JjKAfSWR9Ir02dOB+qvfbE az/CQ8KV6KtS7daNAk0mgcAosAQyUpnWL5lgMqbih4CJTPHKAuco04V14VjE0YOI30kxZ d+dM2D/pGtqEqOYwkSNDdW1eQXk8+1S4yy7vJSuC8pxRAwRPeFmEnfdyrkuE9vsZfjnSg mx70Ej4QZBXRbQ4R0hZyV4KdSZgyuaWbCGqABlOmuUQ4ZICZsKlfrA44TRtWeHzKASQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793728204; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=EvBKZYbsyPjC/KbvTWeWl/x1jiG+4Pze5t2xnn/ZrCU=; b=iMys8OzulRF6LyKH4uVoeHt22AlE8V6bVQBemSOQmGSgReo1T8MyyjUX1Jggs0zQGNRG /jkklCkZ0NN92jjdhJjw5RBE+3t7/EgZaZEz45NifvdhcrrKN69Joa+MeUXTtUpoa4ZML 4DnplCTTH/L2lavOdF/ATDjaXHwmNKJ9WChC5HNxCbs0F9eTSzl5GZccmxNWdKenAKl4s oKsoqFdUuMjcTszo5S5ZNpkRxInG5w56B80xV3eRpESspbjdu7pOcOO9Ml3wFzGhXbu7+ VY75svGQLkxO/rF30wZQPXtslN+VCCb9NIXEtZosZZMDpHI0et7s/K3NDzq6g5J1+cw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b="b/IyMV2b"; arc=none smtp.remote-ip=209.85.128.48 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6FA7606A329 for ; Tue, 3 Nov 2026 17:50:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C6FA7606A329 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=b/IyMV2b Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-49d05d51553so29642485e9.2 for ; Tue, 03 Nov 2026 09:50:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1793728201; x=1794333001; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=EvBKZYbsyPjC/KbvTWeWl/x1jiG+4Pze5t2xnn/ZrCU=; b=b/IyMV2bpaMVswQSzeQ1PZsZb2CjE54ozGqexHU8bBXqD0JQSLXMR2/ti16UV5NNr/ TkCp/RRKQ+et3iOkt7F9Lcmm+kzMAdAdwfXYEPIGXYifNQNsT6zo1s9sEj2bXgHNOLBz z3E0FdH+CGHbPw5xzqc2TgyXastiegaTK7bvhEnrZNEpuxw0WJOE9+UPC6en3jn3FzPK hYJm9KYs539y/Qc88zeBN51oct/UcaOrtO/cekHyUj2nQm9jJAoneGqQIyXqtxn611wn 1MoTbH5CD2JfN/+LIzLYRSrzDZfLjIJA5L4V2uJPecLnmUIZDYDjB8L7eH63+TAxK7qI sw6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793728201; x=1794333001; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EvBKZYbsyPjC/KbvTWeWl/x1jiG+4Pze5t2xnn/ZrCU=; b=PHLkGbG2KIvofYkKGFxlXTOczjfmc/TLFHuKcgrgA8IXkmofiO7+sI/s+p7rLes1Z8 WnrqeKylWLZCzRkmqFNuJdgz5RThf85N3ayJnUmI0vCk+mLepKbyQI9vzKWID/jEKB+a nC4DaXWN7WKXh3ZmMnNJe5p5GhSVfnAfufE9O7XAWWzS5/h7okgGRPgK7ScbCOFD9Snx wC5Uwdmvz23tLUreF2obw16LpfyEkSz6wpOF3cw8HkZJNqyQIVcnZw7nDjD1GH+wE+x9 5TbxP9KScAIfcLk5fp9rJge1wDBk7fceOC4FI8+FDKobunQDZwJEht8SSIlbfia356HV dNgg== X-Forwarded-Encrypted: i=1; AKwUvBw8IsEvB4aqTypJqCwtneW73mRZ1NsDfAqYc034IxQh3kEoN0W2KVzDJPXuNKAiU+qDkacxP2RDRVLChig=@vger.kernel.org X-Gm-Message-State: APuU4Z/o2BXVlb24aPF4PLIZvTjP5Ch5swZy6hM5Zh6Y1vEHtrn/VanS fLrwrh4vniP0e6z5xQRUI33htHqs4jtYKupxUgGBmyuYpNmje04XIwxnF3Gb1lP4joo= X-Gm-Gg: AYBFou0d9qhakJaz0/t4aV7QIQ/zXdWfUQdYPJpkTMXo69jaFEn5o0wFHYIuynzOumh jldgk21ey6uhboQEOHyd3GtiaZvwsXlxVcXPiA6DwYIGKWzWcsgdjxZroXv4jiiqaz38u3GkwDQ H94zbloshyeIY4WRV/dm6xg3U69oHaCg+SVJ0KtfXP5bOpqmhZWR/mnoxvAeUdUPK5lJ0oFH/Jv SMLthHycqmXgGfgUR+hZfSIJHdrBU22QV+axgs0sCxlfB7wV7XuecwYdWMZPR6euakrUA176mUz t+zFrh/sLK7M4OMA2dK5GRixx4OGuDv0QltWFXM06tg46/DhXKe81Yd1LJBS6cN32EQiUv+U7UJ rDTuEOKOC1VZU8S5lRyoW2Fprc6pETMQFuoHRHHkyJyvHMNtCCiYXMtOVe7M8Y/KPKka8WOhWWY GMjU2jJ9QYeyxjrZCT81QnOWqMg9QU9XWkbV0vIZMtiLmjMVkgI4xQn0zI/btAWOIXHcOfxDhNm X7mMFsvwBbqTtx5JCX1qXKoWTn6Qh/uc0oKE/k6U9vu5NqZtm8l4lPdOTObjQRHkSoJoylSsCeK 9KB/7UO5LxNxotc99QiIras6JW5QLmv0/Cbj9pe2F5z0CRlAPlza2HITdygS2UVcDLW73sdihMd woWpFuq4TZnO7ng== X-Received: by 2002:a05:600c:674a:b0:4a1:fb23:68f0 with SMTP id 5b1f17b1804b1-4ac14ec788emr319488995e9.3.1793728201219; Tue, 03 Nov 2026 09:50:01 -0800 (PST) Received: from localhost (p200300f65f19a9048e0e65dd41210f6d.dip0.t-ipconnect.de. [2003:f6:5f19:a904:8e0e:65dd:4121:f6d]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-48e71b80333sm28497156f8f.32.2026.11.03.09.50.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 09:50:00 -0800 (PST) Date: Tue, 3 Nov 2026 18:49:59 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Mathieu Poirier Cc: Bjorn Andersson , Wolfram Sang , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH v2 1/2] remoteproc: elf_loader: Create new callback for copying segments to remote cpu Message-ID: References: <15d90126debc21c116c9e862a007afa4d81f704c.1793117996.git.u.kleine-koenig@baylibre.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tqt42yzt45wmalce" Content-Disposition: inline In-Reply-To: --tqt42yzt45wmalce Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2 1/2] remoteproc: elf_loader: Create new callback for copying segments to remote cpu MIME-Version: 1.0 Hello Mathieu, On Tue, Nov 03, 2026 at 09:40:22AM -0600, Mathieu Poirier wrote: > On Tue, Oct 27, 2026 at 05:25:20PM +0100, Uwe Kleine-K=F6nig wrote: > > diff --git a/drivers/remoteproc/remoteproc_elf_loader.c b/drivers/remot= eproc/remoteproc_elf_loader.c > > index da3cddbe7d4c..3c749a39e5da 100644 > > --- a/drivers/remoteproc/remoteproc_elf_loader.c > > +++ b/drivers/remoteproc/remoteproc_elf_loader.c > > @@ -227,35 +227,45 @@ int rproc_elf_load_segments(struct rproc *rproc, = const struct firmware *fw) > > break; > > } > > =20 > > - /* grab the kernel address for this device address */ > > - ptr =3D rproc_da_to_va(rproc, da, memsz, &is_iomem); > > - if (!ptr) { > > - dev_err(dev, "bad phdr da 0x%llx mem 0x%llx\n", da, > > - memsz); > > - ret =3D -EINVAL; > > - break; > > - } > > + if (rproc->ops->memcpy_tova) { > > + ret =3D rproc->ops->memcpy_tova(rproc, da, elf_data + offset, files= z, memsz); > > + if (ret) { > > + dev_err(dev, "Failed to copy segment %d to device address 0x%llx: = %pe\n", > > + i, da, ERR_PTR(ret)); > > + break; > > + } >=20 > I really like your patch, but I'm wondering why you decided to move > rproc_da_to_va() in ops->memcpy_tova(). Right now it is called in both p= ath, > i.e with and without ops->memcpy_tova(). Wouldn't it be better to > unconditionally leave rproc_da_to_va() in rproc_elf_load_segments()? The reason is that on ADI's SC846 the memory for the remote processor isn't directly accessible by Linux. So there is no virtual address for the given device address and thus the implementation of .memcpy_tova() on that machine won't use rproc_da_to_va().=20 Best regards Uwe --tqt42yzt45wmalce Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmrqHsQACgkQj4D7WH0S /k4sjAf/W9Wh/o2zfPqQyyyOgx0wwKDVNUCFZ3gnMmbmk4VZdCin6ZavZplg6T+x coNDAgnxOftZnuWR1SpiFa6XCTmAE5ZxvNLbwzw6DF+G4Bq+z2ifELs9uZh/U0eo HrJFd/MaHMCnZdw7Hr1emJPiegROrwq5psibMrjJItAbtrvyFUFKXQ+YKYY128Pi 8945jUEVVmAFRQ3nCV50qJW8+KPt36ZWnBRt8TjZHMMaHWuhLDuXsqUsCiYDkFnf MeO9tFp+Aw2Nk78rkgmSg9kOauIt2+3ievOTOCN2haO43CYNx+In6f7GwLzSq2R2 Iffz8Diu7OmLg5+j4A7mG6jW7l/4RQ== =MoF6 -----END PGP SIGNATURE----- --tqt42yzt45wmalce--