From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.49 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793731742; b=h4kx/rTvI55Nem9Soe8UHTWiigU8iO5wqDVm987h4IZ8zQue5vzWGBMvX1Ia7lL4eiU9 GZDOOjmRVnrOch6/qiVebTALG1Wk2VD2gI5DpmbIJpNWrwRlkZ8uB7eQF/fNsnAvjR02L LsqObTXsDQT2R9MWp3g7sMOmR1kaI5zkvGQp6qdzYrgVCxPMU0gd0G7Wv+4rgefihtGEJ 5ZAM4+zsDcavJyUBoRAgMLcvL0aAzycrECcGUSr6dtd1tAZde3FPxeqdLJNDk4olSlpa9 wpan1zi2dJfOt5EY+WDOEwLG/a4GUoJ3gEV6Cw90XUtUA4t5y6WAUMBVBRk+4AsmTwA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793731742; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:Mail-Followup-To:References: MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=gZOM3Lc0bVWMBjTHBnWLKucS3KUPQN4gjQNABudBe20=; b=Jb9YezPCmdDyzBtuvkHxxmnlTsUagnTAyaGQvdx0p4JLplCRSMoVJ+YQ80+1PxFJR9e8 nb3BA3hvBQSzfD5O8IkcYprQRG9TS8CaGMYE4cWbZWQqG4luaNUZsiBRXbgBhhrI6K0+B JwbfwJhXmAvOSkbBtm4qe/7CqnXJKngKo71a198qcekgT9GLSwopM7RrlOFXM+/IlkghB S/eq24XVfh45esBPl9RQyhKI63R7gYKv1hesIscaI70558DmXrKd+FearqKAfx5A2GSdB 3JqpGBXVqZTR3s+A+DTQ7C5np5/WEVd9XsIYVByA3kVFf1C9w2pAEBHkZuGAvpB9Abw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass header.d=dama-to.20260707.gappssmtp.com header.i=@dama-to.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=l2wyXFYq; arc=none smtp.remote-ip=209.85.216.49 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62D2E606A334 for ; Tue, 3 Nov 2026 18:49:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 62D2E606A334 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=dama-to.20260707.gappssmtp.com header.i=@dama-to.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=l2wyXFYq Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-3acdcfa2bd3so3541146a91.3 for ; Tue, 03 Nov 2026 10:49:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20260707.gappssmtp.com; s=20260707; t=1793731741; x=1794336541; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=gZOM3Lc0bVWMBjTHBnWLKucS3KUPQN4gjQNABudBe20=; b=l2wyXFYqZ38HdD8weK/KapS0MavCwUQNm5m8p8EfD+xcRcfXIyTrWWCNYRgp+/vQ0i ksJeEnZRdauMXUDBIZc/C71nEF+uDmJu0b2vpkgdxljq1Llv0dVefDe8tt/GoIUKxdDi 3xRF0zFO9MWrdxdNUCyRSdqrWItJMZuhGMr20/CjBv3vMHjFjcO3YJ4KB2UcGkjbav0W m1relR/fPR+6ZF2d2H70rXUjyAYD34Uf84QZMC23/6a0tilojHf/umSUEE2/WXKUOb8Z NKpSimujPUoPOAcbNR09PhouGBvrnhvrxiWmGn8meE7bZMxPXPfKrnVl4uhWDJVGvnIm iNDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793731741; x=1794336541; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=gZOM3Lc0bVWMBjTHBnWLKucS3KUPQN4gjQNABudBe20=; b=LAHn5WDMs24Ls05+Dt2DEopp2Am7ccm1Tcl4ai43MOGnm98CsAOPamm48Aeic49e7S tEEwmjqGSNsYIXoHwOie8X4TKjIYnwk9Wur+Ai2aGJDQLHuhg00Ck+7u7jlx6iebRmFz ooVFdHkpEpizY5JYUCaGtq2ZbltvEM+8fTpv3ZAA+8LDyOd4GV4Fv6zInWQVZQQJux6a aq74VFd+86aOK3EmE3eJxn7sCHlT8VCdNuPz5RjKkTEROd5T5p+QudauwckDaj5JYD4q BxmbNySVB5VBHm8HmFPsdj6bHSC8Q3txu8rMwRCItH13wx8TJumdwtc4agxUzrDumDfY qxdQ== X-Forwarded-Encrypted: i=1; AKwUvBz3aOrrrh4zy5EMWKSFdAXsJ5Iv7i3tAByt5+4vs0VRKgMMYf4dHV/dpQrZ8cEoD7fCzgimZ3xRSAP9Gp4=@vger.kernel.org X-Gm-Message-State: APuU4Z/ahOtziqvfNgygQhQlVXWVKfikPX3ePPPonYwcaSbewo8/plL7 rC9TsI44FEEReqZAeXNmj0Hq2kias3W+Lhk/u1bkCh5sxJP+gDqldiuwKwg4X90U9j0= X-Gm-Gg: AYBFou2p13PXn/UqxGXrxF1a8Ez8/llwT6RM+xzw8R+TP36hZ9z3cyObcKpAwyWwoHd kd0adXoa2jtm0Vh7DTxQryJMRHeG/3CChtrhPjxj0m4UowWRahD5RD+MWBG4+oSDcESqMMtj7px Vj06jicBjTx6/W5LffK56x3e7bW/5UDjoDGbGsqqvb6ngeLDWjPjUZNVs/JvZmfyr8To87YM4hm 6J+EXoK5tC0lHFnjlLfOZOc1/xhXe+CDi22GYIwnI0oM13IuHbkrUm2u4B87q56a8oIRosvGQs4 pgBbCdgqYu9V8w/I+H0bpQSIP/OvU37fQXRrk/gcu2rlt1jkG1OPoyTDK3g5YkeYdaXMIEiWYo5 8HoQb3h3dIhxqFkWoCWV0Xu8tYFCOGaFKfttFFdETFfwei7rnO6Z+6K7rR6WM8j+mrTxEJgo473 Vocx2EQcsS+3Bv2k4umjKx77qcW4dzM/7MU4ntT7N7bFuHeYoiGKjyaq98r0QRy213KdoyQwAFX xV4keargAsaRGIVH0vQImNSZIwSt5mZyD3SqtccX4HbE9UjnJcFhTpAvTE+HZvJAQtT/zkTWB8I ITuXz1+vs/+N1AvKtYU7tSz7aVb5lcgj1REKrdiOxA== X-Received: by 2002:a17:90b:1d03:b0:3a8:49f2:8ddb with SMTP id 98e67ed59e1d1-3ae8984de33mr11985967a91.60.1793731740597; Tue, 03 Nov 2026 10:49:00 -0800 (PST) Received: from localhost ([2a03:2880:2ff:49::]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b0944bd88bsm210133a91.12.2026.11.03.10.48.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 10:49:00 -0800 (PST) Date: Tue, 3 Nov 2026 10:48:59 -0800 From: Joe Damato To: Frank Li Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Radhey Shyam Pandey , Michal Simek , Stephan Gerhold , Loic Poulain , Sergey Ryazanov , Johannes Berg , Frank Li , Andre Przywara , Li Youhong , Arnd Bergmann , bui duc phuc , Yicong Hui , Simon Horman , "open list:NETWORKING DRIVERS" , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , open list , "open list:ARM/QUALCOMM MAILING LIST" , imx@lists.linux.dev, vkoul@kernel.org Subject: Re: [PATCH] net: dma: use dmaengine_desc_set_callback() Message-ID: Mail-Followup-To: Joe Damato , Frank Li , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Radhey Shyam Pandey , Michal Simek , Stephan Gerhold , Loic Poulain , Sergey Ryazanov , Johannes Berg , Frank Li , Andre Przywara , Li Youhong , Arnd Bergmann , bui duc phuc , Yicong Hui , Simon Horman , "open list:NETWORKING DRIVERS" , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , open list , "open list:ARM/QUALCOMM MAILING LIST" , imx@lists.linux.dev, vkoul@kernel.org References: <20261102191922.4044912-1-Frank.Li@oss.nxp.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Nov 03, 2026 at 09:06:03AM -0600, Frank Li wrote: > On Mon, Nov 02, 2026 at 03:28:33PM -0800, Joe Damato wrote: > > On Mon, Nov 02, 2026 at 02:19:16PM -0500, Frank.Li@oss.nxp.com wrote: > > > From: Frank Li > > > > > > Replace open-coded assignments to callback and callback_param fields > > > of struct dma_async_tx_descriptor with calls to the > > > dmaengine_desc_set_callback() helper across net drivers. > > > > > > No functional change intended. Prepare to make struct > > > dma_async_tx_descriptor private to the DMA engine. > > > > > > Signed-off-by: Frank Li > > > --- > > > drivers/net/ethernet/allwinner/sun4i-emac.c | 3 +-- > > > drivers/net/ethernet/micrel/ks8842.c | 6 ++---- > > > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 6 ++---- > > > drivers/net/wwan/qcom_bam_dmux.c | 10 ++++------ > > > 4 files changed, 9 insertions(+), 16 deletions(-) > > > > [...] > > > > > diff --git a/drivers/net/wwan/qcom_bam_dmux.c b/drivers/net/wwan/qcom_bam_dmux.c > > > index cc6ace8d64371..1479f8362e04e 100644 > > > --- a/drivers/net/wwan/qcom_bam_dmux.c > > > +++ b/drivers/net/wwan/qcom_bam_dmux.c > > > @@ -195,9 +195,8 @@ static bool bam_dmux_skb_dma_submit_tx(struct bam_dmux_skb_dma *skb_dma) > > > return false; > > > } > > > > > > - desc->callback = bam_dmux_tx_callback; > > > - desc->callback_param = skb_dma; > > > - desc->cookie = dmaengine_submit(desc); > > > + dmaengine_desc_set_callback(desc, bam_dmux_tx_callback, NULL, skb_dma); > > > + dmaengine_submit(desc); > > > return true; > > > } > > > > > > @@ -477,9 +476,8 @@ static bool bam_dmux_skb_dma_submit_rx(struct bam_dmux_skb_dma *skb_dma) > > > return false; > > > } > > > > > > - desc->callback = bam_dmux_rx_callback; > > > - desc->callback_param = skb_dma; > > > - desc->cookie = dmaengine_submit(desc); > > > + dmaengine_desc_set_callback(desc, bam_dmux_rx_callback, NULL, skb_dma); > > > + dmaengine_submit(desc); > > > > I noticed in the above that the return value of dmaengine_submit is discarded > > instead of stored. > > > > Is that intentional? I suppose it might be because AFAICT cookie is never > > used and the commit message says "no functional change intended". > > dma_cookie_assign() already set desc->cookie in dmaengine_submit(). Of couse > it is not obvious. Do you need me update commit message to descript it. Ah, I see it now. In the tx_submit callback it looks like dma drivers set the cookie. So removing it here really is a no-op since it was getting set, as you said, during submit. My mistake. I don't think it's worth respinning just to fix the commit message just because I didn't dig deep enough :)