From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793783203; b=hgArRnxF5iJCH3yrX1mQ+a7QtM9OAwU1kuz+3SmF0H++u0KImX1owPeCl9EARAlurkI/ r17vCniNEFyHH/KY0txTJaVDAQ+L9+qSc6Q6TIaetg1UAHsfJAa6mSQ+Me8XL06QcI10R 3Xb43JF9wycvM8fstLI7Z3vXpENia+kWhXLlH5jgchKoLpwmpqA7rDSZwczDqGGA1pnSe RX9oGs29Ou6P/j8nXvqFAIXWYPVCOOlAjBX0eYeg0LZ74A9NiJqE5zddNBLvFPyuE4tLl hhvw8zS4zYmrIpxExYdJxR3QEXrWPM8BdlZsS/rW4pJP5IszWTWxmKt6PYdsQG6k0oA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793783203; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Date:From: To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:X-Authority-Analysis: X-Proofpoint-ORIG-GUID:X-Proofpoint-Spam-Info: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-GUID: X-Proofpoint-Virus-Version:X-Proofpoint-Spam-Details; bh=gQa5DpLs14qhLqK4W9xlR5hZAyauWHs/0OTG6Dba/a0=; b=EWt3eEQiJy807eZOIT5DLo9huZ/Zy0+v12S2v+lYDKEmzkkxQzbBMQPUuIckJ9k/huVO XWM8tPKaI/KjU22PZu7QwsKb2gEcGVunkfmZHCJO5cP4suZu1OVbBAgxEfDHAK42Y9ylM 8Lf1vlnCnpUvP42AzvvujhTkowJWXtD1F6OgeuKJCiPR0HtIaSYu+9HtjZ5Z/phz61UqR ZMWi1TRtRmfvNEN/Ox/m7fkisZnL/HmwLODVObXOq9sP51LKnEplnflD2VxqlF+MTH2cG +fbT89HaBf0C2ZvbH4e5flUV7HJY5yYLGC98k42TIqkeC23ijfcRxSUdZuZaAw2SJ0Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=aUPH3eH+; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=FpN3s08e; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81165606A31B for ; Wed, 4 Nov 2026 09:06:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 81165606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=aUPH3eH+; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=FpN3s08e Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6A48KNZr2290378 for ; Wed, 4 Nov 2026 09:06:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=gQa5DpLs14qhLqK4W9xlR5hZ AyauWHs/0OTG6Dba/a0=; b=aUPH3eH+W2Rx/McL8mFEKQtohjYWBhIjjM4jN0V3 lyzDJthwnyBW+z5luReBNvb+k11Vl5fHrUIkQrfSds5qig2LF6mqSztI6vLyf278 uBnaLbNu2qPW44M2nAz7rR9c/ILi/7JpWxD43G0UXC61H3clDbvRwuOcFAqdYhrS hWB7HXPXiWJ+7CpM8lo58KIBIAfqwQCPss72x9cJWE6MOwsd9e2lo1++u9WanaFI XPvJiAN80P2o43AW08gbzrzQbUM2gxcB0RodB1EpZnIcG/w/zC3OEyWaXr2OMRVE 8xgw9LqeB1TjBWM/qUS1ZVrl6+f6TYqN0jUMsGfYKAjujQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hqpuvajju-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Nov 2026 09:06:42 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-945b0154705so84993485a.3 for ; Wed, 04 Nov 2026 01:06:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793783201; x=1794388001; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gQa5DpLs14qhLqK4W9xlR5hZAyauWHs/0OTG6Dba/a0=; b=FpN3s08epL+CLggmbryzfWraDB1hBUicZZcmW5d1+/u/phKLA+WmyEMXgfgX74SUmb C3fA4eS11fmtJ5RRiw5YCcQMr7cOMYCuy2P/vqu7bwQat0EBOT7Vthf655vW+Ur+5E4C KDU36Dfqo4YOHp9VQkLFFHFRbcol0V8SIaf1VLF6Cz0N/agOYqewdmMbfaf+YmSgUxhK O80E8chEm2iENmKDAd+8jQCuFqUymvnI4FP6j3I/MabfzFIA9xos51t3V+tvHWKS0vnl RZdgVkisLAeDRmWA1FBf0dEN8lX/xd+hUF81Mgkjp6DFFcrXQSiKosjoBmqbJ6/3lQc0 oZew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793783201; x=1794388001; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gQa5DpLs14qhLqK4W9xlR5hZAyauWHs/0OTG6Dba/a0=; b=qE2HeKWEJPeuqKPZJZeI6hLFe1c40lNSEqSDvveGMP/xthTQgBRSK9QrTvrsMv4jax disGzDYgkKB1e0lnxZ+vLK2KUyHwdT+/gvDHTmTPX/+efBv6v4jNQgspH4as2SqWhzY/ HwejERzIc2IiAunxVepvqLX0fb5MNB88YGAJaA4WZAZBjgsBopmULrgaUkKYVOiN8eJ2 FXAsSJhFamp4IcckNBsZdRk3DOsZEddVIhNvHUJZvQtR4zinpH0kfhdsd4Nih8fzWIB3 2ebuvqvdouN+Ore4nmA6SFstPuk8Q3hvlVKw7odj2kmAoZM5FM8cQWemBTAV2MHGlchG cZfg== X-Forwarded-Encrypted: i=1; AKwUvByBQ8QZgXdZk/X1Hgkc6aEkOmwE86D0Cbt1Q50pfteKFFREGrQ4DfB04iJYI7s/WgLlf4qVg/Ox13uefUQ=@vger.kernel.org X-Gm-Message-State: APuU4Z+Ou3gn6fvJd3YS3ZhwbXjp7mtjKahZyCWWHmB9DL2B1zpqsJPB flPKZQIIj8Dp9bOsZJDHIxLZ86qOHJ+A9vKB9WMKp5N4hJrxKaXp6yCDWn09mF8yyjBF/Q+l8v2 O5OFM5UaGBzwSBZTeTquJa+dl6etmRsr+oUyXgRAFXFGimbvLbhAgSBfVD/7/NTIMFzQ= X-Gm-Gg: AYBFou0gtdgra4fxvkB7ALG5vcZaF3/GNuPvxLsSXhSgLE7LTP7nxVACr6EnJueSiLU mUPLVj88Uc2e77vyA75uwxrgR2JsYHrN7S8rP6M/rVVaKsjGeTsUPSSNVSGNECsMfRSJ5nWmieC OU/YkjC9ayPkXFijsGxbUFYLP4dS3RGyqHcFsWIhOcdlz50VVkk5BVuOodQQw7G8Rswj4FTicKt Yas/p4ae5PLel+My6hCQfHNfD8uzoX62G2qSjcHnh4bXSHArcXbvCmg0VVrR4/4HpXbsIJBn+cs Q2Daj/kiWfWzqFc4dspLXQ0xSvSIY5jcuiLwSgqw9Nk1SPLYeeMc4X5DShLzLDfuXwFlQeR8/Ug nOnj/UopwCv/xTSj3NigVEy3XtvKZ6cnvE3AVWVYe0OO/K5kGJgmM/MQ9nzZdlw== X-Received: by 2002:a05:620a:2605:b0:93f:2d52:613a with SMTP id af79cd13be357-9442171be85mr2685786385a.29.1793783201278; Wed, 04 Nov 2026 01:06:41 -0800 (PST) X-Received: by 2002:a05:620a:2605:b0:93f:2d52:613a with SMTP id af79cd13be357-9442171be85mr2685783685a.29.1793783200670; Wed, 04 Nov 2026 01:06:40 -0800 (PST) Received: from localhost ([93.66.104.131]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4b43d4c9d4csm53083945e9.12.2026.11.04.01.06.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 01:06:39 -0800 (PST) Date: Wed, 4 Nov 2026 10:06:38 +0100 From: Lorenzo Bianconi To: James Clark Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Chevallier , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jacob Keller , Kory Maincent , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: stmmac: ptp: fix support for PTP_EXTTS_REQUEST2 ioctl Message-ID: References: <20261104052504.1886335-1-jjc@jclark.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SZJ/srcPBu4OL5we" Content-Disposition: inline In-Reply-To: <20261104052504.1886335-1-jjc@jclark.com> X-Authority-Analysis: v=2.4 cv=O6SsLx9W c=1 sm=1 tr=0 ts=6aeaf5a2 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=cAAIdyqZgEis9HJxay2Blw==:17 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=idZxcIp9AAAA:8 a=EUspDBNiAAAA:8 a=IsTqagV5zfN5wvrX9F4A:9 a=CjuIK1q_8ugA:10 a=lgwzRCrlNXK7KLFCy_wA:9 a=IoWCM6iH3mJn3m4BftBB:22 a=NzLqzEvlDKEySyxblcRP:22 X-Proofpoint-ORIG-GUID: zRIAoivzDIHWo7FfZcaq9dmXy5qWrbQO X-Proofpoint-Spam-Info: AW1haW4tMjYxMTA0MDAzNiBTYWx0ZWRfX4Cz9MLjFJ+fj g5dcAxwDo8nnmKOa6bOHoBPXfm3e635iLo9ypWrvmTXOvVheAmGJneYkyPAoRPnmNU/7wQUfgzY 1KjeaFxuSww/b8MNbha6fyOwoewEUSU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTA0MDAzNiBTYWx0ZWRfXx3FsVzwiKqQ2 uVNMYRh6cu37wU+UL0XZ5Angq1X1Im7MasdK381MeMRtOfh3B2sfQmlRx7Nh62nMqDgrhxRY+JH VUPYK+Yb6y1rG9SdAy01Lp1Yi5TGxiSuCdwpA3/ChSEB9LU7xFtp5v4wlfP+EyWmCfCPyuOd0D2 McJaHzRmuDyQ6NB4GZuI7OIe8YEud9ubAsH0yWB/UFPrvmr/mlGc0sCdZ08hrds804ogFvo0e3g C7k3tQLC4RaTA18ikwQO9eeHmc3sZ0P/WxFOxD6XsZl6AMl1N1SVAGFHeZdTsPjrwUjriUxV//d 5L7ZBBJI/vXMAalEQ4D+5iYAvzBQwKHBQfLSA4eAhjlGcYxCxQEW9s9D6fSlayj/MOwX6T3Gu82 5MeHISTOuuDvafTrZzQmV+qYnvlNweE4VSE+mIFNtR2rSlnbxf16lLokPhS1tkHZ/csaCRjdX+f ebaTuK3k0BpcJsmSpvQ== X-Proofpoint-GUID: zRIAoivzDIHWo7FfZcaq9dmXy5qWrbQO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-04_02,2026-11-03_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 clxscore=1015 spamscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610300000 definitions=main-2611040036 --SZJ/srcPBu4OL5we Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > Commit 7c571ac57d9d ("net: ptp: introduce .supported_extts_flags to > ptp_clock_info") modified the PTP core to validate the supported flags > of external timestamp requests, rather than relying on each driver to > check them. >=20 > stmmac_enable() and dwmac1000_ptp_enable() ignore the flags, and > neither stmmac_ptp_clock_ops nor dwmac1000_ptp_clock_ops was given any > .supported_extts_flags. Since PTP_EXTTS_REQUEST2 always implies > PTP_STRICT_FLAGS, the core now rejects every PTP_EXTTS_REQUEST2 for > this driver with -EOPNOTSUPP, where before that commit the same > requests succeeded. Only the PTP_EXTTS_REQUEST ioctl still works. >=20 > Tests on an NXP i.MX 8M Plus (FRDM-IMX8MPLUS, GMAC 5.10a) show that the > auxiliary snapshot inputs timestamp just the rising edge. The reference > manuals for the STM32MP13 (GMAC 4.20a) and the Cyclone V HPS (GMAC > 3.70a, which uses dwmac1000_ptp_clock_ops) say the same. >=20 > Encode this in .supported_extts_flags. A PTP_EXTTS_REQUEST2 for the > rising edge then succeeds, and one for the falling edge or for both > edges fails with -EOPNOTSUPP. >=20 > Fixes: 7c571ac57d9d ("net: ptp: introduce .supported_extts_flags to ptp_c= lock_info") > Cc: stable@vger.kernel.org > Signed-off-by: James Clark Reviewed-by: Lorenzo Bianconi > --- > I used an LLM coding assistant to help prepare this patch. >=20 > drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/n= et/ethernet/stmicro/stmmac/stmmac_ptp.c > index a37405534beb..31a66e855d6b 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c > @@ -277,6 +277,7 @@ const struct ptp_clock_info stmmac_ptp_clock_ops =3D { > .n_per_out =3D 0, /* will be overwritten in stmmac_ptp_register */ > .n_pins =3D 0, > .pps =3D 0, > + .supported_extts_flags =3D PTP_RISING_EDGE | PTP_STRICT_FLAGS, > .adjfine =3D stmmac_adjust_freq, > .adjtime =3D stmmac_adjust_time, > .gettimex64 =3D stmmac_get_timex, > @@ -294,6 +295,7 @@ const struct ptp_clock_info dwmac1000_ptp_clock_ops = =3D { > .n_per_out =3D 0, > .n_pins =3D 0, > .pps =3D 0, > + .supported_extts_flags =3D PTP_RISING_EDGE | PTP_STRICT_FLAGS, > .adjfine =3D stmmac_adjust_freq, > .adjtime =3D stmmac_adjust_time, > .gettimex64 =3D stmmac_get_timex, > --=20 > 2.56.0 >=20 >=20 --SZJ/srcPBu4OL5we Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCaur1ngAKCRA6cBh0uS2t rF0OAQCBQ4Jznbj+YmV/bTgLSjoDCUuZ+PomAAi2n95oMB8GFgEAu1dSRv/ORtKN Qbwi4a7nP3qZRg0fNZrxJwojDXqy9wk= =YZZD -----END PGP SIGNATURE----- --SZJ/srcPBu4OL5we--