From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Frank.Li@oss.nxp.com
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Frank Li" <Frank.Li@nxp.com>,
"Haoxiang Li" <haoxiang_li2024@163.com>,
"Zhaoyang Yu" <2426767509@qq.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
"open list:TTY LAYER AND SERIAL DRIVERS"
<linux-kernel@vger.kernel.org>,
"open list:TTY LAYER AND SERIAL DRIVERS"
<linux-serial@vger.kernel.org>,
imx@lists.linux.dev, vkoul@kernel.org
Subject: Re: [PATCH 1/1] tty: replace chan->device->dev with dmaengine_get_provider_device()
Date: Wed, 4 Nov 2026 10:47:42 +0200 [thread overview]
Message-ID: <aurxLlfOa1fAa19U@ashevche-desk.local> (raw)
In-Reply-To: <20261103215949.1827937-1-Frank.Li@oss.nxp.com>
On Tue, Nov 03, 2026 at 04:59:45PM -0500, Frank.Li@oss.nxp.com wrote:
>
> Use the dmaengine_get_provider_device() API instead of directly
> accessing chan->device->dev to get the DMA provider device.
>
> No functional change. Prepare make to struct dma_device private to the DMA
> engine.
...
> static bool dw8250_idma_filter(struct dma_chan *chan, void *param)
> {
> - return param == chan->device->dev;
> + return param == dmaengine_get_provider_device(chan);
> }
As mentioned in SPI patch, with another helper this function will gone.
...
> if ((chan->chan_id == param->chan_id) && (param->dma_dev ==
> - chan->device->dev)) {
> + dmaengine_get_provider_device(chan))) {
Fix indentation while at it.
if ((chan->chan_id == param->chan_id) &&
(param->dma_dev == dmaengine_get_provider_device(chan))) {
> chan->private = param;
> return true;
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-11-04 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 21:59 Frank.Li
2026-11-03 22:54 ` Ilpo Järvinen
2026-11-04 8:47 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aurxLlfOa1fAa19U@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=2426767509@qq.com \
--cc=Frank.Li@nxp.com \
--cc=Frank.Li@oss.nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=haoxiang_li2024@163.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=imx@lists.linux.dev \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rppt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®