mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Tang Bin <tangbin@cmss.chinamobile.com>
Cc: david.rhodes@cirrus.com, rf@opensource.cirrus.com,
	lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
	tiwai@suse.com, linux-sound@vger.kernel.org,
	patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] ASoC: cs42l43: leak MCLK when PLL enable fails on PRE_PMU
Date: Wed, 4 Nov 2026 11:04:26 +0000	[thread overview]
Message-ID: <ausROjYJJ2af1kXj@opensource.cirrus.com> (raw)
In-Reply-To: <20261104080257.1144-1-tangbin@cmss.chinamobile.com>

On Wed, Nov 04, 2026 at 04:02:57PM +0800, Tang Bin wrote:
> cs42l43_pll_ev() PRE_PMU arm enables mclk (when refclk_src is MCLK) then
> calls cs42l43_enable_pll(). If PLL enable fails, ret is negative and DAPM
> does not power up the widget, so POST_PMD never runs and the matching
> clk_disable_unprepare(mclk) at line 1621 is skipped - mclk refcount leaked.
> Roll back the mclk enable on PLL failure.

Could you point to the relevant bits of the core code here? My
understanding is that DAPM mostly just carrys on in the case of
an error from an event handler, so I would not expect the
sequence to play out as you describe.

Thanks,
Charles

      reply	other threads:[~2026-11-04 11:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04  8:02 Tang Bin
2026-11-04 11:04 ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ausROjYJJ2af1kXj@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=david.rhodes@cirrus.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=rf@opensource.cirrus.com \
    --cc=stable@vger.kernel.org \
    --cc=tangbin@cmss.chinamobile.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®