From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=194.117.254.33 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793793315; b=aXrxVkbBblRDrLzs2hC/N6RyF2S8Anpl7FP8P55BdjgQFSn49zlGOpBuFKcULNc5XWkc p10hu5mreJR4pWvZlEy+GRr5nTNmbBiW8hYGUHasdwgv7yN0XY5jT8idz83PHH+w0EILa lZpDSzB02GuDSfhGmbtjUSoTzhX/UCU6++EQJ9Crkbfv+zK5EOcxP6yzoRN2OjUkFkRxe eHzn1u0xflEANPSMKVJ3ErImz6ZDpfXtGiIdeopdfyNUCmkf7fW8hLRPgugUxasAVoy9X 7UKzdbUwMpCw9vZqKQHeT+ZuGZ+QKGmqo+YuqFx1mRaEYNIdgbK4mQ2lfhVckbeSu5w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793793315; h=DMARC-Filter:DKIM-Signature:Received:Received:X-UD-Smtp-Session:Date: From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; bh=F12AjCeObMo8GMff5Cd9gx8f+ATT0wwVACkVrTGxlyY=; b=Bbld92wi8PUwFChqYLsrxkyg95riZo9+2Yi0KgI/e9KWY04DuHeSbeMM3B4oY2vdx1HB rxUHh+xpu7I4S4p110z+ahzrx3A7aGanvL31TLWifw+P/uogT9Y23GWXAhgg2t9+CpTNa AGifOEudxUhmQ+0jjWgdlNXaQmNn2w6mBZZXKqePMqsMgWd8UoNTPi6CZ7Rbz22SRWw5K v/YHPyuxKNMuzgGoE7twflZiex/ZDagM5bIosOU14YfY0E33e/C6GCqEWPEp0EhSoaCsK rkLE9zLoCbnOepjmvqqsKzupW6wm7SXrVXNJeqKrQpCr4TvbrcLhCY1s2MuQZSZ8OIQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass header.d=sang-engineering.com header.i=@sang-engineering.com header.a=rsa-sha256 header.s=k1 header.b=QbXZ68bo; arc=none smtp.remote-ip=194.117.254.33 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65DD4606A31B for ; Wed, 4 Nov 2026 11:55:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 65DD4606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=sang-engineering.com header.i=@sang-engineering.com header.a=rsa-sha256 header.s=k1 header.b=QbXZ68bo DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=F12A jCeObMo8GMff5Cd9gx8f+ATT0wwVACkVrTGxlyY=; b=QbXZ68boAOIiNT4CEroe +FbKl+6S6VOO5SNwVsO9zbCtneUsv7Kh3StDFX05+gJ0/fpFdr3nHZ0Lw/mmQfon sJZwUkbYMFMPSlRCkubgjxgIOv1DeduEKrap57Juq3rb1SL1wVyZOMyyG2ZBuLdg lsKZFzb/xP26QmMlKZA4aOK5sudykwK3+Cu0fd6Pxp4Ogqpd33QFXqwnQmRwt5O6 excbPdUWcA/fct9a5k079M22fD4lAW1nvou0qo5BdUHrT2WJG1mNe/kcF0T/U0G7 jTrrsNtAO9+sJLGbeUPcQXsJ1bPMGIxIAEsYz8f/EdQIpUCSmwDb6gfkxpWs8YNa tQ== Received: (qmail 708253 invoked from network); 4 Nov 2026 12:54:59 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 4 Nov 2026 12:54:59 +0100 X-UD-Smtp-Session: l3s3148p1@jphgDHJf3LHAwtcC Date: Wed, 4 Nov 2026 13:54:58 +0200 From: Wolfram Sang To: "Peng Fan (OSS)" Cc: Codrin Ciubotariu , Andi Shyti , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Mika Westerberg , Andy Shevchenko , Oleksij Rempel , Pengutronix Kernel Team , Frank Li , Sascha Hauer , Fabio Estevam , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andreas Kemnade , Kevin Hilman , Roger Quadros , Vladimir Zapolskiy , Piotr Wojtaszczyk , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Linus Walleij , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] i2c: Convert to subsys_platform_driver() Message-ID: References: <20261104113316.1634141-1-peng.fan@oss.nxp.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261104113316.1634141-1-peng.fan@oss.nxp.com> Hi, > --- a/drivers/i2c/busses/i2c-davinci.c > +++ b/drivers/i2c/busses/i2c-davinci.c > @@ -896,19 +896,7 @@ static struct platform_driver davinci_i2c_driver = { > .of_match_table = davinci_i2c_of_match, > }, > }; > - > -/* I2C may be needed to bring up other drivers */ > -static int __init davinci_i2c_init_driver(void) I'd vote to keep this comment. > -{ > - return platform_driver_register(&davinci_i2c_driver); > -} > -subsys_initcall(davinci_i2c_init_driver); > - > -static void __exit davinci_i2c_exit_driver(void) > -{ > - platform_driver_unregister(&davinci_i2c_driver); > -} > -module_exit(davinci_i2c_exit_driver); > +subsys_platform_driver(davinci_i2c_driver); ... > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c > index bd659dfa702f..cd4d6d6b32c6 100644 > --- a/drivers/i2c/busses/i2c-omap.c > +++ b/drivers/i2c/busses/i2c-omap.c > @@ -1611,20 +1611,7 @@ static struct platform_driver omap_i2c_driver = { > .of_match_table = of_match_ptr(omap_i2c_of_match), > }, > }; > - > -/* I2C may be needed to bring up other drivers */ Ditto. > -static int __init > -omap_i2c_init_driver(void) > -{ > - return platform_driver_register(&omap_i2c_driver); > -} > -subsys_initcall(omap_i2c_init_driver); > - > -static void __exit omap_i2c_exit_driver(void) > -{ > - platform_driver_unregister(&omap_i2c_driver); > -} > -module_exit(omap_i2c_exit_driver); > +subsys_platform_driver(omap_i2c_driver); > > MODULE_AUTHOR("MontaVista Software, Inc. (and others)"); > MODULE_DESCRIPTION("TI OMAP I2C bus adapter"); > diff --git a/drivers/i2c/busses/i2c-pnx.c b/drivers/i2c/busses/i2c-pnx.c > index e1cc2b2bd628..9a9a12b7e981 100644 > --- a/drivers/i2c/busses/i2c-pnx.c > +++ b/drivers/i2c/busses/i2c-pnx.c > @@ -735,16 +735,6 @@ static struct platform_driver i2c_pnx_driver = { > .remove = i2c_pnx_remove, > }; > > -static int __init i2c_adap_pnx_init(void) > -{ > - return platform_driver_register(&i2c_pnx_driver); > -} > - > -static void __exit i2c_adap_pnx_exit(void) > -{ > - platform_driver_unregister(&i2c_pnx_driver); > -} > - > MODULE_AUTHOR("Vitaly Wool"); > MODULE_AUTHOR("Dennis Kovalev "); > MODULE_DESCRIPTION("I2C driver for Philips IP3204-based I2C busses"); > @@ -752,5 +742,4 @@ MODULE_LICENSE("GPL"); > MODULE_ALIAS("platform:pnx-i2c"); > > /* We need to make sure I2C is initialized before USB */ > -subsys_initcall(i2c_adap_pnx_init); > -module_exit(i2c_adap_pnx_exit); > +subsys_platform_driver(i2c_pnx_driver); Use this occasion to move the comment and your code upwards right below the driver struct? > diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c > index 3a55f803e4f1..1ecf14890209 100644 > --- a/drivers/i2c/busses/i2c-sh_mobile.c > +++ b/drivers/i2c/busses/i2c-sh_mobile.c > @@ -986,18 +986,7 @@ static struct platform_driver sh_mobile_i2c_driver = { > .probe = sh_mobile_i2c_probe, > .remove = sh_mobile_i2c_remove, > }; > - > -static int __init sh_mobile_i2c_adap_init(void) > -{ > - return platform_driver_register(&sh_mobile_i2c_driver); > -} > -subsys_initcall(sh_mobile_i2c_adap_init); > - > -static void __exit sh_mobile_i2c_adap_exit(void) > -{ > - platform_driver_unregister(&sh_mobile_i2c_driver); > -} > -module_exit(sh_mobile_i2c_adap_exit); > +subsys_platform_driver(sh_mobile_i2c_driver); Here you have no empty line after the driver struct... > > MODULE_DESCRIPTION("SuperH Mobile I2C Bus Controller driver"); > MODULE_AUTHOR("Magnus Damm"); > diff --git a/drivers/i2c/busses/i2c-versatile.c b/drivers/i2c/busses/i2c-versatile.c > index a1ab6ef6f071..152ab19f272a 100644 > --- a/drivers/i2c/busses/i2c-versatile.c > +++ b/drivers/i2c/busses/i2c-versatile.c > @@ -116,18 +116,7 @@ static struct platform_driver i2c_versatile_driver = { > }, > }; > > -static int __init i2c_versatile_init(void) > -{ > - return platform_driver_register(&i2c_versatile_driver); > -} > - > -static void __exit i2c_versatile_exit(void) > -{ > - platform_driver_unregister(&i2c_versatile_driver); > -} > - > -subsys_initcall(i2c_versatile_init); > -module_exit(i2c_versatile_exit); > +subsys_platform_driver(i2c_versatile_driver); ... while you have one here. Please make it consistent to no empty line. Other than that, looks good. Happy hacking, Wolfram