From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Andy Shevchenko <andy@kernel.org>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/7] gpiolib: use __free(gpiod_put_array) in gpiod_get_array()
Date: Wed, 4 Nov 2026 14:13:26 +0200 [thread overview]
Message-ID: <aushZraJyTywcwh4@ashevche-desk.local> (raw)
In-Reply-To: <20261103-b4-gpiolib-free-v2-5-ea46767c9cf8@gmail.com>
On Tue, Nov 03, 2026 at 07:40:33PM -0800, Dmitry Torokhov wrote:
> Switch to using __free(gpiod_put_array) scope-based cleanup facility
> in gpiod_get_array(), simplifying error unwinding and eliminating manual
> gpiod_put_array() calls.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
...
> - descs_size = struct_size(descs, desc, count);
> - descs = kzalloc(descs_size, GFP_KERNEL);
> + struct gpio_descs *descs __free(gpiod_put_array) =
> + kzalloc_flex(*descs, desc, count);
I believe in this case one line is also allowed.
struct gpio_descs *descs __free(gpiod_put_array) = kzalloc_flex(*descs, desc, count);
> if (!descs)
> return ERR_PTR(-ENOMEM);
...
> if (i == 0 && gpiod_hwgpio(desc) == 0) {
> struct gpio_descs *array;
> + size_t descs_size = struct_size(descs, desc, count);
Reversed xmas tree order?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-11-04 12:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 3:40 [PATCH v2 0/7] gpiolib: scope-based management and cleanup for GPIO descriptor arrays Dmitry Torokhov
2026-11-04 3:40 ` [PATCH v2 1/7] gpiolib: fix GPIO descriptor leak in gpiod_get_array() Dmitry Torokhov
2026-11-04 12:06 ` Andy Shevchenko
2026-11-04 12:08 ` Andy Shevchenko
2026-11-04 3:40 ` [PATCH v2 2/7] gpiolib: fix fast-path cancellation " Dmitry Torokhov
2026-11-04 12:09 ` Andy Shevchenko
2026-11-04 3:40 ` [PATCH v2 3/7] gpiolib: of: return -ENOENT from of_gpio_count() stub Dmitry Torokhov
2026-11-04 12:07 ` Andy Shevchenko
2026-11-04 3:40 ` [PATCH v2 4/7] gpiolib: add support for scope-based management of GPIO descriptors Dmitry Torokhov
2026-11-04 12:10 ` Andy Shevchenko
2026-11-04 3:40 ` [PATCH v2 5/7] gpiolib: use __free(gpiod_put_array) in gpiod_get_array() Dmitry Torokhov
2026-11-04 12:13 ` Andy Shevchenko [this message]
2026-11-04 3:40 ` [PATCH v2 6/7] gpiolib: avoid krealloc() " Dmitry Torokhov
2026-11-04 12:20 ` Andy Shevchenko
2026-11-04 18:14 ` Dmitry Torokhov
2026-11-04 3:40 ` [PATCH v2 7/7] gpiolib: use bitmap_zalloc() for fastpath bitmaps Dmitry Torokhov
2026-11-04 12:17 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aushZraJyTywcwh4@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=brgl@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jmkrzyszt@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®