From: Matthew Wilcox <willy@infradead.org>
To: Hungyu Lin <dennylin0707@gmail.com>
Cc: me@bobcopeland.com, akpm@linux-foundation.org,
linux-karma-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] omfs: reject writes starting beyond EOF
Date: Wed, 4 Nov 2026 14:32:16 +0000 [thread overview]
Message-ID: <autB8H-rCbbeTdF0@casper.infradead.org> (raw)
In-Reply-To: <20261104112052.5604-1-dennylin0707@gmail.com>
On Wed, Nov 04, 2026 at 11:20:52AM +0000, Hungyu Lin wrote:
> OMFS does not initialize gaps between EOF and a buffered write. When the
> requested block lies beyond the allocated extents, omfs_get_block() grows
> the last extent and maps the write to the newly allocated block without
> accounting for the skipped logical blocks.
>
> A one-byte pwrite() at offset 8192 into an empty file returns success, as
> does fsync(), but after remounting the byte is at offset 0 and offset 8192
> reads as zero.
>
> Reject writes starting beyond i_size before block_write_begin() can
> allocate or map buffers. Overwrites, appends and writes crossing EOF
> remain allowed. Gap initialization can be implemented separately.
Why don't we just delete omfs?
This is the proprietary file system used by the Rio Karma music
player and ReplayTV DVR
Rio Karma and ReplayTV were both EOL in 2005. Let's just delete this
filesystem.
prev parent reply other threads:[~2026-11-04 14:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 11:20 Hungyu Lin
2026-11-04 14:32 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=autB8H-rCbbeTdF0@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dennylin0707@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-karma-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®