mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Richter <rusricht@po2.uni-stuttgart.de>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] snd_hda_intel for F/S T4210
Date: Wed, 29 Aug 2007 17:34:19 +0200	[thread overview]
Message-ID: <auto-000088556249@uni-stuttgart.de> (raw)

Hi folks,

the patch below, to be applied to sound/pci/hda/patch_sigmatel.c fixes the audio
output on the Fujiutsu/Siemens lifebook T4210 (and probably on others). It is
suitable for the kernel 2.6.23-rc4 (and probably others).

Without the patch, audio fails and the hda driver fails to load with

No available DAC for pin 0x0

However, the indicated pin has no connections in first place and thus should be ignored.
With the patch applied audio output works fine.

Here's the patch:

/* snip */
--- patch_sigmatel_old.c        2007-08-29 17:17:51.000000000 +0200
+++ patch_sigmatel.c    2007-08-29 17:21:25.000000000 +0200
@@ -1250,6 +1250,16 @@
                nid = cfg->line_out_pins[i];
                conn_len = snd_hda_get_connections(codec, nid, conn,
                                                   HDA_MAX_CONNECTIONS);
+               /* FIX THOR: For some hardware (notably the Fujiutsu/Siemens T4210
+               ** lifebook), we have nids with no pins whatsoever. Ignore
+               ** them.
+               */
+               if (conn_len == 0) {
+                 snd_printk(KERN_ERR "%s: Found zero connections for pin 0x%0x "
+                            "ignoring it.\n",__func__,nid);
+                 continue;
+               }
+
                for (j = 0; j < conn_len; j++) {
                        wcaps = snd_hda_param_read(codec, conn[j],
                                                   AC_PAR_AUDIO_WIDGET_CAP);
/* snip */

Greetings,
	Thomas

             reply	other threads:[~2007-08-29 15:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-29 15:34 Thomas Richter [this message]
2007-08-30 15:04 ` Takashi Iwai
2007-08-31 11:08   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auto-000088556249@uni-stuttgart.de \
    --to=rusricht@po2.uni-stuttgart.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome