Re: [PATCH 1/1] tty: serial: use dmaengine_desc_set_callback()

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Wed, Nov 04, 2026 at 06:41:08PM +0100, Krzysztof Kozlowski wrote:
> On 02/11/2026 18:54, Frank.Li@oss.nxp.com wrote:
> > 
> > Replace open-coded assignments to callback and callback_param fields
> > of struct dma_async_tx_descriptor with calls to the
> > dmaengine_desc_set_callback() helper across serial drivers.
> > 
> > No functional change intended. Prepare to make struct
> > dma_async_tx_descriptor private to the DMA engine.

...

> I did not look at this code at all...
> 
> > index 640f85e2d636b..3f82a83998e1c 100644
> > --- a/drivers/tty/serial/samsung_tty.c
> > +++ b/drivers/tty/serial/samsung_tty.c
> > @@ -447,8 +447,7 @@ static int s3c24xx_serial_start_tx_dma(struct s3c24xx_uart_port *ourport,
> >  		return -EIO;
> >  	}
> >  
> > -	dma->tx_desc->callback = s3c24xx_serial_tx_dma_complete;
> > -	dma->tx_desc->callback_param = ourport;
> > +	dmaengine_desc_set_callback(dma->tx_desc, s3c24xx_serial_tx_dma_complete, NULL, ourport);
> >  	dma->tx_bytes_requested = dma->tx_size;
> >  
> >  	ourport->tx_in_progress = S3C24XX_TX_DMA;
> > @@ -642,8 +641,7 @@ static void s3c64xx_start_rx_dma(struct s3c24xx_uart_port *ourport)
> >  		return;
> >  	}
> >  
> > -	dma->rx_desc->callback = s3c24xx_serial_rx_dma_complete;
> > -	dma->rx_desc->callback_param = ourport;
> > +	dmaengine_desc_set_callback(dma->rx_desc, s3c24xx_serial_rx_dma_complete, NULL, ourport);
> >  	dma->rx_bytes_requested = dma->rx_size;

> ... but apparently reviewing only a few lines out of 400 is still reviewing:
> 
> https://lore.kernel.org/all/9e39502a-dd17-4fa2-98a3-9019523cb5e8@kernel.org/
> 
> Therefore:
> 
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

That's why I have added a trail to it to show what exactly I has reviewed,
this is a common practice, no?

Does this ring a bell 34d1e754155b ("dt-bindings: iio: drop unneeded quotes")?

-- 
With Best Regards,
Andy Shevchenko