From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=192.198.163.16 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793824475; b=i83aI4gIfWzud97AfEDLo2au77JyC741eVqRO4XcpDgxG2qUcItKlFocWvzaO2Iqh+Bq lW0o4krMN50EIhpGhpk1/HGYJET6umMgAWsmOiLeIvVuoyMDefcMk3qy3gDEAuFqwlTCr a89sp71ol7fLzgeDvD+Wth1IvOb5o6tTKd8SDCeU38vzIfgx9U0ZF7gOYt9CqoaM8eqBe 2D/RlD3BnZVJxSn83SbAnyQzj9Hn6Gp0P/SN67wXzADGLw5TPBj8qZ7uSKTlDuzBkfRx6 escT0R0qLJYBIPm/CqkXBKbv+gcZXQ4ol57+uvzwYLJQNGluOafyBrbtLQ3wbh/mgeQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793824475; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:Organization; bh=qRsZY3xueLsYo81EeFYIjiC4t2ZfkCtOq22VvO5dYxA=; b=ME/3YUjsUo230CRlCJvUDoP9n9qTSRYpl4fmsZXsijW4vL+mMh+rJNnv4IF1IQGs7utn S6wcHE9hVDk9eK9ZieXF7yx66lG6Q3aTm6gvgsm+06t9xr5zLEh/BosgxxqQNPZrYKDRw 1w63pvFu1c1r74woSz+SocaP+sInk8iWzP7mTgzNfggaGkXxLclLe9z4Y75KCguWoogPQ kuuDZOjZeYTI9THR+/VnaVk8C2tDY0NM+3XOJcUmhm27GDR1f+rM9ZnxoCZfGf3OD2vWb BSwk4pzGM4FYT5tBxPR3z8sPOiz9DjEAUc+IKctVyUcyRI1jtx9QijheW5wER1KiQqg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=flLLQg46; arc=none smtp.remote-ip=192.198.163.16 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B918606AB31; Wed, 4 Nov 2026 20:34:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 6B918606AB31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=flLLQg46 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793824475; x=1825360475; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=StSSW5/xpW0MGVJqCQ72E4YsaavMQP4nt5umVauhYso=; b=flLLQg46O2M6J+ogWtr7H/PhnqpoImgqcs/izKeta51h0tYW8OYbtEg1 w/vaj6rYDYoiaq7f7Jf8/+SawRJmBGjwOQiurRaKoIm6Et22V6bR7cqBK gPn7a5DvdCavOJ17ijfCvAZIqY7i14ORggAtOApCbo0krNLQo8hfA0RyL dDJCIDA/92Du1TY8czZhnyVBTPTCEG8CB7OpalKnSp+TPCDqHOzCnqyLU SGVux3/s/ghcmwUeVv8xV5Z3guv7k6YUzcdIIvmCzagkd2jHxYNeueI5D PlJz1ELxyATHZMRNuFGkUCJRp5HaduC0YMkrD2l1jhv0ShY1aJuJsk8ZN w==; X-CSE-ConnectionGUID: sLDKA66fQ/u7ChElgOMcOA== X-CSE-MsgGUID: XfM4BTJyQTeHE7sODUF/Sg== X-IronPort-AV: E=McAfee;i="6800,10657,11956"; a="2613577" X-IronPort-AV: E=Sophos;i="6.27,195,1787036400"; d="scan'208";a="2613577" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2026 12:34:34 -0800 X-CSE-ConnectionGUID: rXnAXH6STZCbtlf11xATow== X-CSE-MsgGUID: nn0XOPIDS0qODXMv7b+VxA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,195,1787036400"; d="scan'208";a="7138628" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.24]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2026 12:34:29 -0800 Date: Wed, 4 Nov 2026 22:34:26 +0200 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Frank.Li@oss.nxp.com, Herbert Xu , "David S. Miller" , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Jia Jie Ho , William Qiu , Maxime Coquelin , Alexandre Torgue , T Pratham , Thorsten Blum , Frank Li , Pan Chuang , Maxime =?iso-8859-1?Q?M=E9r=E9?= , "open list:CRYPTO API" , "moderated list:ARM/Microchip (AT91) SoC support" , open list , "open list:QUALCOMM CRYPTO DRIVERS" , "moderated list:ARM/STM32 ARCHITECTURE" , imx@lists.linux.dev, vkoul@kernel.org Subject: Re: [PATCH 1/1] crypto: use dmaengine_desc_set_callback() Message-ID: References: <20261102164538.3834039-1-Frank.Li@oss.nxp.com> <7b476c24-3185-49ff-9a72-fbd865dc0d65@kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7b476c24-3185-49ff-9a72-fbd865dc0d65@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Nov 04, 2026 at 06:51:10PM +0100, Krzysztof Kozlowski wrote: > On 02/11/2026 17:45, Frank.Li@oss.nxp.com wrote: > > diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c > > index 84392411b98d8..49f1bf19747d8 100644 > > --- a/drivers/crypto/atmel-aes.c > > +++ b/drivers/crypto/atmel-aes.c > > @@ -824,8 +824,7 @@ static int atmel_aes_dma_transfer_start(struct atmel_aes_dev *dd, > > if (!desc) > > return -ENOMEM; > > > > - desc->callback = callback; > > - desc->callback_param = dd; > > + dmaengine_desc_set_callback(desc, callback, NULL, dd); > > dmaengine_submit(desc); > > dma_async_issue_pending(dma->chan); > > > > Apparently reviewing only a few lines of entire patch is still reviewing: > https://lore.kernel.org/all/9e39502a-dd17-4fa2-98a3-9019523cb5e8@kernel.org/ > > Therefore: > Reviewed-by: Krzysztof Kozlowski Yep, in a form of Reviewed-by: Krzysztof Kozlowski # atmel-aes or something that makes it clear what has been reviewed. -- With Best Regards, Andy Shevchenko