From: Mike Rapoport <rppt@kernel.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
chenhuacai@kernel.org, kernel@xen0n.name, maddy@linux.ibm.com,
mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org,
ritesh.list@gmail.com, sshegde@linux.ibm.com, pjw@kernel.org,
palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr,
tglx@kernel.org, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com,
akpm@linux-foundation.org, baoquan.he@linux.dev,
pasha.tatashin@soleen.com, pratyush@kernel.org, thuth@redhat.com,
leitao@debian.org, yeoreum.yun@arm.com, robh@kernel.org,
sourabhjain@linux.ibm.com, kees@kernel.org, coiby.xu@gmail.com,
Yeking@red54.com, tangyouling@kylinos.cn, maqianga@uniontech.com,
zhangtianyang@loongson.cn, guodongtai@kylinos.cn,
blum@kernel.org, adityag@linux.ibm.com, hui.wang@canonical.com,
sohammetha01@gmail.com, guoren@kernel.org, gaohan@iscas.ac.cn,
kai.huang@intel.com, kas@kernel.org, vishal.l.verma@intel.com,
piliu@redhat.com, jbouron@amazon.com, mclapinski@google.com,
me@linux.beauty, graf@amazon.com, bgwin@google.com,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
kexec@lists.infradead.org
Subject: Re: [PATCH v7 00/15] kexec: Fix CMA and elf header leaks and rework
Date: Thu, 5 Nov 2026 09:52:10 +0200 [thread overview]
Message-ID: <auw1qgmjWko52oS_@kernel.org> (raw)
In-Reply-To: <932cdfda-7030-4829-8b43-062d208450e4@huawei.com>
On Thu, Nov 05, 2026 at 11:45:39AM +0800, Jinjie Ruan wrote:
> 在 2026/11/4 22:56, Mike Rapoport 写道:
>
> >> Patches 8-10 pass the kbuf fields to crash_prepare_headers() to
> >> simplfy code.
> >>
> >> Patch 11 frees the elf core header from the generic post-load cleanup.
> >>
> >> Patches 12-15 add kexec_load_other_segments() and convert the three
> >> architectures, and arch_kexec_setup_other_segments() builds
> >> the architecture specific boot parameters (a DTB or a command line).
> >
> > I think the refactoring should go before the identical fixes in arch/
> > code.
>
> However, this will cause trouble for the fix patch in the stable round.
That's right, but since actual fixes anyway require changes to kexec core,
I think it's better to refactor first. The core than will take care of
proper freeing in the most cases.
And since CMA support in kexec is quite new I think the entire set can be
backported to stable then.
I'm planning to have a closer look at the refactoring Really Soon :)
> --
> Best regards,
> Jinjie
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-11-05 7:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 7:51 Jinjie Ruan
2026-10-26 7:51 ` [PATCH v7 01/15] arm64: kexec_file: Stop using the Image text_offset Jinjie Ruan
2026-10-26 7:51 ` [PATCH v7 02/15] kexec: Extract kexec_free_segment_cma() from kimage_free_cma() Jinjie Ruan
2026-10-26 7:51 ` [PATCH v7 03/15] arm64: kexec_file: Fix CMA page leaks in segment placement retry loops Jinjie Ruan
2026-11-03 9:15 ` Jinjie Ruan
2026-10-26 7:51 ` [PATCH v7 04/15] arm64: kexec_file: Fix elf_headers memory leak in retry loop Jinjie Ruan
2026-10-26 7:51 ` [PATCH v7 05/15] LoongArch: kexec_file: Fix CMA page leaks in segment placement retry loops Jinjie Ruan
2026-11-03 9:16 ` Jinjie Ruan
2026-10-26 7:51 ` [PATCH v7 06/15] LoongArch: kexec_file: Fix elf_headers memory leak in retry loop Jinjie Ruan
2026-10-26 7:51 ` [PATCH v7 07/15] LoongArch: kexec_file: Fix a modified_cmdline leak Jinjie Ruan
2026-10-26 7:51 ` [PATCH v7 08/15] arm64: kexec_file: Simplify load_other_segments() Jinjie Ruan
2026-10-26 7:51 ` [PATCH v7 09/15] LoongArch: " Jinjie Ruan
2026-10-26 7:51 ` [PATCH v7 10/15] riscv: kexec_file: Simplify load_extra_segments() Jinjie Ruan
2026-10-26 7:51 ` [PATCH v7 11/15] kexec: Free the elf core header in kimage_file_post_load_cleanup() Jinjie Ruan
2026-10-26 7:51 ` [PATCH v7 12/15] kexec: Add kexec_load_other_segments() helper Jinjie Ruan
2026-10-26 7:51 ` [PATCH v7 13/15] arm64: kexec_file: Use kexec_load_other_segments() to simplify code Jinjie Ruan
2026-10-26 7:52 ` [PATCH v7 14/15] LoongArch: " Jinjie Ruan
2026-10-26 7:52 ` [PATCH v7 15/15] riscv: " Jinjie Ruan
2026-11-03 9:14 ` [PATCH v7 00/15] kexec: Fix CMA and elf header leaks and rework Jinjie Ruan
2026-11-04 14:56 ` Mike Rapoport
2026-11-05 3:45 ` Jinjie Ruan
2026-11-05 7:52 ` Mike Rapoport [this message]
2026-11-05 8:04 ` Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auw1qgmjWko52oS_@kernel.org \
--to=rppt@kernel.org \
--cc=Yeking@red54.com \
--cc=adityag@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=baoquan.he@linux.dev \
--cc=bgwin@google.com \
--cc=blum@kernel.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=chleroy@kernel.org \
--cc=coiby.xu@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=gaohan@iscas.ac.cn \
--cc=graf@amazon.com \
--cc=guodongtai@kylinos.cn \
--cc=guoren@kernel.org \
--cc=hpa@zytor.com \
--cc=hui.wang@canonical.com \
--cc=jbouron@amazon.com \
--cc=kai.huang@intel.com \
--cc=kas@kernel.org \
--cc=kees@kernel.org \
--cc=kernel@xen0n.name \
--cc=kexec@lists.infradead.org \
--cc=leitao@debian.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=maddy@linux.ibm.com \
--cc=maqianga@uniontech.com \
--cc=mark.rutland@arm.com \
--cc=mclapinski@google.com \
--cc=me@linux.beauty \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pasha.tatashin@soleen.com \
--cc=piliu@redhat.com \
--cc=pjw@kernel.org \
--cc=pratyush@kernel.org \
--cc=ritesh.list@gmail.com \
--cc=robh@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=sohammetha01@gmail.com \
--cc=sourabhjain@linux.ibm.com \
--cc=sshegde@linux.ibm.com \
--cc=tangyouling@kylinos.cn \
--cc=tglx@kernel.org \
--cc=thuth@redhat.com \
--cc=vishal.l.verma@intel.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=yeoreum.yun@arm.com \
--cc=zhangtianyang@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®