From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.62 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793861025; b=Fo9cKSdYM6gKzd0SXIVTIgzogND+2jgzLVtqqjRAFMNeY0BEbjkLX5ggtYSuIPryenwB ohYAbbEbdaNV73x1E+rbHD26IWw+sPqrPUPgaIEHD6XJgo+IZUj+hHiU+kdgEMLnZBSyA J0kCOrmxfMQlbkDps1+2yuJlDQPnghNjvtcKgRGjOxDDfjwGogL/QXjo2SERrjfvVAjHm YkirlLb9PIttGTlO1Ut54SI1UNegNA6GNh/GGbn1KOT8p1ka4ZAWK+nGAa4+Kvz1YshOG ogYGZvm5CXzrzVsBuaz9MkfG43hI3vq8ZUKEctsQvYd/PnacmzPjD8cBMRqBGcnzi3A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793861025; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=VLLZjXMmTQmjz6A0S5RDZnlHH5IW/gvBf0f/hTwSx+Q=; b=0bzLSEw0HMkoyr1h01CTjF+PkYcC1AIQB7C6WOeI5/+3CBcS/PhUydy6h3MhtANfS36A AGcht5TlTfu77aU1AjCpankKYuxfK7qv7TJlm/LcFe9lJpGQyBzwX/eY1wASiAj0AVn04 9f8Ca74+73sRuFxAGJwFacF75iHaHHJab54So2GLjvk5LbKGaGckA4zZAAidI+FCgxPI8 CELJjTs4CpzuodSeaYymrI1KAUknhKf+z7HXVErEfWxdGrrgNvUvLaLyvuGZ54DkDE5gi Va0cAhqd4LD0bx6688dHvopZ7b9DwZlnTRXDq50SC2L/y5mmahIhvVF4iVlJR1UpLvg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=Dr3KtrT7; arc=none smtp.remote-ip=95.215.58.62 Received: from mta1.migadu.com (out-62.mta1.migadu.com [95.215.58.62]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E2D5606A33E for ; Thu, 5 Nov 2026 06:43:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 0E2D5606A33E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=Dr3KtrT7 X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=TWkp5Lnn5QB+qibeKwukcrGkB96ZSbaKyvgbcrCA0z0=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793861022; v=1; x=1794465822; b=Dr3KtrT7CgIYiYmuLuynQz7FsyQquKcK5x6eBmHQgVizR9nUejIlgWIrjoNHYZg7TqZv2yrb nRUb7AWBBNz4ccZFgi3c4heqgBUOpx63NV3QTCQgXBcnai8jnkiLqUiX24jgAjx13k9IgI3hXf0 Sd+OCZxBT0wx5Q9qRFtz7DRE= X-Envelope-To: linux-kernel@vger.kernel.org Received: by mta10.migadu.com with ESMTPS id 868ae7c57c796658; Thu, 05 Nov 2026 06:43:41 +0000 X-Mizu-Trace-ID: 868ae7c57c796658 X-Migadu-Flow: FLOW_OUT Date: Thu, 5 Nov 2026 14:43:27 +0800 From: Hangbin Liu To: Timur Stukan Cc: netdev@vger.kernel.org, Nikolay Aleksandrov , Fernando Fernandez Mancera , Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jarod Wilson , linux-kernel@vger.kernel.org Subject: Re: [PATCH net] bonding: 3ad: don't set BOND_LINK_FAIL on a slave that is not up Message-ID: References: <20261101145653.63648-1-timur.stukan.linux@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261101145653.63648-1-timur.stukan.linux@gmail.com> On Sun, Nov 01, 2026 at 04:56:53PM +0200, Timur Stukan wrote: > In 802.3ad mode, when bond_update_speed_duplex() fails on NETDEV_UP or > NETDEV_CHANGE, bond_slave_netdev_event() sets the slave link to FAIL if > the slave has ever been up (last_link_up != 0), and to DOWN otherwise, > so that miimon can set it right once speed/duplex are valid. > > last_link_up is never cleared, so a slave that is currently DOWN but > was up before is set to FAIL as well. miimon then treats it as a slave > that is still in use and takes it through the full down path again: > the link failure count is incremented, "link status definitely down" > is logged and the 802.3ad port is disabled a second time, although the > slave has not been up since it went down. > > Reproduced in 802.3ad mode with miimon=100 by setting a slave down and > up again. On NETDEV_UP the speed is still unknown, so the notifier sets > FAIL, and the next miimon pass sees no carrier and proposes DOWN: > > ip link add bond0 type bond mode 802.3ad miimon 100 lacp_rate 1 > ip link set enp0s3 down > ip link set enp0s4 down > ip link set enp0s3 master bond0 > ip link set enp0s4 master bond0 > ip link set enp0s3 up > ip link set enp0s4 up > ip link set bond0 up > # wait for LACP to settle > ip link set enp0s3 down > ip link set enp0s3 up > > procfs then shows "Link Failure Count: 2" in enp0s3 slave part. Also in > dmesg wrote twice: "link status definitely down, disabling slave". > > Fix this by setting FAIL only for a slave that is currently UP and > leaving other states alone. An up slave that loses speed/duplex still > goes through FAIL as before, and DOWN/BACK slaves are left to miimon, > as in the other modes. > > Fixes: ea53abfab960 ("bonding/802.3ad: fix link_failure_count tracking") > Signed-off-by: Timur Stukan > --- > drivers/net/bonding/bond_main.c | 15 +++++---------- > 1 file changed, 5 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index 7019e5d8fdc8..8212d406f3bc 100644 > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c > @@ -3973,18 +3973,13 @@ static int bond_slave_netdev_event(unsigned long event, > case NETDEV_CHANGE: > /* For 802.3ad mode only: > * Getting invalid Speed/Duplex values here will put slave > - * in weird state. Mark it as link-fail if the link was > - * previously up or link-down if it hasn't yet come up, and > - * let link-monitoring (miimon) set it right when correct > - * speeds/duplex are available. > + * in weird state. Mark an up slave as link-fail and let > + * miimon set it right when correct speed/duplex are available. > */ > if (bond_update_speed_duplex(slave) && > - BOND_MODE(bond) == BOND_MODE_8023AD) { > - if (slave->last_link_up) > - slave->link = BOND_LINK_FAIL; > - else > - slave->link = BOND_LINK_DOWN; > - } > + BOND_MODE(bond) == BOND_MODE_8023AD && > + slave->link == BOND_LINK_UP) > + slave->link = BOND_LINK_FAIL; > > if (BOND_MODE(bond) == BOND_MODE_8023AD) > bond_3ad_adapter_speed_duplex_changed(slave); > -- > 2.43.0 > Reviewed-by: Hangbin Liu